Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to parse REACT_EDITOR in env #21331

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Fix to parse REACT_EDITOR in env #21331

merged 2 commits into from
Jan 26, 2021

Conversation

youngvform
Copy link
Contributor

I made an issue #21330.

I think this line

next.js/packages/react-dev-overlay/src/internal/helpers/launchEditor.ts

Line 216 in 0bd1752

return shellQuote.parse(process.env.REACT_EDITOR)
return string array and toLowerCase is undefined in string array so throw error.

I fixed it by referring to launchEditor of create react app.

@ijjk
Copy link
Member

ijjk commented Jan 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary youngvform/next.js fix/guess-editor Change
buildDuration 10.2s 8.8s -1.4s
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +58 B
Page Load Tests Overall increase ✓
vercel/next.js canary youngvform/next.js fix/guess-editor Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.044 1.78 -0.26
/ avg req/sec 1223.27 1404.83 +181.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.277 1.118 -0.16
/error-in-render avg req/sec 1957.19 2236.77 +279.58
Client Bundles (main, webpack, commons)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary youngvform/next.js fix/guess-editor Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary youngvform/next.js fix/guess-editor Change
buildDuration 10.4s 10.1s -219ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +58 B
Client Bundles (main, webpack, commons)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary youngvform/next.js fix/guess-editor Change
buildDuration 11s 11.9s ⚠️ +925ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +58 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary youngvform/next.js fix/guess-editor Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.753 1.892 ⚠️ +0.14
/ avg req/sec 1426.29 1321.37 ⚠️ -104.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.134 1.264 ⚠️ +0.13
/error-in-render avg req/sec 2204.26 1978.13 ⚠️ -226.13
Client Bundles (main, webpack, commons)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
778-d412f8e7..3ee1.js gzip 6.56 kB 6.56 kB ✓
838-adcbad39..6e83.js gzip 31.1 kB 31.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-6a6a792..6877.js gzip 96 B 96 B ✓
webpack-e302..54e9.js gzip 954 B 954 B ✓
Overall change 91 kB 91 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
polyfills-a0..538c.js gzip 88 B 88 B ✓
Overall change 88 B 88 B ✓
Client Pages
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary youngvform/next.js fix/guess-editor Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "BDxyKwvdXedneLVn6BUUX",
+        "buildId": "Bw-XUcGHBI0m9pmrqth0W",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/BDxyKwvdXedneLVn6BUUX/_buildManifest.js"
+      src="/_next/static/Bw-XUcGHBI0m9pmrqth0W/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/BDxyKwvdXedneLVn6BUUX/_ssgManifest.js"
+      src="/_next/static/Bw-XUcGHBI0m9pmrqth0W/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "BDxyKwvdXedneLVn6BUUX",
+        "buildId": "Bw-XUcGHBI0m9pmrqth0W",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/BDxyKwvdXedneLVn6BUUX/_buildManifest.js"
+      src="/_next/static/Bw-XUcGHBI0m9pmrqth0W/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/BDxyKwvdXedneLVn6BUUX/_ssgManifest.js"
+      src="/_next/static/Bw-XUcGHBI0m9pmrqth0W/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "BDxyKwvdXedneLVn6BUUX",
+        "buildId": "Bw-XUcGHBI0m9pmrqth0W",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/BDxyKwvdXedneLVn6BUUX/_buildManifest.js"
+      src="/_next/static/Bw-XUcGHBI0m9pmrqth0W/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/BDxyKwvdXedneLVn6BUUX/_ssgManifest.js"
+      src="/_next/static/Bw-XUcGHBI0m9pmrqth0W/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 0a3c88f

timneutkens
timneutkens approved these changes Jan 26, 2021 •
edited
Loading
View reviewed changes
timneutkens
timneutkens approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@ijjk
Copy link
Member

ijjk commented Jan 26, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary youngvform/next.js fix/guess-editor Change
buildDuration 10.8s 11.4s ⚠️ +566ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +89.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary youngvform/next.js fix/guess-editor Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.164 2.288 ⚠️ +0.12
/ avg req/sec 1155.44 1092.76 ⚠️ -62.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.401 1.399 0
/error-in-render avg req/sec 1784.78 1786.77 +1.99
Client Bundles (main, webpack, commons)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary youngvform/next.js fix/guess-editor Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary youngvform/next.js fix/guess-editor Change
buildDuration 13.1s 12.9s -191ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +89.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary youngvform/next.js fix/guess-editor Change
buildDuration 13.3s 13.1s -116ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +89.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary youngvform/next.js fix/guess-editor Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.131 2.141 ⚠️ +0.01
/ avg req/sec 1173.03 1167.67 ⚠️ -5.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.374 1.3 -0.07
/error-in-render avg req/sec 1819.92 1923.5 +103.58
Client Bundles (main, webpack, commons)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
597-c48889ef..1870.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary youngvform/next.js fix/guess-editor Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary youngvform/next.js fix/guess-editor Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary youngvform/next.js fix/guess-editor Change
index.html gzip 587 B 587 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "iKYZ0ktI2TaMk35HaQj3j",
+        "buildId": "3DOcV53K-hGv5YlBNM7JV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/iKYZ0ktI2TaMk35HaQj3j/_buildManifest.js"
+      src="/_next/static/3DOcV53K-hGv5YlBNM7JV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/iKYZ0ktI2TaMk35HaQj3j/_ssgManifest.js"
+      src="/_next/static/3DOcV53K-hGv5YlBNM7JV/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "iKYZ0ktI2TaMk35HaQj3j",
+        "buildId": "3DOcV53K-hGv5YlBNM7JV",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/iKYZ0ktI2TaMk35HaQj3j/_buildManifest.js"
+      src="/_next/static/3DOcV53K-hGv5YlBNM7JV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/iKYZ0ktI2TaMk35HaQj3j/_ssgManifest.js"
+      src="/_next/static/3DOcV53K-hGv5YlBNM7JV/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "iKYZ0ktI2TaMk35HaQj3j",
+        "buildId": "3DOcV53K-hGv5YlBNM7JV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/iKYZ0ktI2TaMk35HaQj3j/_buildManifest.js"
+      src="/_next/static/3DOcV53K-hGv5YlBNM7JV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/iKYZ0ktI2TaMk35HaQj3j/_ssgManifest.js"
+      src="/_next/static/3DOcV53K-hGv5YlBNM7JV/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: f59a273

@kodiakhq kodiakhq bot merged commit 3368fdd into vercel:canary Jan 26, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youngvform @ijjk @timneutkens