-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style loader without externals #21359
Conversation
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
buildDuration | 8.7s | 8.6s | -114ms |
nodeModulesSize | 75.3 MB | 75.5 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.782 | 1.764 | -0.02 |
/ avg req/sec | 1403.05 | 1416.92 | +13.87 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.096 | 1.098 | 0 |
/error-in-render avg req/sec | 2281.17 | 2277.8 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
677f882d2ed8..43e3.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
_app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
index.html gzip | 616 B | 616 B | ✓ |
link.html gzip | 622 B | 622 B | ✓ |
withRouter.html gzip | 608 B | 608 B | ✓ |
Overall change | 1.85 kB | 1.85 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
buildDuration | 10.6s | 10.4s | -218ms |
nodeModulesSize | 75.3 MB | 75.5 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
677f882d2ed8..43e3.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
_app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.19 MB | 5.19 MB | ✓ |
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
buildDuration | 10.5s | 10.8s | |
nodeModulesSize | 75.3 MB | 75.5 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.764 | 1.755 | -0.01 |
/ avg req/sec | 1417.3 | 1424.58 | +7.28 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.094 | 1.13 | |
/error-in-render avg req/sec | 2285.11 | 2211.99 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
597-3bd7d6bd..868b.js gzip | 13 kB | 13 kB | ✓ |
framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 6.58 kB | 6.58 kB | ✓ |
webpack-HASH.js gzip | 954 B | 954 B | ✓ |
Overall change | 59.8 kB | 59.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
_app-a5b2e84..33cf.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error-6f1f9..5577.js gzip | 3.38 kB | 3.38 kB | ✓ |
hooks-725de8..0a15.js gzip | 904 B | 904 B | ✓ |
index-939503..6e1c.js gzip | 232 B | 232 B | ✓ |
link-e0cc871..fdbb.js gzip | 1.63 kB | 1.63 kB | ✓ |
routerDirect..9360.js gzip | 308 B | 308 B | ✓ |
withRouter-6..44ec.js gzip | 304 B | 304 B | ✓ |
Overall change | 8.02 kB | 8.02 kB | ✓ |
Client Build Manifests
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
_buildManifest.js gzip | 299 B | 299 B | ✓ |
Overall change | 299 B | 299 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | guybedford/next.js style-loader | Change | |
---|---|---|---|
index.html gzip | 587 B | 587 B | ✓ |
link.html gzip | 593 B | 593 B | ✓ |
withRouter.html gzip | 581 B | 581 B | ✓ |
Overall change | 1.76 kB | 1.76 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "gKqCkGLYlOQlgKsZHOiZA",
+ "buildId": "1hHz4L70AJzyI5hHmyPyu",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/gKqCkGLYlOQlgKsZHOiZA/_buildManifest.js"
+ src="/_next/static/1hHz4L70AJzyI5hHmyPyu/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/gKqCkGLYlOQlgKsZHOiZA/_ssgManifest.js"
+ src="/_next/static/1hHz4L70AJzyI5hHmyPyu/_ssgManifest.js"
async=""
></script>
</body>
Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "gKqCkGLYlOQlgKsZHOiZA",
+ "buildId": "1hHz4L70AJzyI5hHmyPyu",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/gKqCkGLYlOQlgKsZHOiZA/_buildManifest.js"
+ src="/_next/static/1hHz4L70AJzyI5hHmyPyu/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/gKqCkGLYlOQlgKsZHOiZA/_ssgManifest.js"
+ src="/_next/static/1hHz4L70AJzyI5hHmyPyu/_ssgManifest.js"
async=""
></script>
</body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "gKqCkGLYlOQlgKsZHOiZA",
+ "buildId": "1hHz4L70AJzyI5hHmyPyu",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/gKqCkGLYlOQlgKsZHOiZA/_buildManifest.js"
+ src="/_next/static/1hHz4L70AJzyI5hHmyPyu/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/gKqCkGLYlOQlgKsZHOiZA/_ssgManifest.js"
+ src="/_next/static/1hHz4L70AJzyI5hHmyPyu/_ssgManifest.js"
async=""
></script>
</body>
Failing test suitesCommit: cbd4a66 test/integration/dynamic-routing/test/index.test.js
Expand output● Dynamic Routing › dev mode › [nested ssg: catch all] should pass params in getStaticProps during SSR
● Dynamic Routing › dev mode › [predefined ssg: catch all] should pass param in getStaticProps during SSR
● Dynamic Routing › dev mode › [predefined ssg: catch all] should pass params in getStaticProps during SSR
● Dynamic Routing › dev mode › [predefined ssg: prerendered catch all] should pass param in getStaticProps during SSR
● Dynamic Routing › dev mode › [predefined ssg: prerendered catch all] should pass params in getStaticProps during SSR
● Dynamic Routing › dev mode › [ssg: catch-all] should pass params in getStaticProps during client navigation (single)
● Dynamic Routing › dev mode › [ssg: catch-all] should pass params in getStaticProps during client navigation (single interpolated)
● Dynamic Routing › dev mode › [ssg: catch-all] should pass params in getStaticProps during client navigation (multi)
● Dynamic Routing › dev mode › [ssg: catch-all] should pass params in getStaticProps during client navigation (multi) no as
● Dynamic Routing › dev mode › [ssg: catch-all] should pass params in getStaticProps during client navigation (multi interpolated)
● Dynamic Routing › dev mode › [nested ssg: catch-all] should pass params in getStaticProps during client navigation (single)
● Dynamic Routing › dev mode › [nested ssg: catch-all] should pass params in getStaticProps during client navigation (multi)
● Dynamic Routing › dev mode › should update dynamic values on mount
● Dynamic Routing › dev mode › should update with a hash in the URL
● Dynamic Routing › dev mode › should scroll to a hash on mount
● Dynamic Routing › dev mode › should scroll to a hash on client-side navigation
● Dynamic Routing › dev mode › should respond with bad request with invalid encoding
● Dynamic Routing › dev mode › should preload buildManifest for auto-export dynamic pages
● Dynamic Routing › dev mode › should resolve dynamic route href for page added later
● Dynamic Routing › dev mode › should show error when interpolating fails for href
● Dynamic Routing › dev mode › should work with HMR correctly
● Dynamic Routing › production mode › should output a routes-manifest correctly
● Dynamic Routing › serverless mode › should output a routes-manifest correctly
test/acceptance/ReactRefreshLogBox.dev.test.js
Expand output● css syntax errors
● scss syntax errors
test/integration/css-modules/test/index.test.js
Expand output● Has CSS Module in computed styles in Development › should have CSS for page
● Can hot reload CSS Module without losing state › should update CSS color without remounting
test/integration/scss-modules/test/index.test.js
Expand output● Has CSS Module in computed styles in Development › should have CSS for page
● Can hot reload CSS Module without losing state › should update CSS color without remounting
test/integration/scss/test/index.test.js
Expand output● SCSS Support › Can hot reload CSS without losing state › should update CSS color without remounting
● SCSS Support › Has CSS in computed styles in Development › should have CSS for page
● SCSS Support › Ordering with styled-jsx (dev) › should have the correct color (css ordering)
● Test suite failed to run
● Test suite failed to run
● Test suite failed to run
test/integration/css/test/index.test.js
Expand output● CSS Support › React Lifecyce Order (dev) › should have the correct color on mount after navigation
● CSS Support › Can hot reload CSS without losing state › should update CSS color without remounting
● CSS Support › Has CSS in computed styles in Development › should have CSS for page
● CSS Support › Ordering with styled-jsx (dev) › should have the correct color (css ordering)
● CSS Support › Ordering with Global CSS and Modules (dev) › should not execute scripts in any order
● CSS Support › Ordering with Global CSS and Modules (dev) › should have the correct color (css ordering)
● CSS Support › Ordering with Global CSS and Modules (dev) › should have the correct color (css ordering) during hot reloads
● CSS Support › CSS Modules Composes Ordering › Development Mode › should have correct color on index page (on load)
● CSS Support › CSS Modules Composes Ordering › Development Mode › should have correct color on index page (on hover)
● CSS Support › CSS Modules Composes Ordering › Development Mode › should have correct color on index page (on nav from index)
● CSS Support › CSS Modules Composes Ordering › Development Mode › should have correct color on index page (on nav from other)
● CSS Support › Basic CSS Modules Ordering › Development Mode › should have correct color on index page (on load)
● CSS Support › Basic CSS Modules Ordering › Development Mode › should have correct color on index page (on hover)
● CSS Support › Basic CSS Modules Ordering › Development Mode › should have correct color on index page (on nav)
● Test suite failed to run
● Test suite failed to run
● Test suite failed to run
● Test suite failed to run
|
This PR compiles `style-loader` to resolve a peer dep warning. --- Closes #21359
WIP to test if the style-loader cycles bug is due to externalization.