Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix webpack 5 enabling for tests #21436

Merged
merged 4 commits into from
Jan 22, 2021
Merged

ci: fix webpack 5 enabling for tests #21436

merged 4 commits into from
Jan 22, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 22, 2021 •
edited
Loading

This PR correctly enables webpack 5 so that tests are actually ran.

Fixes #21448

This also disables the test for worker-loader, which is only meant for webpack 4.

Webpack 5 has native support for new Worker:
https://webpack.js.org/blog/2020-12-08-roadmap-2021/#more-first-class-citizen

@ijjk
Copy link
Member

ijjk commented Jan 22, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
buildDuration 8.8s 8.8s -49ms
nodeModulesSize 73.3 MB 73.3 MB -194 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.754 1.752 0
/ avg req/sec 1425.34 1426.58 +1.24
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.143 1.097 -0.05
/error-in-render avg req/sec 2187 2278.87 +91.87
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
buildDuration 10.7s 10.3s -476ms
nodeModulesSize 73.3 MB 73.3 MB -194 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
buildDuration 10.4s 10.5s ⚠️ +96ms
nodeModulesSize 73.3 MB 73.3 MB -194 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.709 1.693 -0.02
/ avg req/sec 1462.95 1476.76 +13.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.079 1.074 0
/error-in-render avg req/sec 2316.85 2327.6 +10.75
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
597-168f5a87..2380.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
index.html gzip 587 B 587 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "kHZCT3cEOxkPoVHBTwo1l",
+        "buildId": "FNV-aTI_zBn34ISh1CZwL",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/kHZCT3cEOxkPoVHBTwo1l/_buildManifest.js"
+      src="/_next/static/FNV-aTI_zBn34ISh1CZwL/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/kHZCT3cEOxkPoVHBTwo1l/_ssgManifest.js"
+      src="/_next/static/FNV-aTI_zBn34ISh1CZwL/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "kHZCT3cEOxkPoVHBTwo1l",
+        "buildId": "FNV-aTI_zBn34ISh1CZwL",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/kHZCT3cEOxkPoVHBTwo1l/_buildManifest.js"
+      src="/_next/static/FNV-aTI_zBn34ISh1CZwL/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/kHZCT3cEOxkPoVHBTwo1l/_ssgManifest.js"
+      src="/_next/static/FNV-aTI_zBn34ISh1CZwL/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "kHZCT3cEOxkPoVHBTwo1l",
+        "buildId": "FNV-aTI_zBn34ISh1CZwL",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/kHZCT3cEOxkPoVHBTwo1l/_buildManifest.js"
+      src="/_next/static/FNV-aTI_zBn34ISh1CZwL/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/kHZCT3cEOxkPoVHBTwo1l/_ssgManifest.js"
+      src="/_next/static/FNV-aTI_zBn34ISh1CZwL/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: f521dfd

@ijjk
Copy link
Member

ijjk commented Jan 22, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
buildDuration 10.2s 10.5s ⚠️ +241ms
nodeModulesSize 73.3 MB 73.3 MB -194 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.002 1.966 -0.04
/ avg req/sec 1248.55 1271.91 +23.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.239 1.339 ⚠️ +0.1
/error-in-render avg req/sec 2017.03 1866.99 ⚠️ -150.04
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
buildDuration 11.4s 11.7s ⚠️ +241ms
nodeModulesSize 73.3 MB 73.3 MB -194 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
buildDuration 11.7s 11.4s -300ms
nodeModulesSize 73.3 MB 73.3 MB -194 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.853 1.786 -0.07
/ avg req/sec 1349.49 1400 +50.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.208 1.222 ⚠️ +0.01
/error-in-render avg req/sec 2069.44 2046.55 ⚠️ -22.89
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
597-168f5a87..2380.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
index.html gzip 588 B 588 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 583 B 583 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "tK2MBbkk_GrSn_UbxCUPA",
+        "buildId": "55GE6e6d-k3BbVVdOpYMT",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/tK2MBbkk_GrSn_UbxCUPA/_buildManifest.js"
+      src="/_next/static/55GE6e6d-k3BbVVdOpYMT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/tK2MBbkk_GrSn_UbxCUPA/_ssgManifest.js"
+      src="/_next/static/55GE6e6d-k3BbVVdOpYMT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "tK2MBbkk_GrSn_UbxCUPA",
+        "buildId": "55GE6e6d-k3BbVVdOpYMT",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/tK2MBbkk_GrSn_UbxCUPA/_buildManifest.js"
+      src="/_next/static/55GE6e6d-k3BbVVdOpYMT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/tK2MBbkk_GrSn_UbxCUPA/_ssgManifest.js"
+      src="/_next/static/55GE6e6d-k3BbVVdOpYMT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "tK2MBbkk_GrSn_UbxCUPA",
+        "buildId": "55GE6e6d-k3BbVVdOpYMT",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/tK2MBbkk_GrSn_UbxCUPA/_buildManifest.js"
+      src="/_next/static/55GE6e6d-k3BbVVdOpYMT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/tK2MBbkk_GrSn_UbxCUPA/_ssgManifest.js"
+      src="/_next/static/55GE6e6d-k3BbVVdOpYMT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 6412b1f

@Timer Timer marked this pull request as ready for review January 22, 2021 16:53
@ijjk
Copy link
Member

ijjk commented Jan 22, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
buildDuration 8.9s 8.7s -160ms
nodeModulesSize 73.3 MB 73.3 MB -194 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.748 1.754 ⚠️ +0.01
/ avg req/sec 1430.21 1425.24 ⚠️ -4.97
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.12 1.123 0
/error-in-render avg req/sec 2233.12 2225.48 ⚠️ -7.64
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
buildDuration 10.4s 10.5s ⚠️ +43ms
nodeModulesSize 73.3 MB 73.3 MB -194 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
buildDuration 11.5s 10.7s -820ms
nodeModulesSize 73.3 MB 73.3 MB -194 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.729 1.739 ⚠️ +0.01
/ avg req/sec 1445.79 1437.84 ⚠️ -7.95
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.08 1.093 ⚠️ +0.01
/error-in-render avg req/sec 2314.28 2287.76 ⚠️ -26.52
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
597-168f5a87..2380.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack5 Change
index.html gzip 588 B 588 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 583 B 583 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "qDC2INpFWMltufJOcBIVk",
+        "buildId": "1wNm1bm1TgCp2RbI861iy",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/qDC2INpFWMltufJOcBIVk/_buildManifest.js"
+      src="/_next/static/1wNm1bm1TgCp2RbI861iy/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/qDC2INpFWMltufJOcBIVk/_ssgManifest.js"
+      src="/_next/static/1wNm1bm1TgCp2RbI861iy/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "qDC2INpFWMltufJOcBIVk",
+        "buildId": "1wNm1bm1TgCp2RbI861iy",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/qDC2INpFWMltufJOcBIVk/_buildManifest.js"
+      src="/_next/static/1wNm1bm1TgCp2RbI861iy/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/qDC2INpFWMltufJOcBIVk/_ssgManifest.js"
+      src="/_next/static/1wNm1bm1TgCp2RbI861iy/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "qDC2INpFWMltufJOcBIVk",
+        "buildId": "1wNm1bm1TgCp2RbI861iy",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/qDC2INpFWMltufJOcBIVk/_buildManifest.js"
+      src="/_next/static/1wNm1bm1TgCp2RbI861iy/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/qDC2INpFWMltufJOcBIVk/_ssgManifest.js"
+      src="/_next/static/1wNm1bm1TgCp2RbI861iy/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 1aae779

@ijjk ijjk merged commit 74b6389 into vercel:canary Jan 22, 2021
@ijjk ijjk deleted the hotfix/webpack5 branch January 22, 2021 17:20
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix webpack 5 CI tests
2 participants
@Timer @ijjk