Experimental feature changes (for CSS) #21462

janicklas-ralph · 2021-01-23T05:40:24Z

Fix bug for serverless for an experimental feature that I'm trying out. Also added tests for the same

… into css-optimization

ijjk · 2021-01-23T05:50:27Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
buildDuration	9.5s	9.4s	-154ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +47 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.008	1.921	-0.09
/ avg req/sec	1244.78	1301.27	+56.49
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.18	1.253	⚠️ +0.07
/error-in-render avg req/sec	2119.01	1994.61	⚠️ -124.4

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
buildDuration	11.4s	11.3s	-112ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +47 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
buildDuration	11.5s	11.6s	⚠️ +146ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +47 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.91	1.869	-0.04
/ avg req/sec	1308.91	1337.34	+28.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.179	1.164	-0.02
/error-in-render avg req/sec	2119.74	2147.59	+27.85

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "E8vIn9U_TBl3lSX7sWJAn",
+        "buildId": "oLqPc2fYZ3Ct7XGrMc4pV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/E8vIn9U_TBl3lSX7sWJAn/_buildManifest.js"
+      src="/_next/static/oLqPc2fYZ3Ct7XGrMc4pV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/E8vIn9U_TBl3lSX7sWJAn/_ssgManifest.js"
+      src="/_next/static/oLqPc2fYZ3Ct7XGrMc4pV/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "E8vIn9U_TBl3lSX7sWJAn",
+        "buildId": "oLqPc2fYZ3Ct7XGrMc4pV",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/E8vIn9U_TBl3lSX7sWJAn/_buildManifest.js"
+      src="/_next/static/oLqPc2fYZ3Ct7XGrMc4pV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/E8vIn9U_TBl3lSX7sWJAn/_ssgManifest.js"
+      src="/_next/static/oLqPc2fYZ3Ct7XGrMc4pV/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "E8vIn9U_TBl3lSX7sWJAn",
+        "buildId": "oLqPc2fYZ3Ct7XGrMc4pV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/E8vIn9U_TBl3lSX7sWJAn/_buildManifest.js"
+      src="/_next/static/oLqPc2fYZ3Ct7XGrMc4pV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/E8vIn9U_TBl3lSX7sWJAn/_ssgManifest.js"
+      src="/_next/static/oLqPc2fYZ3Ct7XGrMc4pV/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 03ca0c2

ijjk · 2021-01-24T13:38:48Z

Failing test suites

Commit: 6882f4e

test/integration/dist-dir/test/index.test.js

distDir > should handle null/undefined distDir

Expand output

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 88

  63 |     await fs.writeFile(nextConfig, origNextConfig)
  64 | 
> 65 |     expect(stderr.length).toBe(0)
     |                           ^
  66 |   })
  67 | })
  68 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:65:27)

test/integration/cli/test/index.test.js

CLI Usage > build > should warn when unknown argument provided

Expand output

● CLI Usage › build › should warn when unknown argument provided

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 2

+ Browserslist: caniuse-lite is outdated. Please run:
+ npx browserslist@latest --update-db
  Unknown or unexpected option: --random
  ↵

  79 |         stderr: true,
  80 |       })
> 81 |       expect(stderr).toEqual('Unknown or unexpected option: --random\n')
     |                      ^
  82 |     })
  83 |     test('should not throw UnhandledPromiseRejectionWarning', async () => {
  84 |       const { stderr } = await runNextCommand(['build', '--random'], {

  at Object.<anonymous> (integration/cli/test/index.test.js:81:22)

ijjk · 2021-01-24T13:41:08Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
buildDuration	10.1s	10.1s	⚠️ +31ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +47 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.988	2.024	⚠️ +0.04
/ avg req/sec	1257.34	1234.89	⚠️ -22.45
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.282	1.284	0
/error-in-render avg req/sec	1949.8	1947.65	⚠️ -2.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
buildDuration	12.1s	12.1s	⚠️ +57ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +47 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
buildDuration	12.9s	12.4s	-457ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +47 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.029	2.021	-0.01
/ avg req/sec	1232.4	1237.06	+4.66
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.247	1.238	-0.01
/error-in-render avg req/sec	2004.34	2018.86	+14.52

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "qUcpk7E3oUv_QRFbjzDo7",
+        "buildId": "uesvr0Sb50MAVYK4Z-KpQ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/qUcpk7E3oUv_QRFbjzDo7/_buildManifest.js"
+      src="/_next/static/uesvr0Sb50MAVYK4Z-KpQ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/qUcpk7E3oUv_QRFbjzDo7/_ssgManifest.js"
+      src="/_next/static/uesvr0Sb50MAVYK4Z-KpQ/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "qUcpk7E3oUv_QRFbjzDo7",
+        "buildId": "uesvr0Sb50MAVYK4Z-KpQ",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/qUcpk7E3oUv_QRFbjzDo7/_buildManifest.js"
+      src="/_next/static/uesvr0Sb50MAVYK4Z-KpQ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/qUcpk7E3oUv_QRFbjzDo7/_ssgManifest.js"
+      src="/_next/static/uesvr0Sb50MAVYK4Z-KpQ/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "qUcpk7E3oUv_QRFbjzDo7",
+        "buildId": "uesvr0Sb50MAVYK4Z-KpQ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/qUcpk7E3oUv_QRFbjzDo7/_buildManifest.js"
+      src="/_next/static/uesvr0Sb50MAVYK4Z-KpQ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/qUcpk7E3oUv_QRFbjzDo7/_ssgManifest.js"
+      src="/_next/static/uesvr0Sb50MAVYK4Z-KpQ/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 6882f4e

ijjk · 2021-01-25T17:22:16Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
buildDuration	10.4s	10.2s	-163ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +47 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.006	2.076	⚠️ +0.07
/ avg req/sec	1246.16	1204.49	⚠️ -41.67
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.306	1.282	-0.02
/error-in-render avg req/sec	1914.07	1950.4	+36.33

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
buildDuration	12.1s	12.2s	⚠️ +129ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +47 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
buildDuration	12.6s	12.7s	⚠️ +181ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +47 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.005	1.967	-0.04
/ avg req/sec	1246.58	1270.68	+24.1
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.283	1.251	-0.03
/error-in-render avg req/sec	1949.18	1998	+48.82

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js css-optimization	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "35myQ8LkIGFPF3NA5QvtE",
+        "buildId": "wiDttV0Zt4sLvqtvTdtcl",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/35myQ8LkIGFPF3NA5QvtE/_buildManifest.js"
+      src="/_next/static/wiDttV0Zt4sLvqtvTdtcl/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/35myQ8LkIGFPF3NA5QvtE/_ssgManifest.js"
+      src="/_next/static/wiDttV0Zt4sLvqtvTdtcl/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "35myQ8LkIGFPF3NA5QvtE",
+        "buildId": "wiDttV0Zt4sLvqtvTdtcl",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/35myQ8LkIGFPF3NA5QvtE/_buildManifest.js"
+      src="/_next/static/wiDttV0Zt4sLvqtvTdtcl/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/35myQ8LkIGFPF3NA5QvtE/_ssgManifest.js"
+      src="/_next/static/wiDttV0Zt4sLvqtvTdtcl/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "35myQ8LkIGFPF3NA5QvtE",
+        "buildId": "wiDttV0Zt4sLvqtvTdtcl",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/35myQ8LkIGFPF3NA5QvtE/_buildManifest.js"
+      src="/_next/static/wiDttV0Zt4sLvqtvTdtcl/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/35myQ8LkIGFPF3NA5QvtE/_ssgManifest.js"
+      src="/_next/static/wiDttV0Zt4sLvqtvTdtcl/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 08082b5

adriandmitroca · 2021-01-25T19:23:43Z

What does this fix?

janicklas-ralph · 2021-01-26T20:09:05Z

This fix is for an experimental feature I'm looking into.

janicklas-ralph added 30 commits April 4, 2020 14:36

Updating native-url version

edabb95

Bump version

c147099

Merge branch 'canary' of github.com:zeit/next.js into canary

63b04ca

Merge branch 'canary' of github.com:zeit/next.js into canary

df52e5e

Merge branch 'canary' of github.com:zeit/next.js into canary

1baaf87

Merge branch 'canary' of github.com:zeit/next.js into canary

68bff2a

Setup CSS optimization. Experimental inlining critical css

0aa63a4

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

f812418

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

42686d4

Critical CSS setup

90f475d

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

6382ff2

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

56ff05e

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

b728cba

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

2074b67

Enabling config override for critters. Updating critters

0361ac5

Update critical css position

205cf62

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

618ef3f

Fix lint error

3387a7b

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

9942ff6

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

648765c

Update critters version 0.0.6 reduced the install size

fa95198

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

3d5c9b3

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

8a8662c

Removing critters as a dependency

95521ee

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

e327729

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

85214fb

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

527dca4

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

dbc456d

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

a367a6f

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

2063de9

janicklas-ralph added 12 commits November 19, 2020 10:56

Merge branch 'css-optimization' of github.com:janicklas-ralph/next.js…

bb55512

… into css-optimization

Fix failing test case

1aafd1a

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

65de0b5

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

995e1eb

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

1fe3de2

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

456b2fa

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

7b2006f

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

60fde8b

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

060cc55

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

ba6ef1a

Merge branch 'canary' of github.com:zeit/next.js into css-optimization

deb0f3d

Fix bug for serverless. Adding tests

03ca0c2

janicklas-ralph requested review from ijjk, lfades, Timer and timneutkens as code owners January 23, 2021 05:40

ijjk added the type: next label Jan 23, 2021

timneutkens approved these changes Jan 24, 2021

View reviewed changes

Merge branch 'canary' into css-optimization

6882f4e

Merge branch 'canary' into css-optimization

08082b5

Timer merged commit cf95146 into vercel:canary Jan 25, 2021

janicklas-ralph changed the title ~~Critical css fix~~ Experimental feature changes for CSS Jan 26, 2021

janicklas-ralph changed the title ~~Experimental feature changes for CSS~~ Experimental feature changes (for CSS) Jan 26, 2021

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experimental feature changes (for CSS) #21462

Experimental feature changes (for CSS) #21462

janicklas-ralph commented Jan 23, 2021 •

edited

Loading

ijjk commented Jan 23, 2021

Diffs

ijjk commented Jan 24, 2021 •

edited

Loading

ijjk commented Jan 24, 2021

Diffs

ijjk commented Jan 25, 2021

Diffs

adriandmitroca commented Jan 25, 2021

janicklas-ralph commented Jan 26, 2021

Experimental feature changes (for CSS) #21462

Experimental feature changes (for CSS) #21462

Conversation

janicklas-ralph commented Jan 23, 2021 • edited Loading

ijjk commented Jan 23, 2021

Stats from current PR

Diffs

ijjk commented Jan 24, 2021 • edited Loading

Failing test suites

ijjk commented Jan 24, 2021

Stats from current PR

Diffs

ijjk commented Jan 25, 2021

Stats from current PR

Diffs

adriandmitroca commented Jan 25, 2021

janicklas-ralph commented Jan 26, 2021

janicklas-ralph commented Jan 23, 2021 •

edited

Loading

ijjk commented Jan 24, 2021 •

edited

Loading