Allow smaller sizes in srcset for image with fill layout and sizes prop #21670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and sizes property
atcastle
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 9.4s | 10.3s | |
| nodeModulesSize | 75 MB | 75 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.037 | 2.177 | |
| / avg req/sec | 1227.58 | 1148.57 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.384 | 1.416 | |
| /error-in-render avg req/sec | 1806.59 | 1766.02 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 613 B | 613 B | ✓ |
| link.html gzip | 618 B | 618 B | ✓ |
| withRouter.html gzip | 606 B | 606 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 12.4s | 11.1s | -1.4s |
| nodeModulesSize | 75 MB | 75 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Serverless bundles
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _error.js | 1 MB | 1 MB | ✓ |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 1 MB | 1 MB | ✓ |
| link.js | 1.06 MB | 1.06 MB | ✓ |
| routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
| withRouter.js | 1.05 MB | 1.05 MB | ✓ |
| Overall change | 5.19 MB | 5.19 MB | ✓ |
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 13.7s | 13.8s | |
| nodeModulesSize | 75 MB | 75 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.297 | 2.279 | -0.02 |
| / avg req/sec | 1088.41 | 1096.78 | +8.37 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.595 | 1.609 | |
| /error-in-render avg req/sec | 1567.19 | 1554.04 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 597-7c719119..27b6.js gzip | 13 kB | 13 kB | ✓ |
| framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 6.57 kB | 6.57 kB | ✓ |
| webpack-HASH.js gzip | 954 B | 954 B | ✓ |
| Overall change | 59.8 kB | 59.8 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-6e0a903..b885.js gzip | 1.26 kB | 1.26 kB | ✓ |
| _error-7a100..a392.js gzip | 3.38 kB | 3.38 kB | ✓ |
| hooks-f7e199..11b9.js gzip | 904 B | 904 B | ✓ |
| index-3dc22c..ffbb.js gzip | 232 B | 232 B | ✓ |
| link-c010d28..b60a.js gzip | 1.63 kB | 1.63 kB | ✓ |
| routerDirect..323a.js gzip | 308 B | 308 B | ✓ |
| withRouter-a..2ef8.js gzip | 304 B | 304 B | ✓ |
| Overall change | 8.02 kB | 8.02 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 299 B | 299 B | ✓ |
| Overall change | 299 B | 299 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 586 B | 586 B | ✓ |
| link.html gzip | 592 B | 592 B | ✓ |
| withRouter.html gzip | 579 B | 579 B | ✓ |
| Overall change | 1.76 kB | 1.76 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "aWuT0pFDPa_dOuHuUA0xi",
+ "buildId": "8bt4vh1EfQz65f9Fmc_IZ",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/aWuT0pFDPa_dOuHuUA0xi/_buildManifest.js"
+ src="/_next/static/8bt4vh1EfQz65f9Fmc_IZ/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/aWuT0pFDPa_dOuHuUA0xi/_ssgManifest.js"
+ src="/_next/static/8bt4vh1EfQz65f9Fmc_IZ/_ssgManifest.js"
async=""
></script>
</body>Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "aWuT0pFDPa_dOuHuUA0xi",
+ "buildId": "8bt4vh1EfQz65f9Fmc_IZ",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/aWuT0pFDPa_dOuHuUA0xi/_buildManifest.js"
+ src="/_next/static/8bt4vh1EfQz65f9Fmc_IZ/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/aWuT0pFDPa_dOuHuUA0xi/_ssgManifest.js"
+ src="/_next/static/8bt4vh1EfQz65f9Fmc_IZ/_ssgManifest.js"
async=""
></script>
</body>Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "aWuT0pFDPa_dOuHuUA0xi",
+ "buildId": "8bt4vh1EfQz65f9Fmc_IZ",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/aWuT0pFDPa_dOuHuUA0xi/_buildManifest.js"
+ src="/_next/static/8bt4vh1EfQz65f9Fmc_IZ/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/aWuT0pFDPa_dOuHuUA0xi/_ssgManifest.js"
+ src="/_next/static/8bt4vh1EfQz65f9Fmc_IZ/_ssgManifest.js"
async=""
></script>
</body>
Failing test suitesCommit: 130c8fb test/integration/image-component/base-path/test/index.test.js
Expand output● Image Component basePath Tests › dev mode › should work with sizes and automatically use layout-responsive ● Image Component basePath Tests › server mode › should work with sizes and automatically use layout-responsive ● Image Component basePath Tests › serverless mode › should work with sizes and automatically use layout-responsive |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 10.4s | 10.3s | -106ms |
| nodeModulesSize | 75 MB | 75 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.035 | 2.14 | |
| / avg req/sec | 1228.55 | 1168.44 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.355 | 1.337 | -0.02 |
| /error-in-render avg req/sec | 1844.94 | 1870.45 | +25.51 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 613 B | 613 B | ✓ |
| link.html gzip | 618 B | 618 B | ✓ |
| withRouter.html gzip | 606 B | 606 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 12.2s | 12.2s | |
| nodeModulesSize | 75 MB | 75 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Serverless bundles
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _error.js | 1 MB | 1 MB | ✓ |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 1 MB | 1 MB | ✓ |
| link.js | 1.06 MB | 1.06 MB | ✓ |
| routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
| withRouter.js | 1.05 MB | 1.05 MB | ✓ |
| Overall change | 5.19 MB | 5.19 MB | ✓ |
Webpack 5 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 12.4s | 12.7s | |
| nodeModulesSize | 75 MB | 75 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.124 | 2.092 | -0.03 |
| / avg req/sec | 1177.07 | 1194.88 | +17.81 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.314 | 1.295 | -0.02 |
| /error-in-render avg req/sec | 1903.22 | 1930.31 | +27.09 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 597-7c719119..27b6.js gzip | 13 kB | 13 kB | ✓ |
| framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 6.57 kB | 6.57 kB | ✓ |
| webpack-HASH.js gzip | 954 B | 954 B | ✓ |
| Overall change | 59.8 kB | 59.8 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-6e0a903..b885.js gzip | 1.26 kB | 1.26 kB | ✓ |
| _error-7a100..a392.js gzip | 3.38 kB | 3.38 kB | ✓ |
| hooks-f7e199..11b9.js gzip | 904 B | 904 B | ✓ |
| index-3dc22c..ffbb.js gzip | 232 B | 232 B | ✓ |
| link-c010d28..b60a.js gzip | 1.63 kB | 1.63 kB | ✓ |
| routerDirect..323a.js gzip | 308 B | 308 B | ✓ |
| withRouter-a..2ef8.js gzip | 304 B | 304 B | ✓ |
| Overall change | 8.02 kB | 8.02 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 299 B | 299 B | ✓ |
| Overall change | 299 B | 299 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 586 B | 586 B | ✓ |
| link.html gzip | 592 B | 592 B | ✓ |
| withRouter.html gzip | 579 B | 579 B | ✓ |
| Overall change | 1.76 kB | 1.76 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "nhS0Y5J47fvF5cU5ozyPb",
+ "buildId": "eJDTayRHmeUzAzSjmy2J1",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/nhS0Y5J47fvF5cU5ozyPb/_buildManifest.js"
+ src="/_next/static/eJDTayRHmeUzAzSjmy2J1/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/nhS0Y5J47fvF5cU5ozyPb/_ssgManifest.js"
+ src="/_next/static/eJDTayRHmeUzAzSjmy2J1/_ssgManifest.js"
async=""
></script>
</body>Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "nhS0Y5J47fvF5cU5ozyPb",
+ "buildId": "eJDTayRHmeUzAzSjmy2J1",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/nhS0Y5J47fvF5cU5ozyPb/_buildManifest.js"
+ src="/_next/static/eJDTayRHmeUzAzSjmy2J1/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/nhS0Y5J47fvF5cU5ozyPb/_ssgManifest.js"
+ src="/_next/static/eJDTayRHmeUzAzSjmy2J1/_ssgManifest.js"
async=""
></script>
</body>Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "nhS0Y5J47fvF5cU5ozyPb",
+ "buildId": "eJDTayRHmeUzAzSjmy2J1",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/nhS0Y5J47fvF5cU5ozyPb/_buildManifest.js"
+ src="/_next/static/eJDTayRHmeUzAzSjmy2J1/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/nhS0Y5J47fvF5cU5ozyPb/_ssgManifest.js"
+ src="/_next/static/eJDTayRHmeUzAzSjmy2J1/_ssgManifest.js"
async=""
></script>
</body>
Failing test suitesCommit: 3317dbb test/integration/image-component/default/test/index.test.js
Expand output● Image Component Tests › dev mode › should work with layout-fill to fill the parent and stretch with viewport ● Image Component Tests › dev mode › should work with sizes and automatically use layout-responsive ● Image Component Tests › server mode › should work with layout-fill to fill the parent and stretch with viewport ● Image Component Tests › server mode › should work with sizes and automatically use layout-responsive ● Image Component Tests › serverless mode › should work with layout-fill to fill the parent and stretch with viewport ● Image Component Tests › serverless mode › should work with sizes and automatically use layout-responsive test/integration/image-component/base-path/test/index.test.js
Expand output● Image Component basePath Tests › dev mode › should work with sizes and automatically use layout-responsive ● Image Component basePath Tests › server mode › should work with sizes and automatically use layout-responsive ● Image Component basePath Tests › serverless mode › should work with sizes and automatically use layout-responsive |
styfle
reviewed
Jan 29, 2021
…tweak integration tests
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 8.7s | 8.4s | -280ms |
| nodeModulesSize | 75 MB | 75 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.677 | 1.669 | -0.01 |
| / avg req/sec | 1490.94 | 1498.17 | +7.23 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.05 | 1.055 | 0 |
| /error-in-render avg req/sec | 2381.18 | 2368.64 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 613 B | 613 B | ✓ |
| link.html gzip | 618 B | 618 B | ✓ |
| withRouter.html gzip | 606 B | 606 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 10.3s | 10.6s | |
| nodeModulesSize | 75 MB | 75 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Serverless bundles
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _error.js | 1 MB | 1 MB | ✓ |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 1 MB | 1 MB | ✓ |
| link.js | 1.06 MB | 1.06 MB | ✓ |
| routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
| withRouter.js | 1.05 MB | 1.05 MB | ✓ |
| Overall change | 5.19 MB | 5.19 MB | ✓ |
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 10s | 10.3s | |
| nodeModulesSize | 75 MB | 75 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.674 | 1.821 | |
| / avg req/sec | 1493.59 | 1372.77 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.044 | 1.178 | |
| /error-in-render avg req/sec | 2395.58 | 2122.5 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 597-7c719119..27b6.js gzip | 13 kB | 13 kB | ✓ |
| framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 6.57 kB | 6.57 kB | ✓ |
| webpack-HASH.js gzip | 954 B | 954 B | ✓ |
| Overall change | 59.8 kB | 59.8 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-6e0a903..b885.js gzip | 1.26 kB | 1.26 kB | ✓ |
| _error-7a100..a392.js gzip | 3.38 kB | 3.38 kB | ✓ |
| hooks-f7e199..11b9.js gzip | 904 B | 904 B | ✓ |
| index-3dc22c..ffbb.js gzip | 232 B | 232 B | ✓ |
| link-c010d28..b60a.js gzip | 1.63 kB | 1.63 kB | ✓ |
| routerDirect..323a.js gzip | 308 B | 308 B | ✓ |
| withRouter-a..2ef8.js gzip | 304 B | 304 B | ✓ |
| Overall change | 8.02 kB | 8.02 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 299 B | 299 B | ✓ |
| Overall change | 299 B | 299 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 586 B | 586 B | ✓ |
| link.html gzip | 592 B | 592 B | ✓ |
| withRouter.html gzip | 579 B | 579 B | ✓ |
| Overall change | 1.76 kB | 1.76 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "u8WZP59s0EQkK6gQZqxMC",
+ "buildId": "H24I0fqOJLEBnN8SG2JLH",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/u8WZP59s0EQkK6gQZqxMC/_buildManifest.js"
+ src="/_next/static/H24I0fqOJLEBnN8SG2JLH/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/u8WZP59s0EQkK6gQZqxMC/_ssgManifest.js"
+ src="/_next/static/H24I0fqOJLEBnN8SG2JLH/_ssgManifest.js"
async=""
></script>
</body>Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "u8WZP59s0EQkK6gQZqxMC",
+ "buildId": "H24I0fqOJLEBnN8SG2JLH",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/u8WZP59s0EQkK6gQZqxMC/_buildManifest.js"
+ src="/_next/static/H24I0fqOJLEBnN8SG2JLH/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/u8WZP59s0EQkK6gQZqxMC/_ssgManifest.js"
+ src="/_next/static/H24I0fqOJLEBnN8SG2JLH/_ssgManifest.js"
async=""
></script>
</body>Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "u8WZP59s0EQkK6gQZqxMC",
+ "buildId": "H24I0fqOJLEBnN8SG2JLH",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/u8WZP59s0EQkK6gQZqxMC/_buildManifest.js"
+ src="/_next/static/H24I0fqOJLEBnN8SG2JLH/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/u8WZP59s0EQkK6gQZqxMC/_ssgManifest.js"
+ src="/_next/static/H24I0fqOJLEBnN8SG2JLH/_ssgManifest.js"
async=""
></script>
</body>
styfle
reviewed
Jan 29, 2021
Failing test suitesCommit: 562f7f4 test/integration/image-component/default/test/index.test.js
Expand output● Image Component Tests › dev mode › should work with layout-fill to fill the parent and stretch with viewport ● Image Component Tests › server mode › should work with layout-fill to fill the parent and stretch with viewport ● Image Component Tests › serverless mode › should work with layout-fill to fill the parent and stretch with viewport |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 8.8s | 8.8s | -47ms |
| nodeModulesSize | 75 MB | 75 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.625 | 1.734 | |
| / avg req/sec | 1538.15 | 1441.48 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.087 | 1.099 | |
| /error-in-render avg req/sec | 2300.34 | 2273.92 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 613 B | 613 B | ✓ |
| link.html gzip | 618 B | 618 B | ✓ |
| withRouter.html gzip | 606 B | 606 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 9.9s | 10.1s | |
| nodeModulesSize | 75 MB | 75 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Serverless bundles
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _error.js | 1 MB | 1 MB | ✓ |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 1 MB | 1 MB | ✓ |
| link.js | 1.06 MB | 1.06 MB | ✓ |
| routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
| withRouter.js | 1.05 MB | 1.05 MB | ✓ |
| Overall change | 5.19 MB | 5.19 MB | ✓ |
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 9.9s | 10.4s | |
| nodeModulesSize | 75 MB | 75 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.722 | 1.735 | |
| / avg req/sec | 1451.6 | 1440.69 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.071 | 1.097 | |
| /error-in-render avg req/sec | 2334.99 | 2278.98 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 597-7c719119..27b6.js gzip | 13 kB | 13 kB | ✓ |
| framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 6.57 kB | 6.57 kB | ✓ |
| webpack-HASH.js gzip | 954 B | 954 B | ✓ |
| Overall change | 59.8 kB | 59.8 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-6e0a903..b885.js gzip | 1.26 kB | 1.26 kB | ✓ |
| _error-7a100..a392.js gzip | 3.38 kB | 3.38 kB | ✓ |
| hooks-f7e199..11b9.js gzip | 904 B | 904 B | ✓ |
| index-3dc22c..ffbb.js gzip | 232 B | 232 B | ✓ |
| link-c010d28..b60a.js gzip | 1.63 kB | 1.63 kB | ✓ |
| routerDirect..323a.js gzip | 308 B | 308 B | ✓ |
| withRouter-a..2ef8.js gzip | 304 B | 304 B | ✓ |
| Overall change | 8.02 kB | 8.02 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 299 B | 299 B | ✓ |
| Overall change | 299 B | 299 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 586 B | 586 B | ✓ |
| link.html gzip | 592 B | 592 B | ✓ |
| withRouter.html gzip | 579 B | 579 B | ✓ |
| Overall change | 1.76 kB | 1.76 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "jwgd-Qva14y_jv4mZpmUp",
+ "buildId": "T-L30kRAI2MYjiPbUMqfe",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/jwgd-Qva14y_jv4mZpmUp/_buildManifest.js"
+ src="/_next/static/T-L30kRAI2MYjiPbUMqfe/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/jwgd-Qva14y_jv4mZpmUp/_ssgManifest.js"
+ src="/_next/static/T-L30kRAI2MYjiPbUMqfe/_ssgManifest.js"
async=""
></script>
</body>Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "jwgd-Qva14y_jv4mZpmUp",
+ "buildId": "T-L30kRAI2MYjiPbUMqfe",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/jwgd-Qva14y_jv4mZpmUp/_buildManifest.js"
+ src="/_next/static/T-L30kRAI2MYjiPbUMqfe/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/jwgd-Qva14y_jv4mZpmUp/_ssgManifest.js"
+ src="/_next/static/T-L30kRAI2MYjiPbUMqfe/_ssgManifest.js"
async=""
></script>
</body>Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "jwgd-Qva14y_jv4mZpmUp",
+ "buildId": "T-L30kRAI2MYjiPbUMqfe",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/jwgd-Qva14y_jv4mZpmUp/_buildManifest.js"
+ src="/_next/static/T-L30kRAI2MYjiPbUMqfe/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/jwgd-Qva14y_jv4mZpmUp/_ssgManifest.js"
+ src="/_next/static/T-L30kRAI2MYjiPbUMqfe/_ssgManifest.js"
async=""
></script>
</body>
Failing test suitesCommit: 72320f0 test/integration/image-component/base-path/test/index.test.js
Expand output● Image Component basePath Tests › dev mode › should work with sizes and automatically use layout-responsive ● Image Component basePath Tests › server mode › should work with sizes and automatically use layout-responsive ● Image Component basePath Tests › serverless mode › should work with sizes and automatically use layout-responsive |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 10s | 9.7s | -244ms |
| nodeModulesSize | 42.7 MB | 42.7 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.789 | 1.808 | |
| / avg req/sec | 1397.77 | 1382.45 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.092 | 1.138 | |
| /error-in-render avg req/sec | 2288.43 | 2196.01 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..e7a0.js gzip | 13.4 kB | 13.4 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.65 kB | 6.65 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.7 kB | 59.7 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| amp-e3e9bc99..932c.js gzip | 536 B | 536 B | ✓ |
| hooks-5023ef..3670.js gzip | 888 B | 888 B | ✓ |
| index-3a2b03..c677.js gzip | 227 B | 227 B | ✓ |
| link-177412b..043e.js gzip | 1.67 kB | 1.67 kB | ✓ |
| routerDirect..1a66.js gzip | 303 B | 303 B | ✓ |
| withRouter-9..1b7d.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.66 kB | 8.66 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 347 B | 347 B | ✓ |
| Overall change | 347 B | 347 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 613 B | 613 B | ✓ |
| link.html gzip | 619 B | 619 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 11.6s | 11.6s | |
| nodeModulesSize | 42.7 MB | 42.7 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 677f882d2ed8..e7a0.js gzip | 13.4 kB | 13.4 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 6.65 kB | 6.65 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.7 kB | 59.7 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
| amp-e3e9bc99..932c.js gzip | 536 B | 536 B | ✓ |
| hooks-5023ef..3670.js gzip | 888 B | 888 B | ✓ |
| index-3a2b03..c677.js gzip | 227 B | 227 B | ✓ |
| link-177412b..043e.js gzip | 1.67 kB | 1.67 kB | ✓ |
| routerDirect..1a66.js gzip | 303 B | 303 B | ✓ |
| withRouter-9..1b7d.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.66 kB | 8.66 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 347 B | 347 B | ✓ |
| Overall change | 347 B | 347 B | ✓ |
Serverless bundles
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _error.js | 1.01 MB | 1.01 MB | ✓ |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| 500.html | 2.65 kB | 2.65 kB | ✓ |
| amp.amp.html | 10.4 kB | 10.4 kB | ✓ |
| amp.html | 1.86 kB | 1.86 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 1.01 MB | 1.01 MB | ✓ |
| link.js | 1.06 MB | 1.06 MB | ✓ |
| routerDirect.js | 1.06 MB | 1.06 MB | ✓ |
| withRouter.js | 1.06 MB | 1.06 MB | ✓ |
| Overall change | 5.21 MB | 5.21 MB | ✓ |
Webpack 5 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| buildDuration | 11.7s | 11.6s | -121ms |
| nodeModulesSize | 42.7 MB | 42.7 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.771 | 1.705 | -0.07 |
| / avg req/sec | 1411.91 | 1465.91 | +54 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.139 | 1.093 | -0.05 |
| /error-in-render avg req/sec | 2193.99 | 2287 | +93.01 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| 597-74632e79..1d47.js gzip | 13.3 kB | 13.3 kB | ✓ |
| framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 6.59 kB | 6.59 kB | ✓ |
| webpack-HASH.js gzip | 954 B | 954 B | ✓ |
| Overall change | 60.1 kB | 60.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _app-aedc815..1421.js gzip | 1.26 kB | 1.26 kB | ✓ |
| _error-71ec2..1a96.js gzip | 3.38 kB | 3.38 kB | ✓ |
| amp-33a09cb0..6745.js gzip | 536 B | 536 B | ✓ |
| hooks-4e968a..f870.js gzip | 902 B | 902 B | ✓ |
| index-5c6845..f75c.js gzip | 230 B | 230 B | ✓ |
| link-99f0c6c..b84a.js gzip | 1.65 kB | 1.65 kB | ✓ |
| routerDirect..bb56.js gzip | 306 B | 306 B | ✓ |
| withRouter-7..2133.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.57 kB | 8.57 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 326 B | 326 B | ✓ |
| Overall change | 326 B | 326 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js image-component-update-fill-sizing | Change | |
|---|---|---|---|
| index.html gzip | 587 B | 587 B | ✓ |
| link.html gzip | 594 B | 594 B | ✓ |
| withRouter.html gzip | 582 B | 582 B | ✓ |
| Overall change | 1.76 kB | 1.76 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "TpdomL4EgDh8FX6uRYfhU",
+ "buildId": "p8wB9OKUYcx_DKEkV5S0Y",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/TpdomL4EgDh8FX6uRYfhU/_buildManifest.js"
+ src="/_next/static/p8wB9OKUYcx_DKEkV5S0Y/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/TpdomL4EgDh8FX6uRYfhU/_ssgManifest.js"
+ src="/_next/static/p8wB9OKUYcx_DKEkV5S0Y/_ssgManifest.js"
async=""
></script>
</body>Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "TpdomL4EgDh8FX6uRYfhU",
+ "buildId": "p8wB9OKUYcx_DKEkV5S0Y",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/TpdomL4EgDh8FX6uRYfhU/_buildManifest.js"
+ src="/_next/static/p8wB9OKUYcx_DKEkV5S0Y/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/TpdomL4EgDh8FX6uRYfhU/_ssgManifest.js"
+ src="/_next/static/p8wB9OKUYcx_DKEkV5S0Y/_ssgManifest.js"
async=""
></script>
</body>Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "TpdomL4EgDh8FX6uRYfhU",
+ "buildId": "p8wB9OKUYcx_DKEkV5S0Y",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/TpdomL4EgDh8FX6uRYfhU/_buildManifest.js"
+ src="/_next/static/p8wB9OKUYcx_DKEkV5S0Y/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/TpdomL4EgDh8FX6uRYfhU/_ssgManifest.js"
+ src="/_next/static/p8wB9OKUYcx_DKEkV5S0Y/_ssgManifest.js"
async=""
></script>
</body>
Failing test suitesCommit: 3b03fc2 test/integration/image-component/base-path/test/index.test.js
Expand output● Image Component basePath Tests › dev mode › should work with sizes and automatically use layout-responsive ● Image Component basePath Tests › server mode › should work with sizes and automatically use layout-responsive ● Image Component basePath Tests › serverless mode › should work with sizes and automatically use layout-responsive |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
|
Does Next.js provide a polyfill for I have a suspicion that this change breaks support for quite a few browsers, e.g. Chrome < 73 (released in 2019, 2 years ago), Safari < 13 (12 last updated in 2019, 2 years ago). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the image component doesn't handle use of the
sizesproperty withlayout="fill"andlayout="responsive"very well for small viewports. It will never include sizes smaller than the smallest viewport (640px) in the srcset, so even if you specifysizes="30vw"in your image, you have to download the full-viewport-width image on small devices.This PR adds logic such that if you use
layout="fill"and include asizesproperty, the image component will include the full range of image sizes in thesrcset.It also includes an optimization where it finds the smallest
vwvalue in the sizes value and combines that with the smallest viewport width, and uses that as the floor of the srcset. It does this so it doesn't unnecessarily increase transfer size by including ALL sizes. This is still a conservative optimization--for 95% of cases, taking the largestvwsize would work, but I don't see a way to do that without breaking a few corner cases.The case of a sizes prop with
pxvalues is fixed but not optimized--though generally that case is less of a good fit for the fill or responsive layout anyway.