Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update router.md #21899

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Update router.md #21899

merged 2 commits into from
Mar 8, 2021

Conversation

melono6
Copy link
Contributor

@melono6 melono6 commented Feb 5, 2021

include scroll option documentation for router.push

include scroll option documentation for router.push
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot requested review from divmain and leerob as code owners March 8, 2021 13:47
@kodiakhq kodiakhq bot merged commit 81b0525 into vercel:canary Mar 8, 2021
@jesstelford
Copy link
Contributor

The option is already described on line 75 (2 lines above).

@melono6
Copy link
Contributor Author

melono6 commented Mar 9, 2021

seems it was added after I made the PR: 1c3ac0e#diff-129f17bae1a499f319a70b9e5821656cbe48f7b66363d653ab2bfa18e210bdce

@jesstelford
Copy link
Contributor

Oh wow, that's interesting! Is GitHub's UI just playing up then!?

Sorry for the false alarm

This was referenced Mar 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants