Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental script loader changes #22038
Experimental script loader changes #22038
Changes from all commits
edabb95
c147099
63b04ca
df52e5e
1baaf87
68bff2a
5f3c00a
38aa0af
3dc9ec4
0a5c068
aab70cd
623e444
f8a8a99
6dbceb9
bf72597
612a45d
8952a9d
77cfe9c
2ed5656
cea970b
09093e1
fb41fbb
6dc48ad
dab42f7
682083e
898b82f
35669c2
c6455c2
59e3252
71d79c5
b820597
18b98dc
215f527
6a39321
6e0a87e
125c600
81f0fe4
26721fa
a2b2234
6c75312
c4108c2
1e600e7
2d85777
53ea044
2acfb44
15a17b2
f11de5b
7c319d3
0d6bf44
570ac9b
07b1a52
70826e4
527cf2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the entire import of this file is supposed to be blocked or stubbed out in the webpack configuration. Seems odd to have this here.
What happened to the
next/experimental-script
block inwebpack-config.ts
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tim removed here - #19937
Following the discussion, I think it was causing issues in webpack 5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being included in the main bundle despite being a conditional require
Any idea how to fix this @Timer @ijjk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see it being included in the main bundle in the stats here, was it previously being included?