bug (#21943): remove incorrect rewrite of parsedUrl.pathname in serverless handler #22445

lindsaylevine · 2021-02-23T04:05:14Z

Fixes #21943

i confirmed in a personal test repo that this solves the issue of infinite 307s on root level non-default locales :) let me know what else this needs if anything! thanks for the time/help @ijjk ❤️

… serverelss handler

…-redirects

ijjk · 2021-02-25T18:23:31Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
buildDuration	12.9s	12.9s	⚠️ +38ms
nodeModulesSize	42.7 MB	42.7 MB	⚠️ +37 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.428	2.46	⚠️ +0.03
/ avg req/sec	1029.63	1016.44	⚠️ -13.19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.828	1.747	-0.08
/error-in-render avg req/sec	1367.51	1430.64	+63.13

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
index.html gzip	613 B	613 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
buildDuration	15.4s	15.3s	-161ms
nodeModulesSize	42.7 MB	42.7 MB	⚠️ +37 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
_error.js	1.01 MB	1.01 MB	⚠️ +14 B
404.html	2.67 kB	2.67 kB	✓
500.html	2.65 kB	2.65 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	⚠️ +14 B
link.js	1.06 MB	1.06 MB	⚠️ +14 B
routerDirect.js	1.06 MB	1.06 MB	⚠️ +14 B
withRouter.js	1.06 MB	1.06 MB	⚠️ +14 B
Overall change	5.21 MB	5.21 MB	⚠️ +70 B

Webpack 5 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
buildDuration	15.2s	15.5s	⚠️ +293ms
nodeModulesSize	42.7 MB	42.7 MB	⚠️ +37 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.355	2.359	0
/ avg req/sec	1061.37	1059.56	⚠️ -1.81
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.638	1.642	0
/error-in-render avg req/sec	1525.87	1522.86	⚠️ -3.01

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
597-74632e79..1d47.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	60.1 kB	60.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
_app-aedc815..1421.js gzip	1.26 kB	1.26 kB	✓
_error-71ec2..1a96.js gzip	3.38 kB	3.38 kB	✓
amp-33a09cb0..6745.js gzip	536 B	536 B	✓
hooks-4e968a..f870.js gzip	902 B	902 B	✓
index-5c6845..f75c.js gzip	230 B	230 B	✓
link-99f0c6c..b84a.js gzip	1.65 kB	1.65 kB	✓
routerDirect..bb56.js gzip	306 B	306 B	✓
withRouter-7..2133.js gzip	302 B	302 B	✓
Overall change	8.57 kB	8.57 kB	✓

Client Build Manifests

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
_buildManifest.js gzip	326 B	326 B	✓
Overall change	326 B	326 B	✓

Rendered Page Sizes

	vercel/next.js canary	lindsaylevine/next.js bug/i18n-root-307-redirects	Change
index.html gzip	586 B	586 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "ev7UCuU924PIWjZcR7eJM",
+        "buildId": "2V5IjhEjYBhZK5tAPakeM",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ev7UCuU924PIWjZcR7eJM/_buildManifest.js"
+      src="/_next/static/2V5IjhEjYBhZK5tAPakeM/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ev7UCuU924PIWjZcR7eJM/_ssgManifest.js"
+      src="/_next/static/2V5IjhEjYBhZK5tAPakeM/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "ev7UCuU924PIWjZcR7eJM",
+        "buildId": "2V5IjhEjYBhZK5tAPakeM",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ev7UCuU924PIWjZcR7eJM/_buildManifest.js"
+      src="/_next/static/2V5IjhEjYBhZK5tAPakeM/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ev7UCuU924PIWjZcR7eJM/_ssgManifest.js"
+      src="/_next/static/2V5IjhEjYBhZK5tAPakeM/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "ev7UCuU924PIWjZcR7eJM",
+        "buildId": "2V5IjhEjYBhZK5tAPakeM",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ev7UCuU924PIWjZcR7eJM/_buildManifest.js"
+      src="/_next/static/2V5IjhEjYBhZK5tAPakeM/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ev7UCuU924PIWjZcR7eJM/_ssgManifest.js"
+      src="/_next/static/2V5IjhEjYBhZK5tAPakeM/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: a4eb56a

ijjk

Thanks for the PR! I went ahead and added a test case for this as well to ensure we don't regress on it.

lindsaylevine · 2021-02-25T21:02:31Z

@ijjk haha dont thank me, thank YOU! after the tests failed i was gonna circle back and try to figure out what the actual change should be (and then maybe add a test) but i'm thankful you took care of it for me/us 🙏 . much appreciated!

bug (vercel#21943): remove incorrect rewrite of parsedUrl.pathname in…

ce648e8

… serverelss handler

lindsaylevine requested review from divmain, ijjk, lfades, Timer and timneutkens as code owners February 23, 2021 04:05

ijjk added the type: next label Feb 23, 2021

This comment has been minimized.

Sign in to view

ijjk added 2 commits February 25, 2021 11:54

Merge remote-tracking branch 'upstream/canary' into bug/i18n-root-307…

2707cb4

…-redirects

update pathname and add test

a4eb56a

ijjk approved these changes Feb 25, 2021

View reviewed changes

kodiakhq bot merged commit b1a1c80 into vercel:canary Feb 25, 2021

lindsaylevine mentioned this pull request Feb 25, 2021

[i18n] preview redirects are failing with non-default locales netlify/next-on-netlify#164

Closed

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug (#21943): remove incorrect rewrite of parsedUrl.pathname in serverless handler #22445

bug (#21943): remove incorrect rewrite of parsedUrl.pathname in serverless handler #22445

lindsaylevine commented Feb 23, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Feb 25, 2021

Diffs

ijjk left a comment

lindsaylevine commented Feb 25, 2021

bug (#21943): remove incorrect rewrite of parsedUrl.pathname in serverless handler #22445

bug (#21943): remove incorrect rewrite of parsedUrl.pathname in serverless handler #22445

Conversation

lindsaylevine commented Feb 23, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Feb 25, 2021

Stats from current PR

Diffs

ijjk left a comment

Choose a reason for hiding this comment

lindsaylevine commented Feb 25, 2021