Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade webpack5 #22460

Merged
merged 1 commit into from
Feb 23, 2021
Merged

chore: upgrade webpack5 #22460

merged 1 commit into from
Feb 23, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Feb 23, 2021

Upgrades webpack 5 and watchpack to their latest versions.

@ijjk
Copy link
Member

ijjk commented Feb 23, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/deps Change
buildDuration 11.6s 11.4s -185ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +21.4 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js upgrade/deps Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.147 2.257 ⚠️ +0.11
/ avg req/sec 1164.18 1107.88 ⚠️ -56.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.505 1.492 -0.01
/error-in-render avg req/sec 1661.16 1675.65 +14.49
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/deps Change
677f882d2ed8..854c.js gzip 13.2 kB 13.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/deps Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/deps Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/deps Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js upgrade/deps Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/deps Change
buildDuration 13.6s 13.3s -326ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +21.4 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/deps Change
677f882d2ed8..854c.js gzip 13.2 kB 13.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/deps Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/deps Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/deps Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js upgrade/deps Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/deps Change
buildDuration 13.5s 13.7s ⚠️ +163ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +21.4 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js upgrade/deps Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.243 2.323 ⚠️ +0.08
/ avg req/sec 1114.79 1076.34 ⚠️ -38.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.603 1.549 -0.05
/error-in-render avg req/sec 1559.4 1613.88 +54.48
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/deps Change
597-dc8125e2..ef24.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60 kB 60 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/deps Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/deps Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/deps Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js upgrade/deps Change
index.html gzip 585 B 585 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 579 B 579 B ✓
Overall change 1.75 kB 1.75 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "dkFBqpp5D_VXzzzX5FMhc",
+        "buildId": "YtKKgmZgdSkO20jPKDD37",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/dkFBqpp5D_VXzzzX5FMhc/_buildManifest.js"
+      src="/_next/static/YtKKgmZgdSkO20jPKDD37/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/dkFBqpp5D_VXzzzX5FMhc/_ssgManifest.js"
+      src="/_next/static/YtKKgmZgdSkO20jPKDD37/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "dkFBqpp5D_VXzzzX5FMhc",
+        "buildId": "YtKKgmZgdSkO20jPKDD37",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/dkFBqpp5D_VXzzzX5FMhc/_buildManifest.js"
+      src="/_next/static/YtKKgmZgdSkO20jPKDD37/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/dkFBqpp5D_VXzzzX5FMhc/_ssgManifest.js"
+      src="/_next/static/YtKKgmZgdSkO20jPKDD37/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "dkFBqpp5D_VXzzzX5FMhc",
+        "buildId": "YtKKgmZgdSkO20jPKDD37",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/dkFBqpp5D_VXzzzX5FMhc/_buildManifest.js"
+      src="/_next/static/YtKKgmZgdSkO20jPKDD37/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/dkFBqpp5D_VXzzzX5FMhc/_ssgManifest.js"
+      src="/_next/static/YtKKgmZgdSkO20jPKDD37/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 44df421

@kodiakhq kodiakhq bot merged commit f8cd075 into vercel:canary Feb 23, 2021
@Timer Timer deleted the upgrade/deps branch February 24, 2021 04:07
This was referenced Mar 5, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
This was referenced Mar 8, 2021
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Mar 15, 2021
Closed
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @ijjk @timneutkens