Set default webpack publicPath value to override auto #25452

ijjk · 2021-05-25T14:19:05Z

This ensures publicPath is set to an empty value since the default in webpack 5 is auto which isn't supported in IE11

Fixes: #25441

Bug

Related issues linked using fixes #number
Integration tests added

ijjk · 2021-05-25T15:04:59Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
buildDuration	15.1s	15.6s	⚠️ +456ms
buildDurationCached	4.1s	4.2s	⚠️ +101ms
nodeModulesSize	46.7 MB	46.7 MB	⚠️ +310 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.676	2.804	⚠️ +0.13
/ avg req/sec	934.18	891.57	⚠️ -42.61
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.683	1.672	-0.01
/error-in-render avg req/sec	1485.71	1495.31	+9.6

Client Bundles (main, webpack, commons) Overall decrease ✓

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	804 B	-190 B
Overall change	59.7 kB	59.5 kB	-190 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.54 kB	8.54 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
index.html gzip	561 B	559 B	-2 B
link.html gzip	569 B	568 B	-1 B
withRouter.html gzip	556 B	556 B	✓
Overall change	1.69 kB	1.68 kB	-3 B

Diffs

Diff for webpack-HASH.js

@@ -178,28 +178,7 @@
   /******/
 
   /******/ /******/ !(function() {
-    /******/ var scriptUrl;
-    /******/ if (__webpack_require__.g.importScripts)
-      scriptUrl = __webpack_require__.g.location + "";
-    /******/ var document = __webpack_require__.g.document;
-    /******/ if (!scriptUrl && document) {
-      /******/ if (document.currentScript)
-        /******/ scriptUrl = document.currentScript.src;
-      /******/ if (!scriptUrl) {
-        /******/ var scripts = document.getElementsByTagName("script");
-        /******/ if (scripts.length)
-          scriptUrl = scripts[scripts.length - 1].src;
-        /******/
-      }
-      /******/
-    } // When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration // or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
-    /******/ /******/ /******/ if (!scriptUrl)
-      throw new Error("Automatic publicPath is not supported in this browser");
-    /******/ scriptUrl = scriptUrl
-      .replace(/#.*$/, "")
-      .replace(/\?.*$/, "")
-      .replace(/\/[^\/]+$/, "/");
-    /******/ __webpack_require__.p = scriptUrl + "../../";
+    /******/ __webpack_require__.p = "";
     /******/
   })(); /* webpack/runtime/jsonp chunk loading */
   /******/

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-724d1f3a5f9503878f9c.js"
+      href="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
       src="/_next/static/chunks/polyfills-dd61a79f495b746e881e.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-724d1f3a5f9503878f9c.js"
+      src="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-724d1f3a5f9503878f9c.js"
+      href="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-dd61a79f495b746e881e.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-724d1f3a5f9503878f9c.js"
+      src="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
       async=""
     ></script>
     <script

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-724d1f3a5f9503878f9c.js"
+      href="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
       src="/_next/static/chunks/polyfills-dd61a79f495b746e881e.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-724d1f3a5f9503878f9c.js"
+      src="/_next/static/chunks/webpack-16fb5e52861014c05b14.js"
       async=""
     ></script>
     <script

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
buildDuration	17.6s	17.4s	-222ms
buildDurationCached	5.3s	5.2s	-137ms
nodeModulesSize	46.7 MB	46.7 MB	⚠️ +310 B

Client Bundles (main, webpack, commons) Overall decrease ✓

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	804 B	-190 B
Overall change	59.7 kB	59.5 kB	-190 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.54 kB	8.54 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	2.42 kB	2.42 kB	✓
500.html	2.41 kB	2.41 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.61 kB	1.61 kB	✓
css.html	1.79 kB	1.79 kB	✓
hooks.html	1.67 kB	1.67 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.4 kB	17.4 kB	✓
routerDirect.js	17.4 kB	17.4 kB	✓
withRouter.js	17.4 kB	17.4 kB	✓
Overall change	107 kB	107 kB	✓

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
buildDuration	13.4s	13.7s	⚠️ +224ms
buildDurationCached	5.8s	5.9s	⚠️ +24ms
nodeModulesSize	46.7 MB	46.7 MB	⚠️ +310 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.828	2.847	⚠️ +0.02
/ avg req/sec	884.02	878.13	⚠️ -5.89
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.649	1.633	-0.02
/error-in-render avg req/sec	1516.15	1530.86	+14.71

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.25 kB	7.25 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.38 kB	9.38 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/set-public-path	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 7d96207

* Set default webpack publicPath value to override auto * Add test case * update size-test

Set default webpack publicPath value to override auto

2c6e751

ijjk added the type: next label May 25, 2021

timneutkens previously approved these changes May 25, 2021

View reviewed changes

ijjk marked this pull request as ready for review May 25, 2021 14:24

ijjk requested review from divmain, lfades and shuding as code owners May 25, 2021 14:24

This comment has been minimized.

Sign in to view

ijjk added 2 commits May 25, 2021 09:45

Add test case

ebbcf2b

update size-test

7d96207

ijjk dismissed timneutkens’s stale review via 7d96207 May 25, 2021 14:52

ijjk requested a review from timneutkens May 25, 2021 14:52

timneutkens merged commit d84e2f5 into vercel:canary May 29, 2021

timneutkens deleted the fix/set-public-path branch May 29, 2021 12:15

sync-by-unito bot mentioned this pull request Jun 16, 2021

chore(deps): bump next from 10.1.2 to 11.0.0 filecoin-project/slate#793

Closed

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021

Set default webpack publicPath value to override auto (vercel#25452)

0756f9f

* Set default webpack publicPath value to override auto * Add test case * update size-test

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set default webpack publicPath value to override auto #25452

Set default webpack publicPath value to override auto #25452

ijjk commented May 25, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented May 25, 2021

Diffs

Set default webpack publicPath value to override auto #25452

Set default webpack publicPath value to override auto #25452

Conversation

ijjk commented May 25, 2021 • edited Loading

Bug

This comment has been minimized.

This comment has been minimized.

ijjk commented May 25, 2021

Stats from current PR

Diffs

ijjk commented May 25, 2021 •

edited

Loading