Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up-to-date electron #25551

Merged
merged 2 commits into from
Jun 3, 2021
Merged

up-to-date electron #25551

merged 2 commits into from
Jun 3, 2021

Conversation

tmtk75
Copy link
Contributor

@tmtk75 tmtk75 commented May 28, 2021

Bump up electron of an example, with-electron-typescript adding contextIsolation, https://www.electronjs.org/docs/tutorial/context-isolation#context-isolation.

@ijjk ijjk added the examples Issue/PR related to examples label May 28, 2021
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmtk75 All PRs need to go to the canary branch.

@tmtk75 tmtk75 changed the base branch from master to canary May 29, 2021 08:42
@tmtk75
Copy link
Contributor Author

tmtk75 commented May 29, 2021

@lfades Thank you. I fixed the base branch.

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit aada946 into vercel:canary Jun 3, 2021
@tmtk75 tmtk75 deleted the bump-up-electron branch June 3, 2021 02:59
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
Bump up electron of an example, `with-electron-typescript` adding `contextIsolation`,  https://www.electronjs.org/docs/tutorial/context-isolation#context-isolation.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants