Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest webpack 5 and webpack-sources #25558

Merged
merged 2 commits into from
May 29, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 28, 2021

Updates to latest webpack versions

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member Author

ijjk commented May 28, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/webpack-deps Change
buildDuration 13.6s 13.4s -240ms
buildDurationCached 3.8s 3.8s -4ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +9.69 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/webpack-deps Change
/ failed reqs 0 0
/ total time (seconds) 2.402 2.353 -0.05
/ avg req/sec 1040.84 1062.32 +21.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.219 1.26 ⚠️ +0.04
/error-in-render avg req/sec 2050.38 1984.33 ⚠️ -66.05
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/webpack-deps Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/webpack-deps Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js update/webpack-deps Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/webpack-deps Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/webpack-deps Change
index.html gzip 562 B 562 B
link.html gzip 569 B 569 B
withRouter.html gzip 558 B 558 B
Overall change 1.69 kB 1.69 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/webpack-deps Change
buildDuration 15.8s 15.6s -227ms
buildDurationCached 4.7s 4.8s ⚠️ +101ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +9.69 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/webpack-deps Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/webpack-deps Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js update/webpack-deps Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/webpack-deps Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Serverless bundles
vercel/next.js canary ijjk/next.js update/webpack-deps Change
_error.js 16.9 kB 16.9 kB -2 B
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 17.2 kB 17.2 kB
link.js 17.4 kB 17.4 kB ⚠️ +2 B
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB
Overall change 107 kB 107 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/webpack-deps Change
buildDuration 12.4s 12.4s ⚠️ +2ms
buildDurationCached 5.4s 5.3s -55ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +9.69 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/webpack-deps Change
/ failed reqs 0 0
/ total time (seconds) 2.458 2.369 -0.09
/ avg req/sec 1017.28 1055.37 +38.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.26 1.234 -0.03
/error-in-render avg req/sec 1984.22 2025.63 +41.41
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/webpack-deps Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.26 kB 7.26 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/webpack-deps Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js update/webpack-deps Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.63 kB 1.63 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.37 kB 9.37 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/webpack-deps Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/webpack-deps Change
index.html gzip 612 B 612 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB
Commit: c25d6bc

@timneutkens timneutkens merged commit b924207 into vercel:canary May 29, 2021
@timneutkens timneutkens deleted the update/webpack-deps branch May 29, 2021 12:14
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants