Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable serial build by default #25642

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Enable serial build by default #25642

merged 1 commit into from
Jun 2, 2021

Conversation

timneutkens
Copy link
Member

Will be landed for the next major version. This optimizes memory usage during next build, making it less likely that the build will OOM.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented May 31, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
buildDuration 13.7s 14.1s ⚠️ +431ms
buildDurationCached 3.9s 3.6s -283ms
nodeModulesSize 46.7 MB 46.7 MB -1.03 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.544 2.486 -0.06
/ avg req/sec 982.72 1005.76 +23.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.436 1.531 ⚠️ +0.09
/error-in-render avg req/sec 1741.44 1633.36 ⚠️ -108.08
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.52 kB 8.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
index.html gzip 561 B 561 B ✓
link.html gzip 568 B 568 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
buildDuration 15.6s 15.6s ⚠️ +33ms
buildDurationCached 4.6s 4.6s -42ms
nodeModulesSize 46.7 MB 46.7 MB -1.03 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.52 kB 8.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB -2 B
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB -2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
buildDuration 11.9s 12s ⚠️ +139ms
buildDurationCached 5s 5s ⚠️ +42ms
nodeModulesSize 46.7 MB 46.7 MB -1.03 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.405 2.435 ⚠️ +0.03
/ avg req/sec 1039.47 1026.53 ⚠️ -12.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.448 1.486 ⚠️ +0.04
/error-in-render avg req/sec 1726.04 1682.5 ⚠️ -43.54
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.37 kB 9.37 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/enable-serial-build Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 3d64485

@timneutkens timneutkens merged commit 5a5f0d0 into vercel:canary Jun 2, 2021
@timneutkens timneutkens deleted the add/enable-serial-build branch June 2, 2021 09:19
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@timneutkens
Enable serial build by default (vercel#25642)
7c2c292
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @ijjk