Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust JPEG quality when generating placeholder #25904

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Adjust JPEG quality when generating placeholder #25904

merged 2 commits into from
Jun 8, 2021

Conversation

atcastle
Copy link
Collaborator

@atcastle atcastle commented Jun 8, 2021

Small tweak to the quality setting for generated JPEG blurry placeholders. This makes the placeholder much more legible without increasing size.

@ijjk ijjk added the type: next label Jun 8, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jun 8, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
buildDuration 12.9s 13s ⚠️ +127ms
buildDurationCached 3.2s 3.1s -46ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.547 2.552 0
/ avg req/sec 981.59 979.44 ⚠️ -2.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.288 1.31 ⚠️ +0.02
/error-in-render avg req/sec 1940.87 1908.76 ⚠️ -32.11
Client Bundles (main, webpack, commons)
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
index.html gzip 571 B 571 B ✓
link.html gzip 579 B 579 B ✓
withRouter.html gzip 565 B 565 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
buildDuration 14.8s 14.5s -216ms
buildDurationCached 4.3s 4.3s ⚠️ +2ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +2 B
Client Bundles (main, webpack, commons)
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
_error.js 16.9 kB 16.9 kB ⚠️ +2 B
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ⚠️ +2 B
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ⚠️ +4 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
buildDuration 11.4s 11.5s ⚠️ +115ms
buildDurationCached 4.6s 4.9s ⚠️ +235ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.594 2.638 ⚠️ +0.04
/ avg req/sec 963.6 947.68 ⚠️ -15.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.311 1.329 ⚠️ +0.02
/error-in-render avg req/sec 1906.57 1881.6 ⚠️ -24.97
Client Bundles (main, webpack, commons)
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.17 kB 9.17 kB ✓
Client Build Manifests
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary atcastle/next.js fix-placeholder-quality Change
index.html gzip 627 B 627 B ✓
link.html gzip 633 B 633 B ✓
withRouter.html gzip 620 B 620 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: 0ee3045

@ijjk
Copy link
Member

ijjk commented Jun 8, 2021

Failing test suites

Commit: 0ee3045

test/integration/basic/test/index.test.js

  • Basic Features > should polyfill Node.js modules
Expand output

● Basic Features › should polyfill Node.js modules

thrown: "Exceeded timeout of 300000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  35 |   afterAll(() => killApp(context.server))
  36 |
> 37 |   it('should polyfill Node.js modules', async () => {
     |   ^
  38 |     const browser = await webdriver(context.appPort, '/node-browser-polyfills')
  39 |
  40 |     console.error({

  at integration/basic/test/index.test.js:37:3
  at Object.<anonymous> (integration/basic/test/index.test.js:18:1)

@timneutkens timneutkens merged commit ab450aa into vercel:canary Jun 8, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@atcastle @kodiakhq
Adjust JPEG quality when generating placeholder (vercel#25904)
7b2eaaa 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@styfle styfle styfle approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atcastle @ijjk @styfle @timneutkens