Fix delay between blur image and high res image #25994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
requested review from
divmain,
ijjk,
lfades,
shuding and
timneutkens
as code owners
|
This pull request has been linked to Clubhouse Story #22544: Fix next blur image delay. |
timneutkens
previously approved these changes
Jun 10, 2021
kripod
suggested changes
Jun 10, 2021
This comment has been minimized.
This comment has been minimized.
timneutkens
reviewed
Jun 10, 2021
kripod
suggested changes
Jun 10, 2021
Co-authored-by: Kristóf Poduszló <[email protected]>
timneutkens
previously approved these changes
Jun 10, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 3.023 | 3 | -0.02 |
| / avg req/sec | 827.07 | 833.29 | +6.22 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.698 | 1.738 | |
| /error-in-render avg req/sec | 1471.99 | 1438.31 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 20.2 kB | 20.2 kB | ✓ |
| webpack-HASH.js gzip | 804 B | 804 B | ✓ |
| Overall change | 60.3 kB | 60.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 801 B | 801 B | ✓ |
| _error-HASH.js gzip | 3.07 kB | 3.07 kB | ✓ |
| amp-HASH.js gzip | 527 B | 527 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| hooks-HASH.js gzip | 890 B | 890 B | ✓ |
| index-HASH.js gzip | 263 B | 263 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 333 B | 333 B | ✓ |
| withRouter-HASH.js gzip | 330 B | 330 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 8.31 kB | 8.31 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 392 B | 392 B | ✓ |
| Overall change | 392 B | 392 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| index.html gzip | 573 B | 573 B | ✓ |
| link.html gzip | 581 B | 581 B | ✓ |
| withRouter.html gzip | 568 B | 568 B | ✓ |
| Overall change | 1.72 kB | 1.72 kB | ✓ |
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| buildDuration | 17.1s | 16.7s | -416ms |
| buildDurationCached | 5s | 5.1s | |
| nodeModulesSize | 46.5 MB | 46.5 MB | -527 B |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 20.2 kB | 20.2 kB | ✓ |
| webpack-HASH.js gzip | 804 B | 804 B | ✓ |
| Overall change | 60.3 kB | 60.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 801 B | 801 B | ✓ |
| _error-HASH.js gzip | 3.07 kB | 3.07 kB | ✓ |
| amp-HASH.js gzip | 527 B | 527 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| hooks-HASH.js gzip | 890 B | 890 B | ✓ |
| index-HASH.js gzip | 263 B | 263 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 333 B | 333 B | ✓ |
| withRouter-HASH.js gzip | 330 B | 330 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 8.31 kB | 8.31 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 392 B | 392 B | ✓ |
| Overall change | 392 B | 392 B | ✓ |
Serverless bundles
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| _error.js | 16.9 kB | 16.9 kB | ✓ |
| 404.html | 2.44 kB | 2.44 kB | ✓ |
| 500.html | 2.43 kB | 2.43 kB | ✓ |
| amp.amp.html | 10.8 kB | 10.8 kB | ✓ |
| amp.html | 1.63 kB | 1.63 kB | ✓ |
| css.html | 1.81 kB | 1.81 kB | ✓ |
| hooks.html | 1.69 kB | 1.69 kB | ✓ |
| index.js | 17.2 kB | 17.2 kB | ✓ |
| link.js | 17.4 kB | 17.4 kB | ✓ |
| routerDirect.js | 17.4 kB | 17.4 kB | ✓ |
| withRouter.js | 17.4 kB | 17.4 kB | ✓ |
| Overall change | 107 kB | 107 kB | ✓ |
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| buildDuration | 13s | 13.1s | |
| buildDurationCached | 5.2s | 5.3s | |
| nodeModulesSize | 46.5 MB | 46.5 MB | -527 B |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 3.057 | 3.021 | -0.04 |
| / avg req/sec | 817.73 | 827.44 | +9.71 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.678 | 1.741 | |
| /error-in-render avg req/sec | 1489.63 | 1435.75 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| 677f882d2ed8..HASH.js gzip | 13.4 kB | 13.4 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 7.99 kB | 7.99 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 61.1 kB | 61.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.07 kB | 1.07 kB | ✓ |
| _error-HASH.js gzip | 3.74 kB | 3.74 kB | ✓ |
| amp-HASH.js gzip | 536 B | 536 B | ✓ |
| css-HASH.js gzip | 339 B | 339 B | ✓ |
| hooks-HASH.js gzip | 887 B | 887 B | ✓ |
| index-HASH.js gzip | 227 B | 227 B | ✓ |
| link-HASH.js gzip | 1.63 kB | 1.63 kB | ✓ |
| routerDirect..HASH.js gzip | 303 B | 303 B | ✓ |
| withRouter-HASH.js gzip | 302 B | 302 B | ✓ |
| e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 9.17 kB | 9.17 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 420 B | 420 B | ✓ |
| Overall change | 420 B | 420 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js ch22544/fix-blur-delay | Change | |
|---|---|---|---|
| index.html gzip | 627 B | 627 B | ✓ |
| link.html gzip | 633 B | 633 B | ✓ |
| withRouter.html gzip | 620 B | 620 B | ✓ |
| Overall change | 1.88 kB | 1.88 kB | ✓ |
styfle
changed the title
janicklas-ralph
pushed a commit
to janicklas-ralph/next.js
that referenced
this pull request
Jun 11, 2021
Previously, we had an arbitrary delay of 1500ms but instead we can wait until decoding is complete. Co-authored-by: Kristóf Poduszló <[email protected]>
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
Previously, we had an arbitrary delay of 1500ms but instead we can wait until decoding is complete. Co-authored-by: Kristóf Poduszló <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had an arbitrary delay of 1500ms but instead we can wait until decoding is complete.
Thanks to @kripod: #25916 (comment)