Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include lib folder when publishing next-codemod #26003

Merged
merged 2 commits into from
Jun 11, 2021
Merged

include lib folder when publishing next-codemod #26003

merged 2 commits into from
Jun 11, 2021

Conversation

timneutkens
Copy link
Member

Ensures lib is published in @next/codemod

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jun 11, 2021

Failing test suites

Commit: 574466d

test/integration/basic/test/index.test.js

  • Basic Features > should polyfill Node.js modules
Expand output

● Basic Features › should polyfill Node.js modules

thrown: "Exceeded timeout of 300000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  35 |   afterAll(() => killApp(context.server))
  36 |
> 37 |   it('should polyfill Node.js modules', async () => {
     |   ^
  38 |     const browser = await webdriver(context.appPort, '/node-browser-polyfills')
  39 |
  40 |     console.error({

  at integration/basic/test/index.test.js:37:3
  at Object.<anonymous> (integration/basic/test/index.test.js:18:1)

@ijjk
Copy link
Member

ijjk commented Jun 11, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
buildDuration 11.1s 10.9s -152ms
buildDurationCached 2.7s 2.7s -47ms
nodeModulesSize 46.5 MB 46.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.206 2.256 ⚠️ +0.05
/ avg req/sec 1133.18 1108.02 ⚠️ -25.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.129 1.123 -0.01
/error-in-render avg req/sec 2213.44 2225.31 +11.87
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
index.html gzip 573 B 573 B ✓
link.html gzip 580 B 580 B ✓
withRouter.html gzip 568 B 568 B ✓
Overall change 1.72 kB 1.72 kB ✓
Serverless Mode
General
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
buildDuration 12.6s 12.6s -42ms
buildDurationCached 8.7s 3.7s -5s
nodeModulesSize 46.5 MB 46.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.44 kB 2.44 kB ✓
500.html 2.43 kB 2.43 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.63 kB 1.63 kB ✓
css.html 1.81 kB 1.81 kB ✓
hooks.html 1.69 kB 1.69 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
buildDuration 9.9s 10.2s ⚠️ +283ms
buildDurationCached 4.1s 4s -55ms
nodeModulesSize 46.5 MB 46.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.305 2.308 0
/ avg req/sec 1084.52 1082.96 ⚠️ -1.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.164 1.177 ⚠️ +0.01
/error-in-render avg req/sec 2147.19 2124.7 ⚠️ -22.49
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.17 kB 9.17 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/publish-lib Change
index.html gzip 627 B 627 B ✓
link.html gzip 633 B 633 B ✓
withRouter.html gzip 620 B 620 B ✓
Overall change 1.88 kB 1.88 kB ✓
Commit: 297d72b

@kodiakhq kodiakhq bot merged commit 5925bf2 into vercel:canary Jun 11, 2021
janicklas-ralph pushed a commit to janicklas-ralph/next.js that referenced this pull request Jun 11, 2021
@timneutkens @janicklas-ralph
include lib folder when publishing next-codemod (vercel#26003)
611f5e2 
Ensures `lib` is published in @next/codemod

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@timneutkens
include lib folder when publishing next-codemod (vercel#26003)
ace2eb4 
Ensures `lib` is published in @next/codemod

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @ijjk