Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't create .eslintrc if package.json contains eslintConfig #26025

Merged
merged 8 commits into from
Jun 14, 2021
Merged

fix: don't create .eslintrc if package.json contains eslintConfig #26025

merged 8 commits into from
Jun 14, 2021

Conversation

vitalybaev
Copy link
Contributor

@vitalybaev vitalybaev commented Jun 11, 2021 •
edited
Loading

Bug

Fixes #25991

  • Related issues linked using fixes #number
  • Integration tests added

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
timneutkens
timneutkens previously requested changes Jun 14, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending integration tests

@vitalybaev
Copy link
Contributor Author

@timneutkens how to make this kind of test? I haven't found tests for similar case with .eslintrc
The only thing comes to my mind is to move/rename .eslintrc in the root of Next.js application. But it seems not a perfect way

@ijjk

This comment has been minimized.

Sign in to view
@vitalybaev
tests: added integration tests for next lint
5d4d814
@vitalybaev
Merge branch 'feature/25991-next-lint-creates-config-even-it-exists-i…
46e4bcf 
…n-package-json' of github.com:vitalybaev/next.js into feature/25991-next-lint-creates-config-even-it-exists-in-package-json
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk dismissed timneutkens’s stale review June 14, 2021 19:44

integration test added

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jun 14, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
buildDuration 13.8s 14.3s ⚠️ +445ms
buildDurationCached 3.3s 3.4s ⚠️ +23ms
nodeModulesSize 46.4 MB 46.4 MB ⚠️ +197 B
Page Load Tests Overall increase ✓
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.525 2.524 0
/ avg req/sec 990.12 990.54 +0.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.492 1.385 -0.11
/error-in-render avg req/sec 1675.65 1805.05 +129.4
Client Bundles (main, webpack, commons)
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 329 B 329 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Rendered Page Sizes
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
index.html gzip 522 B 522 B ✓
link.html gzip 535 B 535 B ✓
withRouter.html gzip 515 B 515 B ✓
Overall change 1.57 kB 1.57 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
buildDuration 15.8s 15.6s -249ms
buildDurationCached 4.6s 4.7s ⚠️ +74ms
nodeModulesSize 46.4 MB 46.4 MB ⚠️ +197 B
Client Bundles (main, webpack, commons)
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 329 B 329 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
_buildManifest.js gzip 391 B 391 B ✓
Overall change 391 B 391 B ✓
Serverless bundles
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
_error.js 16.9 kB 16.9 kB ✓
404.html 1.98 kB 1.98 kB ✓
500.html 1.96 kB 1.96 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.17 kB 1.17 kB ✓
css.html 1.35 kB 1.35 kB ✓
hooks.html 1.23 kB 1.23 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.5 kB 17.5 kB ✓
routerDirect.js 17.3 kB 17.3 kB ✓
withRouter.js 17.3 kB 17.3 kB ✓
Overall change 105 kB 105 kB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
buildDuration 12.9s 12.8s -132ms
buildDurationCached 5s 4.9s -142ms
nodeModulesSize 46.4 MB 46.4 MB ⚠️ +197 B
Page Load Tests Overall increase ✓
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.556 2.566 ⚠️ +0.01
/ avg req/sec 978.17 974.34 ⚠️ -3.83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.51 1.466 -0.04
/error-in-render avg req/sec 1655.58 1705.08 +49.5
Client Bundles (main, webpack, commons)
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 41.8 kB 41.8 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 63.9 kB 63.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.84 kB 3.84 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 333 B 333 B ✓
hooks-HASH.js gzip 910 B 910 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 295 B 295 B ✓
withRouter-HASH.js gzip 292 B 292 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vitalybaev/next.js feature/25991-next-lint-creates-config-even-it-exists-in-package-json Change
index.html gzip 568 B 568 B ✓
link.html gzip 580 B 580 B ✓
withRouter.html gzip 561 B 561 B ✓
Overall change 1.71 kB 1.71 kB ✓
Commit: d2097aa

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk merged commit 66cb786 into vercel:canary Jun 14, 2021
@vitalybaev vitalybaev deleted the feature/25991-next-lint-creates-config-even-it-exists-in-package-json branch June 14, 2021 21:09
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@vitalybaev @ijjk
fix: don't create .eslintrc if package.json contains eslintConfig (ve…
ac79684 
…rcel#26025)

* fix: don't create .eslintrc if package.json contains eslintConfig

* tests: added integration tests for next lint

Co-authored-by: JJ Kasper <[email protected]>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

next lint creates .eslintrc even though eslintConfig field exists in package.json
3 participants
@vitalybaev @ijjk @timneutkens