(examples/with-tailwind-emotion-twin-macro): add new example #26060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akellbl4
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
|
@akellbl4 Many thanks for PR. |
ijjk
reviewed
Aug 8, 2022
There was a problem hiding this comment.
Hi, per our example guidelines https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples we want to aim for examples to highlight specific packages/resources and we already have one for tailwindcss and emotion. Also it's less ideal to showcase any babel specific plugins as this de-opts swc support.
Thanks for the PR though!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twin.macro is a pretty popular and well-supported package for integration of Tailwind CSS with Emotion.js
Live example on StackBlitz
Feature
Documentation / Examples