Remove deprecated features and enable future flag #26066

timneutkens · 2021-06-14T10:14:50Z

Enables excludeDefaultMomentLocales by default
Adds distDir cleaning (See RFC [RFC] cleaning distDir on next build #6009)
Adds support for PORT (See Added support for process.env.PORT #11408)
Removes router.events from the server-side router as it should not be used server-side (long-standing todo that is potentially breaking). Note that it's still available as Router.events (import Router from 'next/router') and with useRouter in useEffect. Using it with useEffect is the correct way and I've updated the upgrading guide to reflect that
Added webpack 5 to the upgrading guide
Removed Head.rewind as it's been a no-op since Next.js 9.5 and can now be safely removed from user code

Fixes #11408
Fixes #10338
Fixes #5554

Bug

Related issues linked using fixes #number
Integration tests added

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

Make sure the linting passes

- Enables excludeDefaultMomentLocales by default - Adds distDir cleaning (See RFC vercel#6009) - Removes `router.router.events` (never documented) - Removes `router.events` from the server-side router as it should not be used server-side (long-standing todo that is potentially breaking). Note that it's still available as `Router.events` (import Router from 'next/router') and with `useRouter` in `useEffect`. Using it with `useEffect` is the correct way and I've updated the upgrading guide to reflect that - Added webpack 5 to the upgrading guide - Removed Head.rewind as it's been a no-op since Next.js 9.5 and can now be safely removed from user code

Added docs and tests for this change as well Co-Authored-By: Emilis Kiškis <[email protected]>

ijjk · 2021-06-14T12:42:01Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
buildDuration	14.3s	14.1s	-227ms
buildDurationCached	3.4s	3.5s	⚠️ +114ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +50 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.705	2.658	-0.05
/ avg req/sec	924.27	940.6	+16.33
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.714	1.71	0
/error-in-render avg req/sec	1458.9	1461.69	+2.79

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.18 kB	3.17 kB	-13 B
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.43 kB	8.41 kB	-13 B

Client Build Manifests Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
_buildManifest.js gzip	395 B	391 B	-4 B
Overall change	395 B	391 B	-4 B

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
index.html gzip	522 B	522 B	✓
link.html gzip	535 B	535 B	✓
withRouter.html gzip	516 B	516 B	✓
Overall change	1.57 kB	1.57 kB	✓

Diffs

Diff for _buildManifest.js

@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
   __rewrites: { beforeFiles: [], afterFiles: [], fallback: [] },
   "/": ["static\u002Fchunks\u002Fpages\u002Findex-96d821e908dd023681e4.js"],
   "/_error": [
-    "static\u002Fchunks\u002Fpages\u002F_error-d72f3a5cb613472cc608.js"
+    "static\u002Fchunks\u002Fpages\u002F_error-a9b3a05c6c7f15ca24a9.js"
   ],
   "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-7f1c918feab47667356f.js"],
   "/css": [

Diff for _error-HASH.js

@@ -485,9 +485,7 @@ Also adds support for deduplicated `key` properties
           },
           children
         );
-      } // TODO: Remove in the next major release
-
-      Head.rewind = function() {};
+      }
 
       var _default = Head;
       exports.default = _default;

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
buildDuration	16.3s	16.2s	-35ms
buildDurationCached	4.5s	4.7s	⚠️ +144ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +50 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.18 kB	3.17 kB	-13 B
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.43 kB	8.41 kB	-13 B

Client Build Manifests Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
_buildManifest.js gzip	395 B	391 B	-4 B
Overall change	395 B	391 B	-4 B

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	1.98 kB	1.98 kB	✓
500.html	1.96 kB	1.96 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.17 kB	1.17 kB	✓
css.html	1.35 kB	1.35 kB	✓
hooks.html	1.23 kB	1.23 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.4 kB	17.4 kB	✓
routerDirect.js	17.4 kB	17.4 kB	✓
withRouter.js	17.4 kB	17.4 kB	⚠️ +2 B
Overall change	105 kB	105 kB	⚠️ +2 B

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
buildDuration	12.5s	12.6s	⚠️ +69ms
buildDurationCached	5.1s	5.1s	-41ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +50 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.73	2.695	-0.04
/ avg req/sec	915.79	927.61	+11.82
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.638	1.686	⚠️ +0.05
/error-in-render avg req/sec	1526.58	1482.9	⚠️ -43.68

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.99 kB	7.99 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	61.1 kB	61.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
_app-HASH.js gzip	1.07 kB	1.07 kB	✓
_error-HASH.js gzip	3.85 kB	3.84 kB	-11 B
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.63 kB	1.63 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.28 kB	9.27 kB	-11 B

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/remove-deprecation-todos	Change
index.html gzip	568 B	568 B	✓
link.html gzip	582 B	582 B	✓
withRouter.html gzip	561 B	561 B	✓
Overall change	1.71 kB	1.71 kB	✓

Diffs

Diff for _buildManifest.js

@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
   __rewrites: { beforeFiles: [], afterFiles: [], fallback: [] },
   "/": ["static\u002Fchunks\u002Fpages\u002Findex-b460df3d63326fbb06a1.js"],
   "/_error": [
-    "static\u002Fchunks\u002Fpages\u002F_error-f045b37d58937af1709b.js"
+    "static\u002Fchunks\u002Fpages\u002F_error-a195cc394aa8ad172947.js"
   ],
   "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-27f75ad11120c5cdedd1.js"],
   "/css": [

Diff for _error-HASH.js

@@ -604,9 +604,7 @@ Also adds support for deduplicated `key` properties
           },
           children
         );
-      } // TODO: Remove in the next major release
-
-      Head.rewind = function() {};
+      }
 
       var _default = Head;
       exports["default"] = _default;

Commit: a233396

- Enables excludeDefaultMomentLocales by default - Adds distDir cleaning (See RFC vercel#6009) - Adds support for `PORT` - Removes `router.events` from the server-side router as it should not be used server-side (long-standing todo that is potentially breaking). Note that it's still available as `Router.events` (import Router from 'next/router') and with `useRouter` in `useEffect`. Using it with `useEffect` is the correct way and I've updated the upgrading guide to reflect that - Added webpack 5 to the upgrading guide - Removed `Head.rewind` as it's been a no-op since Next.js 9.5 and can now be safely removed from user code Fixes vercel#11408 Fixes vercel#10338 Fixes vercel#5554 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes

timneutkens requested review from divmain, ijjk, leerob, lfades and shuding as code owners June 14, 2021 10:14

ijjk added type: documentation type: next labels Jun 14, 2021

timneutkens and others added 5 commits June 14, 2021 12:42

Fix type error

efe8c18

Add support for PORT

569fa30

Added docs and tests for this change as well Co-Authored-By: Emilis Kiškis <[email protected]>

Add PORT to upgrading guide

aefef0e

Bring back this.events to solve typing issues

ccaf439

Add note about .env not being supported for PORT

4e7a2a9

This comment has been minimized.

Sign in to view

Update failing test suites to preserve distDir

f446212

This comment has been minimized.

Sign in to view

Update test

a233396

ijjk approved these changes Jun 14, 2021

View reviewed changes

kodiakhq bot merged commit cb84bc5 into vercel:canary Jun 14, 2021

timneutkens mentioned this pull request Jun 14, 2021

Added support for process.env.PORT #11408

Closed

timneutkens deleted the fix/remove-deprecation-todos branch June 14, 2021 16:28

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated features and enable future flag #26066

Remove deprecated features and enable future flag #26066

timneutkens commented Jun 14, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 14, 2021

Diffs

Diffs

Remove deprecated features and enable future flag #26066

Remove deprecated features and enable future flag #26066

Conversation

timneutkens commented Jun 14, 2021 • edited Loading

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 14, 2021

Stats from current PR

Diffs

Diffs

timneutkens commented Jun 14, 2021 •

edited

Loading