Update next/image docs and examples #26150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atcastle
previously approved these changes
Jun 15, 2021
| /> | ||
| <ViewSource pathname="pages/placeholder.js" /> | ||
| <h1>Image Component With Placeholder</h1> | ||
| <Image alt="Mountains" src={mountains} placeholder="blur" /> |
There was a problem hiding this comment.
Just to make sure this is intentional--this changes the behavior of the page since the image is intrinsically larger than 700x475. It might be worth leaving an example that shows that you can override the intrinsic size of a statically-imported image.
There was a problem hiding this comment.
Done! I removed the layout=responsive so that the width and height will take affect
ijjk
approved these changes
Jun 16, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 24, 2021
This updates the `next/image` docs and examples to add missing information.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
next/imagedocs and examples to add missing information.