Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor decode failures #26899

Merged
merged 4 commits into from
Jul 5, 2021
Merged

Refactor decode failures #26899

merged 4 commits into from
Jul 5, 2021

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Jul 3, 2021 •
edited
Loading

Use a custom error class instead of a stringly typed Error. There was an existing TODO to fix this, but I could also use it for the streaming refactor, so that these errors can be more easily handled at a higher level.

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Jul 3, 2021
@ijjk

This comment has been minimized.

Sign in to view
@devknoll devknoll marked this pull request as ready for review July 3, 2021 17:56
@ijjk
Copy link
Member

ijjk commented Jul 5, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js refactor-decode-error Change
buildDuration 11.7s 11.6s -134ms
buildDurationCached 2.8s 2.8s ⚠️ +3ms
nodeModulesSize 49.3 MB 49.3 MB -957 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js refactor-decode-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.064 2.088 ⚠️ +0.02
/ avg req/sec 1211.41 1197.3 ⚠️ -14.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.16 1.19 ⚠️ +0.03
/error-in-render avg req/sec 2155.92 2100.93 ⚠️ -54.99
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary azukaru/next.js refactor-decode-error Change
359.HASH.js gzip 3.09 kB 3.09 kB ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.6 kB ⚠️ +317 B
webpack-HASH.js gzip 1.49 kB 1.49 kB ✓
Overall change 66.9 kB 67.2 kB ⚠️ +317 B
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js refactor-decode-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js refactor-decode-error Change
_app-HASH.js gzip 803 B 803 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 329 B 329 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.42 kB 8.42 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js refactor-decode-error Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary azukaru/next.js refactor-decode-error Change
index.html gzip 522 B 523 B ⚠️ +1 B
link.html gzip 535 B 537 B ⚠️ +2 B
withRouter.html gzip 515 B 515 B ✓
Overall change 1.57 kB 1.57 kB ⚠️ +3 B

Diffs

Diff for main-HASH.js 
@@ -332,6 +332,16 @@
       /***/
     },
 
+    /***/ 430: /***/ function(module) {
+      function _isNativeFunction(fn) {
+        return Function.toString.call(fn).indexOf("[native code]") !== -1;
+      }
+
+      module.exports = _isNativeFunction;
+
+      /***/
+    },
+
     /***/ 7067: /***/ function(module) {
       function _isNativeReflectConstruct() {
         if (typeof Reflect === "undefined" || !Reflect.construct) return false;
@@ -548,6 +558,64 @@
       /***/
     },
 
+    /***/ 5957: /***/ function(
+      module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      var getPrototypeOf = __webpack_require__(9754);
+
+      var setPrototypeOf = __webpack_require__(9489);
+
+      var isNativeFunction = __webpack_require__(430);
+
+      var construct = __webpack_require__(9100);
+
+      function _wrapNativeSuper(Class) {
+        var _cache = typeof Map === "function" ? new Map() : undefined;
+
+        module.exports = _wrapNativeSuper = function _wrapNativeSuper(Class) {
+          if (Class === null || !isNativeFunction(Class)) return Class;
+
+          if (typeof Class !== "function") {
+            throw new TypeError(
+              "Super expression must either be null or a function"
+            );
+          }
+
+          if (typeof _cache !== "undefined") {
+            if (_cache.has(Class)) return _cache.get(Class);
+
+            _cache.set(Class, Wrapper);
+          }
+
+          function Wrapper() {
+            return construct(
+              Class,
+              arguments,
+              getPrototypeOf(this).constructor
+            );
+          }
+
+          Wrapper.prototype = Object.create(Class.prototype, {
+            constructor: {
+              value: Wrapper,
+              enumerable: false,
+              writable: true,
+              configurable: true
+            }
+          });
+          return setPrototypeOf(Wrapper, Class);
+        };
+
+        return _wrapNativeSuper(Class);
+      }
+
+      module.exports = _wrapNativeSuper;
+
+      /***/
+    },
+
     /***/ 7757: /***/ function(
       module,
       __unused_webpack_exports,
@@ -5769,12 +5837,18 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       /***/
     },
 
-    /***/ 3990: /***/ function(__unused_webpack_module, exports) {
+    /***/ 3990: /***/ function(
+      __unused_webpack_module,
+      exports,
+      __webpack_require__
+    ) {
       "use strict";
 
       exports.__esModule = true;
       exports.getRouteMatcher = getRouteMatcher;
 
+      var _utils = __webpack_require__(9664);
+
       function getRouteMatcher(routeRegex) {
         var re = routeRegex.re,
           groups = routeRegex.groups;
@@ -5789,9 +5863,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             try {
               return decodeURIComponent(param);
             } catch (_) {
-              var err = new Error("failed to decode param");
-              err.code = "DECODE_FAILED";
-              throw err;
+              throw new _utils.DecodeError("failed to decode param");
             }
           };
 
@@ -5926,8 +5998,47 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       var _regeneratorRuntime = __webpack_require__(7757);
 
+      var _classCallCheck = __webpack_require__(4575);
+
+      var _inherits = __webpack_require__(2205);
+
+      var _possibleConstructorReturn = __webpack_require__(8585);
+
+      var _getPrototypeOf = __webpack_require__(9754);
+
+      var _wrapNativeSuper = __webpack_require__(5957);
+
       var _asyncToGenerator = __webpack_require__(8926);
 
+      function _createSuper(Derived) {
+        var hasNativeReflectConstruct = _isNativeReflectConstruct();
+        return function _createSuperInternal() {
+          var Super = _getPrototypeOf(Derived),
+            result;
+          if (hasNativeReflectConstruct) {
+            var NewTarget = _getPrototypeOf(this).constructor;
+            result = Reflect.construct(Super, arguments, NewTarget);
+          } else {
+            result = Super.apply(this, arguments);
+          }
+          return _possibleConstructorReturn(this, result);
+        };
+      }
+
+      function _isNativeReflectConstruct() {
+        if (typeof Reflect === "undefined" || !Reflect.construct) return false;
+        if (Reflect.construct.sham) return false;
+        if (typeof Proxy === "function") return true;
+        try {
+          Date.prototype.toString.call(
+            Reflect.construct(Date, [], function() {})
+          );
+          return true;
+        } catch (e) {
+          return false;
+        }
+      }
+
       exports.__esModule = true;
       exports.execOnce = execOnce;
       exports.getLocationOrigin = getLocationOrigin;
@@ -5936,7 +6047,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       exports.isResSent = isResSent;
       exports.loadGetInitialProps = loadGetInitialProps;
       exports.formatWithValidation = formatWithValidation;
-      exports.ST = exports.SP = exports.urlObjectKeys = void 0;
+      exports.DecodeError = exports.ST = exports.SP = exports.urlObjectKeys = void 0;
 
       var _formatUrl = __webpack_require__(2065);
       /**
@@ -6119,6 +6230,22 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
         typeof performance.measure === "function";
       exports.ST = ST;
 
+      var DecodeError = /*#__PURE__*/ (function(_Error) {
+        _inherits(DecodeError, _Error);
+
+        var _super = _createSuper(DecodeError);
+
+        function DecodeError() {
+          _classCallCheck(this, DecodeError);
+
+          return _super.apply(this, arguments);
+        }
+
+        return DecodeError;
+      })(/*#__PURE__*/ _wrapNativeSuper(Error));
+
+      exports.DecodeError = DecodeError;
+
       /***/
     },
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-889ecdeb27082b90e45f.js"
+      src="/_next/static/chunks/main-9ebeae463c4ce769a7ac.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-889ecdeb27082b90e45f.js"
+      src="/_next/static/chunks/main-9ebeae463c4ce769a7ac.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-889ecdeb27082b90e45f.js"
+      src="/_next/static/chunks/main-9ebeae463c4ce769a7ac.js"
       defer=""
     ></script>
     <script
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js refactor-decode-error Change
buildDuration 10.5s 10.5s -42ms
buildDurationCached 4.2s 4.1s -57ms
nodeModulesSize 49.3 MB 49.3 MB -957 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js refactor-decode-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.151 2.112 -0.04
/ avg req/sec 1162.2 1183.53 +21.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.174 1.189 ⚠️ +0.02
/error-in-render avg req/sec 2128.86 2102.32 ⚠️ -26.54
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary azukaru/next.js refactor-decode-error Change
14.HASH.js gzip 3.11 kB 3.11 kB ✓
677f882d2ed8..HASH.js gzip 13.4 kB 13.9 kB ⚠️ +538 B
framework.HASH.js gzip 41.8 kB 41.8 kB ✓
main-HASH.js gzip 8.07 kB 7.81 kB -257 B
webpack-HASH.js gzip 1.19 kB 1.19 kB ✓
Overall change 67.5 kB 67.8 kB ⚠️ +281 B
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js refactor-decode-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages Overall decrease ✓
vercel/next.js canary azukaru/next.js refactor-decode-error Change
_app-HASH.js gzip 1.07 kB 791 B -283 B
_error-HASH.js gzip 3.83 kB 3.83 kB ✓
amp-HASH.js gzip 531 B 531 B ✓
css-HASH.js gzip 333 B 333 B ✓
hooks-HASH.js gzip 910 B 910 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 295 B 295 B ✓
withRouter-HASH.js gzip 292 B 292 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.26 kB 8.98 kB -283 B
Client Build Manifests
vercel/next.js canary azukaru/next.js refactor-decode-error Change
_buildManifest.js gzip 418 B 418 B ✓
Overall change 418 B 418 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary azukaru/next.js refactor-decode-error Change
index.html gzip 565 B 568 B ⚠️ +3 B
link.html gzip 580 B 581 B ⚠️ +1 B
withRouter.html gzip 559 B 561 B ⚠️ +2 B
Overall change 1.7 kB 1.71 kB ⚠️ +6 B

Diffs

Diff for _app-HASH.js 
@@ -8,31 +8,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       /***/
     },
 
-    /***/ "7W2i": /***/ function(module, exports, __webpack_require__) {
-      var setPrototypeOf = __webpack_require__("SksO");
-
-      function _inherits(subClass, superClass) {
-        if (typeof superClass !== "function" && superClass !== null) {
-          throw new TypeError(
-            "Super expression must either be null or a function"
-          );
-        }
-
-        subClass.prototype = Object.create(superClass && superClass.prototype, {
-          constructor: {
-            value: subClass,
-            writable: true,
-            configurable: true
-          }
-        });
-        if (superClass) setPrototypeOf(subClass, superClass);
-      }
-
-      module.exports = _inherits;
-
-      /***/
-    },
-
     /***/ B5Ud: /***/ function(module, exports, __webpack_require__) {
       "use strict";
 
@@ -164,58 +139,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       /***/
     },
 
-    /***/ Nsbk: /***/ function(module, exports) {
-      function _getPrototypeOf(o) {
-        module.exports = _getPrototypeOf = Object.setPrototypeOf
-          ? Object.getPrototypeOf
-          : function _getPrototypeOf(o) {
-              return o.__proto__ || Object.getPrototypeOf(o);
-            };
-        return _getPrototypeOf(o);
-      }
-
-      module.exports = _getPrototypeOf;
-
-      /***/
-    },
-
-    /***/ PJYZ: /***/ function(module, exports) {
-      function _assertThisInitialized(self) {
-        if (self === void 0) {
-          throw new ReferenceError(
-            "this hasn't been initialised - super() hasn't been called"
-          );
-        }
-
-        return self;
-      }
-
-      module.exports = _assertThisInitialized;
-
-      /***/
-    },
-
-    /***/ a1gu: /***/ function(module, exports, __webpack_require__) {
-      var _typeof = __webpack_require__("cDf5");
-
-      var assertThisInitialized = __webpack_require__("PJYZ");
-
-      function _possibleConstructorReturn(self, call) {
-        if (
-          call &&
-          (_typeof(call) === "object" || typeof call === "function")
-        ) {
-          return call;
-        }
-
-        return assertThisInitialized(self);
-      }
-
-      module.exports = _possibleConstructorReturn;
-
-      /***/
-    },
-
     /***/ "e9+W": /***/ function(module, exports, __webpack_require__) {
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/_app",
Diff for 677f882d2ed8..c4df.HASH.js 
@@ -192,8 +192,47 @@
 
       var _regeneratorRuntime = __webpack_require__("o0o1");
 
+      var _classCallCheck = __webpack_require__("lwsE");
+
+      var _inherits = __webpack_require__("7W2i");
+
+      var _possibleConstructorReturn = __webpack_require__("a1gu");
+
+      var _getPrototypeOf = __webpack_require__("Nsbk");
+
+      var _wrapNativeSuper = __webpack_require__("oShl");
+
       var _asyncToGenerator = __webpack_require__("yXPU");
 
+      function _createSuper(Derived) {
+        var hasNativeReflectConstruct = _isNativeReflectConstruct();
+        return function _createSuperInternal() {
+          var Super = _getPrototypeOf(Derived),
+            result;
+          if (hasNativeReflectConstruct) {
+            var NewTarget = _getPrototypeOf(this).constructor;
+            result = Reflect.construct(Super, arguments, NewTarget);
+          } else {
+            result = Super.apply(this, arguments);
+          }
+          return _possibleConstructorReturn(this, result);
+        };
+      }
+
+      function _isNativeReflectConstruct() {
+        if (typeof Reflect === "undefined" || !Reflect.construct) return false;
+        if (Reflect.construct.sham) return false;
+        if (typeof Proxy === "function") return true;
+        try {
+          Date.prototype.toString.call(
+            Reflect.construct(Date, [], function() {})
+          );
+          return true;
+        } catch (e) {
+          return false;
+        }
+      }
+
       exports.__esModule = true;
       exports.execOnce = execOnce;
       exports.getLocationOrigin = getLocationOrigin;
@@ -202,7 +241,7 @@
       exports.isResSent = isResSent;
       exports.loadGetInitialProps = loadGetInitialProps;
       exports.formatWithValidation = formatWithValidation;
-      exports.ST = exports.SP = exports.urlObjectKeys = void 0;
+      exports.DecodeError = exports.ST = exports.SP = exports.urlObjectKeys = void 0;
 
       var _formatUrl = __webpack_require__("JHdK");
       /**
@@ -385,6 +424,47 @@
         typeof performance.measure === "function";
       exports.ST = ST;
 
+      var DecodeError = /*#__PURE__*/ (function(_Error) {
+        _inherits(DecodeError, _Error);
+
+        var _super = _createSuper(DecodeError);
+
+        function DecodeError() {
+          _classCallCheck(this, DecodeError);
+
+          return _super.apply(this, arguments);
+        }
+
+        return DecodeError;
+      })(/*#__PURE__*/ _wrapNativeSuper(Error));
+
+      exports.DecodeError = DecodeError;
+
+      /***/
+    },
+
+    /***/ "7W2i": /***/ function(module, exports, __webpack_require__) {
+      var setPrototypeOf = __webpack_require__("SksO");
+
+      function _inherits(subClass, superClass) {
+        if (typeof superClass !== "function" && superClass !== null) {
+          throw new TypeError(
+            "Super expression must either be null or a function"
+          );
+        }
+
+        subClass.prototype = Object.create(superClass && superClass.prototype, {
+          constructor: {
+            value: subClass,
+            writable: true,
+            configurable: true
+          }
+        });
+        if (superClass) setPrototypeOf(subClass, superClass);
+      }
+
+      module.exports = _inherits;
+
       /***/
     },
 
@@ -1145,6 +1225,37 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       /***/
     },
 
+    /***/ Nsbk: /***/ function(module, exports) {
+      function _getPrototypeOf(o) {
+        module.exports = _getPrototypeOf = Object.setPrototypeOf
+          ? Object.getPrototypeOf
+          : function _getPrototypeOf(o) {
+              return o.__proto__ || Object.getPrototypeOf(o);
+            };
+        return _getPrototypeOf(o);
+      }
+
+      module.exports = _getPrototypeOf;
+
+      /***/
+    },
+
+    /***/ PJYZ: /***/ function(module, exports) {
+      function _assertThisInitialized(self) {
+        if (self === void 0) {
+          throw new ReferenceError(
+            "this hasn't been initialised - super() hasn't been called"
+          );
+        }
+
+        return self;
+      }
+
+      module.exports = _assertThisInitialized;
+
+      /***/
+    },
+
     /***/ Qetd: /***/ function(module, exports, __webpack_require__) {
       "use strict";
       var assign = Object.assign.bind(Object);
@@ -3435,6 +3546,27 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       /***/
     },
 
+    /***/ a1gu: /***/ function(module, exports, __webpack_require__) {
+      var _typeof = __webpack_require__("cDf5");
+
+      var assertThisInitialized = __webpack_require__("PJYZ");
+
+      function _possibleConstructorReturn(self, call) {
+        if (
+          call &&
+          (_typeof(call) === "object" || typeof call === "function")
+        ) {
+          return call;
+        }
+
+        return assertThisInitialized(self);
+      }
+
+      module.exports = _possibleConstructorReturn;
+
+      /***/
+    },
+
     /***/ b48C: /***/ function(module, exports) {
       function _isNativeReflectConstruct() {
         if (typeof Reflect === "undefined" || !Reflect.construct) return false;
@@ -4668,12 +4800,68 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       /***/
     },
 
+    /***/ oShl: /***/ function(module, exports, __webpack_require__) {
+      var getPrototypeOf = __webpack_require__("Nsbk");
+
+      var setPrototypeOf = __webpack_require__("SksO");
+
+      var isNativeFunction = __webpack_require__("xfeJ");
+
+      var construct = __webpack_require__("sXyB");
+
+      function _wrapNativeSuper(Class) {
+        var _cache = typeof Map === "function" ? new Map() : undefined;
+
+        module.exports = _wrapNativeSuper = function _wrapNativeSuper(Class) {
+          if (Class === null || !isNativeFunction(Class)) return Class;
+
+          if (typeof Class !== "function") {
+            throw new TypeError(
+              "Super expression must either be null or a function"
+            );
+          }
+
+          if (typeof _cache !== "undefined") {
+            if (_cache.has(Class)) return _cache.get(Class);
+
+            _cache.set(Class, Wrapper);
+          }
+
+          function Wrapper() {
+            return construct(
+              Class,
+              arguments,
+              getPrototypeOf(this).constructor
+            );
+          }
+
+          Wrapper.prototype = Object.create(Class.prototype, {
+            constructor: {
+              value: Wrapper,
+              enumerable: false,
+              writable: true,
+              configurable: true
+            }
+          });
+          return setPrototypeOf(Wrapper, Class);
+        };
+
+        return _wrapNativeSuper(Class);
+      }
+
+      module.exports = _wrapNativeSuper;
+
+      /***/
+    },
+
     /***/ qdaa: /***/ function(module, exports, __webpack_require__) {
       "use strict";
 
       exports.__esModule = true;
       exports.getRouteMatcher = getRouteMatcher;
 
+      var _utils = __webpack_require__("52bY");
+
       function getRouteMatcher(routeRegex) {
         var re = routeRegex.re,
           groups = routeRegex.groups;
@@ -4688,9 +4876,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             try {
               return decodeURIComponent(param);
             } catch (_) {
-              var err = new Error("failed to decode param");
-              err.code = "DECODE_FAILED";
-              throw err;
+              throw new _utils.DecodeError("failed to decode param");
             }
           };
 
@@ -4769,6 +4955,16 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
       /***/
     },
 
+    /***/ xfeJ: /***/ function(module, exports) {
+      function _isNativeFunction(fn) {
+        return Function.toString.call(fn).indexOf("[native code]") !== -1;
+      }
+
+      module.exports = _isNativeFunction;
+
+      /***/
+    },
+
     /***/ yXPU: /***/ function(module, exports) {
       function asyncGeneratorStep(
         gen,
Diff for main-HASH.js 
@@ -66,31 +66,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       /***/
     },
 
-    /***/ "7W2i": /***/ function(module, exports, __webpack_require__) {
-      var setPrototypeOf = __webpack_require__("SksO");
-
-      function _inherits(subClass, superClass) {
-        if (typeof superClass !== "function" && superClass !== null) {
-          throw new TypeError(
-            "Super expression must either be null or a function"
-          );
-        }
-
-        subClass.prototype = Object.create(superClass && superClass.prototype, {
-          constructor: {
-            value: subClass,
-            writable: true,
-            configurable: true
-          }
-        });
-        if (superClass) setPrototypeOf(subClass, superClass);
-      }
-
-      module.exports = _inherits;
-
-      /***/
-    },
-
     /***/ "85TV": /***/ function(module, exports, __webpack_require__) {
       "use strict";
 
@@ -1626,58 +1601,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       /***/
     },
 
-    /***/ Nsbk: /***/ function(module, exports) {
-      function _getPrototypeOf(o) {
-        module.exports = _getPrototypeOf = Object.setPrototypeOf
-          ? Object.getPrototypeOf
-          : function _getPrototypeOf(o) {
-              return o.__proto__ || Object.getPrototypeOf(o);
-            };
-        return _getPrototypeOf(o);
-      }
-
-      module.exports = _getPrototypeOf;
-
-      /***/
-    },
-
-    /***/ PJYZ: /***/ function(module, exports) {
-      function _assertThisInitialized(self) {
-        if (self === void 0) {
-          throw new ReferenceError(
-            "this hasn't been initialised - super() hasn't been called"
-          );
-        }
-
-        return self;
-      }
-
-      module.exports = _assertThisInitialized;
-
-      /***/
-    },
-
-    /***/ a1gu: /***/ function(module, exports, __webpack_require__) {
-      var _typeof = __webpack_require__("cDf5");
-
-      var assertThisInitialized = __webpack_require__("PJYZ");
-
-      function _possibleConstructorReturn(self, call) {
-        if (
-          call &&
-          (_typeof(call) === "object" || typeof call === "function")
-        ) {
-          return call;
-        }
-
-        return assertThisInitialized(self);
-      }
-
-      module.exports = _possibleConstructorReturn;
-
-      /***/
-    },
-
     /***/ bGXG: /***/ function(module, exports, __webpack_require__) {
       "use strict";
Diff for index.html 
@@ -19,15 +19,15 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d017463fb5e8dac69eef.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.1e571610c8696483c15b.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-278485438f7230b5c19b.js"
+      src="/_next/static/chunks/main-2eafb559c94411cd2384.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-53849e6e875286384e86.js"
+      src="/_next/static/chunks/pages/_app-fa06ed5d4deda6b647a1.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,15 +19,15 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d017463fb5e8dac69eef.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.1e571610c8696483c15b.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-278485438f7230b5c19b.js"
+      src="/_next/static/chunks/main-2eafb559c94411cd2384.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-53849e6e875286384e86.js"
+      src="/_next/static/chunks/pages/_app-fa06ed5d4deda6b647a1.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,15 +19,15 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d017463fb5e8dac69eef.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.1e571610c8696483c15b.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-278485438f7230b5c19b.js"
+      src="/_next/static/chunks/main-2eafb559c94411cd2384.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-53849e6e875286384e86.js"
+      src="/_next/static/chunks/pages/_app-fa06ed5d4deda6b647a1.js"
       defer=""
     ></script>
     <script
Commit: c23290c

@timneutkens timneutkens merged commit 402f036 into vercel:canary Jul 5, 2021
@timneutkens timneutkens deleted the refactor-decode-error branch July 5, 2021 16:31
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@devknoll
Refactor decode failures (vercel#26899)
cfa27ad
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devknoll @ijjk @timneutkens