Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error message during create-next-app #26980

Merged
merged 4 commits into from
Jul 7, 2021
Merged

fix error message during create-next-app #26980

merged 4 commits into from
Jul 7, 2021

Conversation

anindya-dey
Copy link
Contributor

Fixes issue #19588

Here's a screenshot of the error message:
image

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jul 7, 2021
timneutkens
timneutkens approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jul 7, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
buildDuration 14.3s 14.4s ⚠️ +145ms
buildDurationCached 3.6s 3.6s -68ms
nodeModulesSize 49.3 MB 49.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.4 2.4 ✓
/ avg req/sec 1041.85 1041.65 ⚠️ -0.2
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.393 1.435 ⚠️ +0.04
/error-in-render avg req/sec 1794.9 1742.21 ⚠️ -52.69
Client Bundles (main, webpack, commons)
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
359.HASH.js gzip 3.09 kB 3.09 kB ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.6 kB 20.6 kB ✓
webpack-HASH.js gzip 1.49 kB 1.49 kB ✓
Overall change 67.2 kB 67.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
_app-HASH.js gzip 803 B 803 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 329 B 329 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.42 kB 8.42 kB ✓
Client Build Manifests
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
index.html gzip 523 B 523 B ✓
link.html gzip 536 B 536 B ✓
withRouter.html gzip 515 B 515 B ✓
Overall change 1.57 kB 1.57 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
buildDuration 11.9s 12s ⚠️ +97ms
buildDurationCached 4.8s 4.8s -99ms
nodeModulesSize 49.3 MB 49.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.336 2.36 ⚠️ +0.02
/ avg req/sec 1070.2 1059.18 ⚠️ -11.02
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.315 1.347 ⚠️ +0.03
/error-in-render avg req/sec 1900.95 1855.31 ⚠️ -45.64
Client Bundles (main, webpack, commons)
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
14.HASH.js gzip 3.11 kB 3.11 kB ✓
677f882d2ed8..HASH.js gzip 13.9 kB 13.9 kB ✓
framework.HASH.js gzip 41.8 kB 41.8 kB ✓
main-HASH.js gzip 7.81 kB 7.81 kB ✓
webpack-HASH.js gzip 1.19 kB 1.19 kB ✓
Overall change 67.8 kB 67.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
_app-HASH.js gzip 791 B 791 B ✓
_error-HASH.js gzip 3.83 kB 3.83 kB ✓
amp-HASH.js gzip 531 B 531 B ✓
css-HASH.js gzip 333 B 333 B ✓
hooks-HASH.js gzip 910 B 910 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 295 B 295 B ✓
withRouter-HASH.js gzip 292 B 292 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 8.98 kB 8.98 kB ✓
Client Build Manifests
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
_buildManifest.js gzip 418 B 418 B ✓
Overall change 418 B 418 B ✓
Rendered Page Sizes
vercel/next.js canary andys-github/next.js fix/create-next-app-error-19588 Change
index.html gzip 567 B 567 B ✓
link.html gzip 580 B 580 B ✓
withRouter.html gzip 559 B 559 B ✓
Overall change 1.71 kB 1.71 kB ✓
Commit: 86c2975

@kodiakhq kodiakhq bot merged commit caca389 into vercel:canary Jul 7, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@anindya-dey
fix error message during create-next-app (vercel#26980)
a91c958 
Fixes [issue vercel#19588](vercel#19588)

Here's a screenshot of the error message:
![image](https://user-images.githubusercontent.com/30517208/124733436-d1babd80-df31-11eb-96e4-513505ba07a0.png)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message when using create-next-app
3 participants
@anindya-dey @ijjk @timneutkens