Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint] Adds --format flag to next lint #27052

Merged
merged 2 commits into from
Jul 24, 2021
Merged

[ESLint] Adds --format flag to next lint #27052

merged 2 commits into from
Jul 24, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

Adds --format support to next lint to allow defining of additional formatters. Fixes #26387.

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Jul 9, 2021
@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ijjk
Copy link
Member

ijjk commented Jul 24, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
buildDuration 12.8s 12.8s -7ms
buildDurationCached 3s 2.9s -38ms
nodeModulesSize 49.5 MB 49.5 MB ⚠️ +2.62 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
/ failed reqs 0 0
/ total time (seconds) 2.146 2.165 ⚠️ +0.02
/ avg req/sec 1164.71 1154.91 ⚠️ -9.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.175 1.194 ⚠️ +0.02
/error-in-render avg req/sec 2127.51 2093.71 ⚠️ -33.8
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
359.HASH.js gzip 2.96 kB 2.96 kB
745.HASH.js gzip 180 B 180 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 21 kB 21 kB
webpack-HASH.js gzip 1.53 kB 1.53 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 2.28 kB 2.28 kB
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.63 kB 5.63 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.1 kB 19.1 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
_buildManifest.js gzip 489 B 489 B
Overall change 489 B 489 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
buildDuration 10.3s 10.2s -109ms
buildDurationCached 4s 3.9s -54ms
nodeModulesSize 49.5 MB 49.5 MB ⚠️ +2.62 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
/ failed reqs 0 0
/ total time (seconds) 2.163 2.195 ⚠️ +0.03
/ avg req/sec 1155.85 1139.1 ⚠️ -16.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.19 1.199 ⚠️ +0.01
/error-in-render avg req/sec 2101.58 2084.93 ⚠️ -16.65
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
17.HASH.js gzip 2.98 kB 2.98 kB
18.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.8 kB 13.8 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 8.4 kB 8.4 kB
webpack-HASH.js gzip 1.22 kB 1.22 kB
Overall change 68.5 kB 68.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.02 kB 3.02 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.6 kB 17.6 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js feature-request/26387 Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: 90fb3d2

@kodiakhq kodiakhq bot merged commit 078cfb5 into vercel:canary Jul 24, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
Adds `--format` support to `next lint` to allow defining of additional formatters. Fixes vercel#26387.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants