Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to fallbackSend when send is false #27113

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

timneutkens
Copy link
Member

Send can result in false when it did not send the result so we have to fall back in that case. Shared by @Timer after my PR was landed.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

send can result in `false` when it did not send the result so we have to fall back in that case. Shared by @Timer after my PR was landed.
@ijjk
Copy link
Member

ijjk commented Jul 12, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
buildDuration 12.9s 12.8s -153ms
buildDurationCached 3s 3s -17ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +51 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
/ failed reqs 0 0
/ total time (seconds) 2.094 2.113 ⚠️ +0.02
/ avg req/sec 1194.04 1183.21 ⚠️ -10.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.175 1.187 ⚠️ +0.01
/error-in-render avg req/sec 2128.46 2105.3 ⚠️ -23.16
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
359.HASH.js gzip 3.09 kB 3.09 kB
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 20.6 kB 20.6 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.18 kB 3.18 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 329 B 329 B
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.69 kB 5.69 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
_buildManifest.js gzip 419 B 419 B
Overall change 419 B 419 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
buildDuration 10.3s 10.2s -103ms
buildDurationCached 4.1s 4.1s -24ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +51 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
/ failed reqs 0 0
/ total time (seconds) 2.089 2.087 0
/ avg req/sec 1196.49 1198.18 +1.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.178 1.15 -0.03
/error-in-render avg req/sec 2122.29 2174.25 +51.96
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
14.HASH.js gzip 3.11 kB 3.11 kB
677f882d2ed8..HASH.js gzip 13.9 kB 13.9 kB
framework.HASH.js gzip 41.8 kB 41.8 kB
main-HASH.js gzip 7.81 kB 7.81 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.83 kB 3.83 kB
amp-HASH.js gzip 531 B 531 B
css-HASH.js gzip 333 B 333 B
hooks-HASH.js gzip 910 B 910 B
index-HASH.js gzip 230 B 230 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 297 B 297 B
withRouter-HASH.js gzip 293 B 293 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 8.98 kB 8.98 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
_buildManifest.js gzip 418 B 418 B
Overall change 418 B 418 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/behavior-change-sendbeacon Change
index.html gzip 576 B 576 B
link.html gzip 587 B 587 B
withRouter.html gzip 570 B 568 B -2 B
Overall change 1.73 kB 1.73 kB -2 B

Diffs

Diff for index.html
@@ -23,7 +23,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a89c0cf085ce34d3395c.js"
+      src="/_next/static/chunks/main-2ce5c225c6923ef08150.js"
       defer=""
     ></script>
     <script
Diff for link.html
@@ -23,7 +23,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a89c0cf085ce34d3395c.js"
+      src="/_next/static/chunks/main-2ce5c225c6923ef08150.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html
@@ -23,7 +23,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a89c0cf085ce34d3395c.js"
+      src="/_next/static/chunks/main-2ce5c225c6923ef08150.js"
       defer=""
     ></script>
     <script
Commit: 3b38ef1

@kodiakhq kodiakhq bot merged commit 92d5fc4 into vercel:canary Jul 12, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
Send can result in `false` when it did not send the result so we have to fall back in that case. Shared by @Timer after my PR was landed.



## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants