upgrade to webpack 5.47.0 and webpack-sources 3.1.1 #27538

sokra · 2021-07-27T16:51:33Z

improve source-map performance
improve watch performance
bugfixes
improvements to Data URIs

ijjk · 2021-07-29T14:50:58Z

Failing test suites

Commit: 46ca113

test/acceptance/ReactRefreshLogBox.dev.test.js

server-side only compilation errors

Expand output

● server-side only compilation errors

ScriptTimeoutError: script timeout
  (Session info: headless chrome=92.0.4515.107)

  72 |
  73 |             // Wait for application to re-hydrate:
> 74 |             await browser.executeAsyncScript(function () {
     |             ^
  75 |               var callback = arguments[arguments.length - 1]
  76 |               if (window.__NEXT_HYDRATED) {
  77 |                 callback()

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
      at runMicrotasks (<anonymous>)
  at Proxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.patch (acceptance/helpers.js:74:13)
  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:1415:3)

ijjk · 2021-07-29T15:48:18Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
buildDuration	17.8s	17.9s	⚠️ +60ms
buildDurationCached	4s	4s	-5ms
nodeModulesSize	50.3 MB	50.3 MB	⚠️ +3.51 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.094	3.091	0
/ avg req/sec	808.07	808.8	+0.73
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.967	1.944	-0.02
/error-in-render avg req/sec	1271.28	1285.92	+14.64

Client Bundles (main, webpack, commons) Overall decrease ✓

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
745.HASH.js gzip	180 B	179 B	-1 B
framework-HASH.js gzip	42.2 kB	42.2 kB	-15 B
main-HASH.js gzip	22.8 kB	22.8 kB	✓
webpack-HASH.js gzip	1.49 kB	1.5 kB	⚠️ +6 B
Overall change	66.8 kB	66.7 kB	-10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
_app-HASH.js gzip	980 B	980 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.52 kB	2.52 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
image-HASH.js gzip	4.1 kB	4.1 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	319 B	319 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	12.8 kB	12.8 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
_buildManifest.js gzip	490 B	490 B	✓
Overall change	490 B	490 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
index.html gzip	531 B	532 B	⚠️ +1 B
link.html gzip	544 B	544 B	✓
withRouter.html gzip	524 B	525 B	⚠️ +1 B
Overall change	1.6 kB	1.6 kB	⚠️ +2 B

Diffs

Diff for _buildManifest.js

@@ -1,33 +1,33 @@
 self.__BUILD_MANIFEST = {
   __rewrites: { beforeFiles: [], afterFiles: [], fallback: [] },
-  "/": ["static\u002Fchunks\u002Fpages\u002Findex-191cfefb947010b4d318.js"],
+  "/": ["static\u002Fchunks\u002Fpages\u002Findex-952afde7a0f218c22632.js"],
   "/_error": [
-    "static\u002Fchunks\u002Fpages\u002F_error-2ec7da50c56ba9de12f1.js"
+    "static\u002Fchunks\u002Fpages\u002F_error-aca5c6cfba3e93349d16.js"
   ],
-  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-6a70b3d996818f416ae4.js"],
+  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-f1231d3934d9bf52872b.js"],
   "/css": [
     "static\u002Fcss\u002F59de118426c393f58653.css",
-    "static\u002Fchunks\u002Fpages\u002Fcss-fc196f2ef04da4c7630f.js"
+    "static\u002Fchunks\u002Fpages\u002Fcss-979928a4957344dd4cfa.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-0a62768e1cc2caf27342.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-3ae32efdc092678bfdaf.js"
   ],
-  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-420e11b736e2c6ac6d20.js"],
+  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-b93e7fccd3af1c72154e.js"],
   "/hooks": [
-    "static\u002Fchunks\u002Fpages\u002Fhooks-4e38b05900fed34fcf34.js"
+    "static\u002Fchunks\u002Fpages\u002Fhooks-5bd5f4a70a656f6678c4.js"
   ],
   "/image": [
-    "static\u002Fchunks\u002Fpages\u002Fimage-d9b962e16c4943c7be00.js"
+    "static\u002Fchunks\u002Fpages\u002Fimage-7d84b07022170030c8da.js"
   ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-b0be5b4e4799da3b6efb.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-7a3c1e637e71f2a0e489.js"],
   "/routerDirect": [
-    "static\u002Fchunks\u002Fpages\u002FrouterDirect-7d3bf8d007854c164077.js"
+    "static\u002Fchunks\u002Fpages\u002FrouterDirect-e5f4a33d4c04b51b13bc.js"
   ],
   "/script": [
-    "static\u002Fchunks\u002Fpages\u002Fscript-0275a2eb71e5b946f7b8.js"
+    "static\u002Fchunks\u002Fpages\u002Fscript-6063d846e7c81e39bc0b.js"
   ],
   "/withRouter": [
-    "static\u002Fchunks\u002Fpages\u002FwithRouter-b58b4981ae5d42ed0ef1.js"
+    "static\u002Fchunks\u002Fpages\u002FwithRouter-e26df01cd54dcbb5c15c.js"
   ],
   sortedPages: [
     "\u002F",

Diff for _app-HASH.js

@@ -229,9 +229,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for _error-HASH.js

@@ -18,9 +18,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for amp-HASH.js

@@ -60,9 +60,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for css-HASH.js

@@ -56,9 +56,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for dynamic-HASH.js

@@ -730,9 +730,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for head-HASH.js

@@ -80,9 +80,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for hooks-HASH.js

@@ -151,9 +151,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for image-HASH.js

@@ -1033,9 +1033,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for index-HASH.js

@@ -42,9 +42,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for link-HASH.js

@@ -471,9 +471,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for routerDirect-HASH.js

@@ -66,9 +66,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for script-HASH.js

@@ -79,9 +79,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for withRouter-HASH.js

@@ -63,9 +63,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for 745.HASH.js

@@ -1,3 +1,4 @@
+"use strict";
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [745],
   {
@@ -6,7 +7,6 @@
       __webpack_exports__,
       __webpack_require__
     ) {
-      "use strict";
       __webpack_require__.r(__webpack_exports__);
       /* harmony export */ __webpack_require__.d(__webpack_exports__, {
         /* harmony export */ Hello: function() {

Diff for framework-HASH.js

@@ -1,3 +1,4 @@
+"use strict";
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [774],
   {
@@ -6,7 +7,6 @@
       exports,
       __webpack_require__
     ) {
-      "use strict";
       /** @license React v17.0.2
        * react-dom.production.min.js
        *
@@ -7851,8 +7851,6 @@
       __unused_webpack_exports,
       __webpack_require__
     ) {
-      "use strict";
-
       function checkDCE() {
         /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
         if (
@@ -7889,7 +7887,6 @@
       exports,
       __webpack_require__
     ) {
-      "use strict";
       /** @license React v17.0.2
        * react-jsx-runtime.production.min.js
        *
@@ -7943,7 +7940,6 @@
       exports,
       __webpack_require__
     ) {
-      "use strict";
       /** @license React v17.0.2
        * react.production.min.js
        *
@@ -8335,8 +8331,6 @@
       __unused_webpack_exports,
       __webpack_require__
     ) {
-      "use strict";
-
       if (true) {
         module.exports = __webpack_require__(2408);
       } else {
@@ -8350,8 +8344,6 @@
       __unused_webpack_exports,
       __webpack_require__
     ) {
-      "use strict";
-
       if (true) {
         module.exports = __webpack_require__(5251);
       } else {
@@ -8361,7 +8353,6 @@
     },
 
     /***/ 53: /***/ function(__unused_webpack_module, exports) {
-      "use strict";
       /** @license React v0.20.2
        * scheduler.production.min.js
        *
@@ -8692,8 +8683,6 @@
       __unused_webpack_exports,
       __webpack_require__
     ) {
-      "use strict";
-
       if (true) {
         module.exports = __webpack_require__(53);
       } else {
@@ -8707,7 +8696,6 @@
       exports,
       __webpack_require__
     ) {
-      "use strict";
       /** @license React vundefined
        * use-subscription.production.min.js
        *
@@ -8765,8 +8753,6 @@
       __unused_webpack_exports,
       __webpack_require__
     ) {
-      "use strict";
-
       if (true) {
         module.exports = __webpack_require__(8217);
       } else {

Diff for main-HASH.js

@@ -8304,9 +8304,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for polyfills-HASH.js

@@ -6564,9 +6564,6 @@
   },
   /******/ function(__webpack_require__) {
     // webpackRuntimeModules
-    /******/ // runtime can't be in strict mode because a global variable is assign and maybe created.
-    /******/
-
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };

Diff for webpack-HASH.js

@@ -84,7 +84,8 @@
         }
         /******/ if (fulfilled) {
           /******/ deferred.splice(i--, 1);
-          /******/ result = fn();
+          /******/ var r = fn();
+          /******/ if (r !== undefined) result = r;
           /******/
         }
         /******/
@@ -158,7 +159,7 @@
     /******/ __webpack_require__.u = function(chunkId) {
       /******/ // return url for filenames based on template
       /******/ return (
-        "static/chunks/" + chunkId + "." + "a978574eef356190245c" + ".js"
+        "static/chunks/" + chunkId + "." + "284331703de33c30eb1c" + ".js"
       );
       /******/
     };

Diff for index.html

@@ -8,26 +8,26 @@
     <script
       defer=""
       nomodule=""
-      src="/_next/static/chunks/polyfills-78af6fe89161f65f5762.js"
+      src="/_next/static/chunks/polyfills-e87f09c84badadba76ef.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-4609ee7a400147b48b49.js"
+      src="/_next/static/chunks/webpack-031adeaf444149491045.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/framework-63079460d625b60059fb.js"
+      src="/_next/static/chunks/framework-04992f11eed687ecc749.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-e084476412734136157a.js"
+      src="/_next/static/chunks/main-0a8deb1989138e8967f3.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-2dc318d7b821337b3866.js"
+      src="/_next/static/chunks/pages/_app-a7ea37c9b5d16fd0901b.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/index-191cfefb947010b4d318.js"
+      src="/_next/static/chunks/pages/index-952afde7a0f218c22632.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>

Diff for link.html

@@ -8,26 +8,26 @@
     <script
       defer=""
       nomodule=""
-      src="/_next/static/chunks/polyfills-78af6fe89161f65f5762.js"
+      src="/_next/static/chunks/polyfills-e87f09c84badadba76ef.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-4609ee7a400147b48b49.js"
+      src="/_next/static/chunks/webpack-031adeaf444149491045.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/framework-63079460d625b60059fb.js"
+      src="/_next/static/chunks/framework-04992f11eed687ecc749.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-e084476412734136157a.js"
+      src="/_next/static/chunks/main-0a8deb1989138e8967f3.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-2dc318d7b821337b3866.js"
+      src="/_next/static/chunks/pages/_app-a7ea37c9b5d16fd0901b.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-b0be5b4e4799da3b6efb.js"
+      src="/_next/static/chunks/pages/link-7a3c1e637e71f2a0e489.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>

Diff for withRouter.html

@@ -8,26 +8,26 @@
     <script
       defer=""
       nomodule=""
-      src="/_next/static/chunks/polyfills-78af6fe89161f65f5762.js"
+      src="/_next/static/chunks/polyfills-e87f09c84badadba76ef.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-4609ee7a400147b48b49.js"
+      src="/_next/static/chunks/webpack-031adeaf444149491045.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/framework-63079460d625b60059fb.js"
+      src="/_next/static/chunks/framework-04992f11eed687ecc749.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-e084476412734136157a.js"
+      src="/_next/static/chunks/main-0a8deb1989138e8967f3.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-2dc318d7b821337b3866.js"
+      src="/_next/static/chunks/pages/_app-a7ea37c9b5d16fd0901b.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/withRouter-b58b4981ae5d42ed0ef1.js"
+      src="/_next/static/chunks/pages/withRouter-e26df01cd54dcbb5c15c.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
buildDuration	14.3s	13.9s	-441ms
buildDurationCached	5.5s	5.4s	-150ms
nodeModulesSize	50.3 MB	50.3 MB	⚠️ +3.51 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.184	3.153	-0.03
/ avg req/sec	785.16	792.87	+7.71
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.96	1.997	⚠️ +0.04
/error-in-render avg req/sec	1275.74	1251.94	⚠️ -23.8

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
17.HASH.js gzip	185 B	185 B	✓
677f882d2ed8..HASH.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.6 kB	10.6 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	67.7 kB	67.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
_app-HASH.js gzip	965 B	965 B	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	2.97 kB	2.97 kB	✓
hooks-HASH.js gzip	911 B	911 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	2.94 kB	2.94 kB	✓
withRouter-HASH.js gzip	294 B	294 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	17.7 kB	17.7 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
_buildManifest.js gzip	499 B	499 B	✓
Overall change	499 B	499 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js webpack/upgrade	Change
index.html gzip	577 B	577 B	✓
link.html gzip	589 B	589 B	✓
withRouter.html gzip	569 B	569 B	✓
Overall change	1.74 kB	1.74 kB	✓

Commit: 77b2628

* improve source-map performance * improve watch performance * bugfixes * improvements to Data URIs

sokra requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners July 27, 2021 16:51

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jul 27, 2021

sokra force-pushed the webpack/upgrade branch from cf53002 to 9a97beb Compare July 27, 2021 17:28