docs(material-ui): move the source code to Material-UI repository #2808
Conversation
|
@timneutkens Thanks |
|
Why 🤔 this is very weird to me. |
|
@albinekb We are still in beta, things are moving. It's simpler for us to keep it up to date this way. |
* Add examples/with-redux-code-splitting. (#2721) * #1757 Relay Modern Example (#2696) * Add ReasonML example (#2640) * Add ReasonML example * Add a gitignore specifically for the reasonml example * Allow custom className for <Main /> (#2802) * 3.0.2 * Remove beta information from the README. * 3.0.3 * Remove unnecessary lookup in example with emotion (#2731) * Document SCSS/Less (#2742) * Document SCSS/Less * Add missing word * Add docs for examples dir * Add extra example * uppercase J * Add with pkg example (#2751) * Add custom server micro example (#2750) * Ease running multiple examples at the same time with process.env.PORT (#2753) * Add line-height rule for error page h2 (#2761) * Add support for fetching multiple translation files (#2743) * Add support for fetching multiple translation files * Cleanup * Clear missed interval (#2611) * clear missed interval * remove trailing whitespace * Relay Modern Example (#1757) (#2773) * Simplification of Relay Modern Example (#1757) (#2776) * Use deterministic names for dynamic import (#2788) * Always use the same name for the same dynamic import. * Add unit tests for the modulePath generation. * Allow tests to run correctly on Windows. * Make the chunk name a bit pretty. * Fix tests to run on Windows. * 3.0.4 * Revert "Make the chunk name a bit pretty." (#2792) This reverts commit 0c9e8cf. * 3.0.5 * Use _ as the divider for dynamic import name splitter. (#2793) Using - gives us some weird webpack errors. * 3.0.6 * next/dynamic Error Message Tweaks (#2798) * Fixed issue (#2804) #2800 * docs(material-ui): move the source code to Material-UI repository (#2808)
|
Wouldn't adding a brief description and a link to the new home for this code in the example's readme be important since this is essentially leaving the nextjs example completely gutted - with no reason as to why? |
|
@ebrearley I don't follow, it's documented here https://github.com/zeit/next.js/tree/master/examples/with-material-ui-next added in this PR |
|
@timneutkens No, not really. The example readme mentions that the material-ui library is undergoing a rewrite from scratch with the As somebody who looks through the example's code (which I think is the beauty of the examples) in GitHub, I found this example rather odd because there is now no actual example code. Cloning the example into a new directory on my machine is a lot of overhead if I just want to see how the example looks. I just think that readme should contain a link to where the code now lives, with a short sentence saying something like:
|
|
@timneutkens Looks all good on my end. |
|
Last sentence is: > |
No description provided.