Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internationalized dynamic routing example #28792

Closed
wants to merge 4 commits into from
Closed

Add internationalized dynamic routing example #28792

wants to merge 4 commits into from

Conversation

jferrettiboke
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the examples Issue/PR related to examples label Sep 4, 2021
@jferrettiboke
Copy link
Contributor Author

@leerob Would you mind to review this PR? 🙂

@kimgiutae
Copy link

Related issues #31280, #18485, #31299, #18572 and #31178

ijjk
ijjk reviewed May 23, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm not sure this example adds much more than the existing i18n-routing example which does show dynamic routing here https://github.com/vercel/next.js/blob/canary/examples/i18n-routing/pages/gsp/%5Bslug%5D.js

If there's anything we can expand on that example would be glad to accept updates to the existing one, thanks for the PR though!

@ijjk ijjk closed this May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk left review comments

@kristijorgji kristijorgji kristijorgji approved these changes

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jferrettiboke @kimgiutae @kristijorgji @ijjk