Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc #30404

Merged
merged 4 commits into from
Oct 27, 2021
Merged

Update swc #30404

merged 4 commits into from
Oct 27, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 27, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

This includes

There is a minor regression in the minifier due to added aliasing check.

(I manually selected crates to update)

This is regression due to aliasing check.
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 27, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-ver-fix Change
buildDuration 20.7s 20.7s ⚠️ +88ms
buildDurationCached 4.2s 4.2s ⚠️ +32ms
nodeModulesSize 207 MB 207 MB -162 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-ver-fix Change
/ failed reqs 0 0
/ total time (seconds) 3.367 3.423 ⚠️ +0.06
/ avg req/sec 742.4 730.26 ⚠️ -12.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.552 1.592 ⚠️ +0.04
/error-in-render avg req/sec 1611.21 1570.59 ⚠️ -40.62
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-fix Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-fix Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-fix Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-fix Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-fix Change
index.html gzip 535 B 535 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-ver-fix Change
buildDuration 17.4s 17s -328ms
buildDurationCached 4s 4.1s ⚠️ +68ms
nodeModulesSize 207 MB 207 MB -162 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-ver-fix Change
/ failed reqs 0 0
/ total time (seconds) 3.375 3.575 ⚠️ +0.2
/ avg req/sec 740.81 699.33 ⚠️ -41.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.549 1.695 ⚠️ +0.15
/error-in-render avg req/sec 1613.96 1475.31 ⚠️ -138.65
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-ver-fix Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB -2 B
main-HASH.js gzip 28.2 kB 28.2 kB -1 B
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72 kB 72 kB -3 B
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-fix Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-fix Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-fix Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-ver-fix Change
index.html gzip 535 B 534 B -1 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 528 B -1 B
Overall change 1.61 kB 1.61 kB -2 B
Commit: 3e44efd

@kodiakhq kodiakhq bot merged commit 979e9bd into vercel:canary Oct 27, 2021
@kdy1 kdy1 deleted the swc-ver-fix branch October 28, 2021 04:48
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@kdy1 kdy1 self-assigned this Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants