Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax warning for next/image parent element #30453

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 27, 2021

This warning was incorrectly displaying for the "background" use case demonstrated here: https://image-component.nextjs.gallery/background

@ijjk
Copy link
Member

ijjk commented Oct 27, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
buildDuration 25.5s 25.8s ⚠️ +317ms
buildDurationCached 5s 5s ⚠️ +92ms
nodeModulesSize 207 MB 207 MB ⚠️ +63 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
/ failed reqs 0 0
/ total time (seconds) 4.505 4.433 -0.07
/ avg req/sec 554.89 564 +9.11
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.297 2.211 -0.09
/error-in-render avg req/sec 1088.21 1130.7 +42.49
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
buildDuration 21.1s 21.4s ⚠️ +304ms
buildDurationCached 5s 4.9s -135ms
nodeModulesSize 207 MB 207 MB ⚠️ +63 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
/ failed reqs 0 0
/ total time (seconds) 4.502 4.362 -0.14
/ avg req/sec 555.25 573.13 +17.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.215 2.311 ⚠️ +0.1
/error-in-render avg req/sec 1128.85 1081.85 ⚠️ -47
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-warning-next-image-parent Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: e012cc0

@kodiakhq kodiakhq bot merged commit 3292713 into canary Oct 27, 2021
@kodiakhq kodiakhq bot deleted the fix-warning-next-image-parent branch October 27, 2021 16:43
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants