Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc to fix minifier issue #30540

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Update swc to fix minifier issue #30540

merged 2 commits into from
Oct 28, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 28, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

This patch includes

@ijjk
Copy link
Member

ijjk commented Oct 28, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-ver-17 Change
buildDuration 22.2s 21.4s -810ms
buildDurationCached 4.4s 4.5s ⚠️ +111ms
nodeModulesSize 198 MB 198 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-ver-17 Change
/ failed reqs 0 0
/ total time (seconds) 3.849 3.76 -0.09
/ avg req/sec 649.49 664.91 +15.42
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.239 2.114 -0.12
/error-in-render avg req/sec 1116.53 1182.52 +65.99
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-17 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-17 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-17 Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-17 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-17 Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-ver-17 Change
buildDuration 18.9s 18.9s ⚠️ +32ms
buildDurationCached 4.3s 4.3s -28ms
nodeModulesSize 198 MB 198 MB ⚠️ +7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-ver-17 Change
/ failed reqs 0 0
/ total time (seconds) 3.871 3.827 -0.04
/ avg req/sec 645.83 653.21 +7.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.091 2.113 ⚠️ +0.02
/error-in-render avg req/sec 1195.81 1182.91 ⚠️ -12.9
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-17 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-17 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-17 Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-17 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-17 Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 1f36515

@timneutkens timneutkens merged commit 387d656 into vercel:canary Oct 28, 2021
@timneutkens timneutkens deleted the swc-ver-17 branch October 28, 2021 11:59
sokra added a commit that referenced this pull request Oct 28, 2021
sokra added a commit that referenced this pull request Oct 28, 2021
@sokra sokra mentioned this pull request Oct 28, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@kdy1 kdy1 self-assigned this Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants