Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed grammatical errors in contributing.md #30542

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Fixed grammatical errors in contributing.md #30542

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58befa4
Fixed grammatical errors in CONTRIBUTING.md
mitheelgajare Oct 28, 2021
db955bc
Merge branch 'canary' into canary
mitheelgajare Oct 28, 2021
67be19f
Merge branch 'canary' into canary
mitheelgajare Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ To develop locally:

1. [Fork](https://help.github.com/articles/fork-a-repo/) this repository to your
own GitHub account and then
[clone](https://help.github.com/articles/cloning-a-repository/) it to your
local device.
[clone](https://help.github.com/articles/cloning-a-repository/) it to your local device.
2. Create a new branch:
```
git checkout -b MY_BRANCH_NAME
Expand Down Expand Up @@ -127,7 +126,7 @@ EXAMPLE=./test/integration/basic

There are two options to develop with your local version of the codebase:

### Set as local dependency in package.json
### Set as a local dependency in package.json

1. In your app's `package.json`, replace:

Expand Down Expand Up @@ -175,15 +174,15 @@ or

This will use the version of `next` built inside of the Next.js monorepo and the
main `yarn dev` monorepo command can be running to make changes to the local
Next.js version at the same time (some changes might require re-running `yarn next-with-deps` to take affect).
Next.js version at the same time (some changes might require re-running `yarn next-with-deps` to take effect).

## Adding warning/error descriptions

In Next.js we have a system to add helpful links to warnings and errors.

This allows for the logged message to be short while giving a broader description and instructions on how to solve the warning/error.

In general all warnings and errors added should have these links attached.
In general, all warnings and errors added should have these links attached.

Below are the steps to add a new link:

Expand Down