Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax warning for next/image loader width even more #30624

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 29, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
buildDuration 17.9s 18.6s ⚠️ +663ms
buildDurationCached 3.7s 3.7s ⚠️ +62ms
nodeModulesSize 199 MB 199 MB ⚠️ +114 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
/ failed reqs 0 0
/ total time (seconds) 3.2 3.258 ⚠️ +0.06
/ avg req/sec 781.28 767.25 ⚠️ -14.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.384 1.583 ⚠️ +0.2
/error-in-render avg req/sec 1806.94 1578.84 ⚠️ -228.1
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Diffs

Diff for _buildManifest.js
@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-ff60bc61acd2698b.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-b7c6bb576d555267.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-8d363275c955437c.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fa969765a079642e.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-76232dd6bc335a24.js"
Diff for image-HASH.js
@@ -490,7 +490,7 @@
           isLazy = false;
         }
         if (false) {
-          var url, rand, VALID_BLUR_EXT;
+          var url, urlStr, VALID_BLUR_EXT;
         }
         var ref2 = _slicedToArray(
             (0, _useIntersection).useIntersection({

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
buildDuration 16s 15.3s -711ms
buildDurationCached 3.7s 3.7s ⚠️ +20ms
nodeModulesSize 199 MB 199 MB ⚠️ +114 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
/ failed reqs 0 0
/ total time (seconds) 3.173 3.128 -0.04
/ avg req/sec 787.83 799.24 +11.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.498 1.446 -0.05
/error-in-render avg req/sec 1668.34 1729.4 +61.06
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js relax-image-loader-url-even-more Change
index.html gzip 534 B 534 B
link.html gzip 548 B 548 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Diffs

Diff for _buildManifest.js
@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-ff60bc61acd2698b.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-b7c6bb576d555267.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-8d363275c955437c.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fa969765a079642e.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-76232dd6bc335a24.js"
Diff for image-HASH.js
@@ -490,7 +490,7 @@
           isLazy = false;
         }
         if (false) {
-          var url, rand, VALID_BLUR_EXT;
+          var url, urlStr, VALID_BLUR_EXT;
         }
         var ref2 = _slicedToArray(
             (0, _useIntersection).useIntersection({
Commit: 44bc51c

@ijjk
Copy link
Member

ijjk commented Oct 29, 2021

Failing test suites

Commit: 44bc51c

test/e2e/prerender-native-module.test.ts

  • prerender native module > should render index correctly
  • prerender native module > should render /blog/first correctly
  • prerender native module > should render /blog/second correctly
  • prerender native module > should output traces
Expand output

● prerender native module › should render index correctly

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {
  12 |         pages: new FileRef(

  at e2e/prerender-native-module.test.ts:9:3
  at Object.<anonymous> (e2e/prerender-native-module.test.ts:6:1)

● prerender native module › should render /blog/first correctly

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {
  12 |         pages: new FileRef(

  at e2e/prerender-native-module.test.ts:9:3
  at Object.<anonymous> (e2e/prerender-native-module.test.ts:6:1)

● prerender native module › should render /blog/second correctly

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {
  12 |         pages: new FileRef(

  at e2e/prerender-native-module.test.ts:9:3
  at Object.<anonymous> (e2e/prerender-native-module.test.ts:6:1)

● prerender native module › should output traces

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {
  12 |         pages: new FileRef(

  at e2e/prerender-native-module.test.ts:9:3
  at Object.<anonymous> (e2e/prerender-native-module.test.ts:6:1)

● Test suite failed to run

TypeError: Cannot read property 'destroy' of undefined

  23 |     })
  24 |   })
> 25 |   afterAll(() => next.destroy())
     |                       ^
  26 |
  27 |   it('should render index correctly', async () => {
  28 |     const browser = await webdriver(next.url, '/')

  at e2e/prerender-native-module.test.ts:25:23

● Test suite failed to run

next instance not destroyed before exiting, make sure to call .destroy() after the tests after finished

  77 |     if (nextInstance) {
  78 |       await nextInstance.destroy()
> 79 |       throw new Error(
     |             ^
  80 |         `next instance not destroyed before exiting, make sure to call .destroy() after the tests after finished`
  81 |       )
  82 |     }

  at lib/e2e-utils.ts:79:13

test/integration/create-next-app/index.test.js

  • create next app > empty directory
  • create next app > should support typescript flag
Expand output

● create next app › empty directory

thrown: "Exceeded timeout of 90000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  39 |   // stdin is piped instead of inherited on windows
  40 |   if (process.platform !== 'win32') {
> 41 |     it('empty directory', async () => {
     |     ^
  42 |       await usingTempDir(async (cwd) => {
  43 |         const projectName = 'empty-directory'
  44 |         const res = await run([projectName], { cwd })

  at integration/create-next-app/index.test.js:41:5
  at Object.<anonymous> (integration/create-next-app/index.test.js:24:1)

● create next app › should support typescript flag

thrown: "Exceeded timeout of 90000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   99 |   })
  100 |
> 101 |   it('should support typescript flag', async () => {
      |   ^
  102 |     await usingTempDir(async (cwd) => {
  103 |       const projectName = 'typescript'
  104 |       const res = await run([projectName, '--typescript'], { cwd })

  at integration/create-next-app/index.test.js:101:3
  at Object.<anonymous> (integration/create-next-app/index.test.js:24:1)

This was referenced Nov 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary warnings when using custom image loader with size buckets
2 participants