Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial standalone build handling #31003

Merged
merged 6 commits into from
Nov 9, 2021
Merged

Add initial standalone build handling #31003

merged 6 commits into from
Nov 9, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 5, 2021

This adds an initial experimental config to copy traced files to a standalone folder. A minimal server.js file is also created to load and start next-server directly. The standalone folder can make debugging missing traced files easier and also make it easier to create minimal serverless/docker deployments.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 5, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review November 5, 2021 16:27
@ijjk ijjk requested a review from styfle November 5, 2021 16:27
styfle
styfle reviewed Nov 6, 2021
View reviewed changes
packages/next/build/index.ts Outdated Show resolved Hide resolved
styfle
styfle reviewed Nov 6, 2021
View reviewed changes
packages/next/build/utils.ts Outdated Show resolved Hide resolved
@ijjk
Merge branch 'canary' into add/standalone-build
1054bbf 
# Conflicts:
#	packages/next/build/index.ts
#	packages/next/build/utils.ts
@ijjk
apply suggestions
6349ba3
@ijjk ijjk requested a review from styfle November 8, 2021 16:17
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk mentioned this pull request Nov 8, 2021
Closed
styfle
styfle reviewed Nov 8, 2021
View reviewed changes
packages/next/build/utils.ts Outdated Show resolved Hide resolved
@ijjk ijjk requested a review from styfle November 8, 2021 17:23
styfle
styfle previously approved these changes Nov 8, 2021
View reviewed changes
test/unit/recursive-delete.test.ts Show resolved Hide resolved
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Nov 8, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/standalone-build Change
buildDuration 17.4s 17.6s ⚠️ +126ms
buildDurationCached 3.5s 3.5s -34ms
nodeModulesSize 332 MB 332 MB ⚠️ +9.56 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/standalone-build Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.023 2.871 -0.15
/ avg req/sec 826.97 870.66 +43.69
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.344 1.325 -0.02
/error-in-render avg req/sec 1859.73 1886.47 +26.74
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/standalone-build Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.1 kB 28.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 71.9 kB 71.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/standalone-build Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/standalone-build Change
_app-HASH.js gzip 1.23 kB 1.23 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/standalone-build Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/standalone-build Change
index.html gzip 523 B 523 B ✓
link.html gzip 536 B 536 B ✓
withRouter.html gzip 518 B 518 B ✓
Overall change 1.58 kB 1.58 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/standalone-build Change
buildDuration 19s 19.2s ⚠️ +233ms
buildDurationCached 3.6s 3.5s -69ms
nodeModulesSize 332 MB 332 MB ⚠️ +9.56 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/standalone-build Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.827 3.009 ⚠️ +0.18
/ avg req/sec 884.43 830.78 ⚠️ -53.65
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.343 1.364 ⚠️ +0.02
/error-in-render avg req/sec 1861.6 1832.2 ⚠️ -29.4
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/standalone-build Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/standalone-build Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/standalone-build Change
_app-HASH.js gzip 1.22 kB 1.22 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/standalone-build Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/standalone-build Change
index.html gzip 523 B 523 B ✓
link.html gzip 535 B 535 B ✓
withRouter.html gzip 517 B 517 B ✓
Overall change 1.57 kB 1.57 kB ✓
Commit: 79c1b3b

@ijjk ijjk merged commit eb7b401 into vercel:canary Nov 9, 2021
@ijjk ijjk deleted the add/standalone-build branch November 9, 2021 17:03
@ijjk ijjk mentioned this pull request Dec 7, 2021
Merged
1 task
kodiakhq bot pushed a commit that referenced this pull request Dec 7, 2021
@ijjk
Add docs for leveraging outputStandalone config (#32255)
1a6a1e5 
This adds documentation to explain how the `outputStandalone` config can be leveraged to reduce production deployment size and leverage the output file traces.  This also adds a note for the `outputFileTracingRoot` config as it may be needed in some monorepo setups. 

A follow-up PR will update our Docker example to leverage this config as well. 

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`

x-ref: #31003
x-ref: #32252
Closes: #30822
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @styfle