Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade webpack #31034

Merged
merged 5 commits into from
Nov 9, 2021
Merged

upgrade webpack #31034

merged 5 commits into from
Nov 9, 2021

Conversation

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@sokra sokra marked this pull request as draft November 5, 2021 16:23
@sokra sokra marked this pull request as ready for review November 8, 2021 09:13
@sokra sokra marked this pull request as draft November 8, 2021 09:13
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@sokra sokra marked this pull request as ready for review November 9, 2021 05:29
@ijjk

This comment has been minimized.

huozhi
huozhi previously approved these changes Nov 9, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

timneutkens
timneutkens previously approved these changes Nov 9, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

huozhi
huozhi previously approved these changes Nov 9, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 9, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 24.9s 25.4s ⚠️ +455ms
buildDurationCached 4.9s 4.5s -317ms
nodeModulesSize 333 MB 333 MB ⚠️ +8.02 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0
/ total time (seconds) 4.23 4.257 ⚠️ +0.03
/ avg req/sec 590.97 587.27 ⚠️ -3.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.267 2.386 ⚠️ +0.12
/error-in-render avg req/sec 1102.73 1047.99 ⚠️ -54.74
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 518 B 518 B
Overall change 1.58 kB 1.58 kB

Diffs

Diff for index.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-10789f4ca49986c9.js"
+      src="/_next/static/chunks/main-9e063f895458b590.js"
       defer=""
     ></script>
     <script
Diff for link.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-10789f4ca49986c9.js"
+      src="/_next/static/chunks/main-9e063f895458b590.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-10789f4ca49986c9.js"
+      src="/_next/static/chunks/main-9e063f895458b590.js"
       defer=""
     ></script>
     <script

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 25.7s 25.8s ⚠️ +95ms
buildDurationCached 4.7s 4.8s ⚠️ +168ms
nodeModulesSize 333 MB 333 MB ⚠️ +8.02 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0
/ total time (seconds) 4.226 4.152 -0.07
/ avg req/sec 591.54 602.08 +10.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.168 2.169 0
/error-in-render avg req/sec 1153.21 1152.39 ⚠️ -0.82
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Diffs

Diff for index.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-10789f4ca49986c9.js"
+      src="/_next/static/chunks/main-9e063f895458b590.js"
       defer=""
     ></script>
     <script
Diff for link.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-10789f4ca49986c9.js"
+      src="/_next/static/chunks/main-9e063f895458b590.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-10789f4ca49986c9.js"
+      src="/_next/static/chunks/main-9e063f895458b590.js"
       defer=""
     ></script>
     <script
Commit: ae5bd97

@huozhi huozhi merged commit 8c86428 into canary Nov 9, 2021
@huozhi huozhi deleted the webpack/upgrade branch November 9, 2021 21:34
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants