Script examples #31181
Merged
Script examples #31181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncy
requested review from
huozhi,
ijjk,
leerob,
lfades,
molebox,
padmaia,
shuding,
styfle and
timneutkens
as code owners
| @@ -7,6 +7,7 @@ description: Next.js helps you optimize loading third-party scripts with the bui | |||
| <details> | |||
| <summary><b>Examples</b></summary> | |||
| <ul> | |||
| <li><a href="https://github.com/vercel/next.js/tree/canary/examples/script-component">Script Component</a></li> | |||
There was a problem hiding this comment.
I like your idea of putting together all the different strategies into a single example! I may do the same and consolidate all the other examples into a separate, single example focused on showing different third-party providers (example: script-component-recipes)
There was a problem hiding this comment.
Thanks! If you need any help with that just let me know 🙌
housseindjirdeh
previously approved these changes
Nov 9, 2021
styfle
reviewed
Nov 9, 2021
styfle
reviewed
Nov 15, 2021
| return ( | ||
| <> | ||
| <Component {...pageProps} /> | ||
| {pathname !== "/" && ( |
There was a problem hiding this comment.
I like this pattern, great idea 👍
styfle
approved these changes
Nov 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some script component examples similar to the code showcased on the documentation