Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve stream piper on complete shell for renderToReadableStream #31186

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 8, 2021

  1. Align renderToReadableStream with renderToNodeStream, resolve promise of NodeWritablePiper only when onCompleteShell is called.
  2. update webpack to disable chunk loading for web runtime

Item 1 is the preparation for middleware-ssr-loader. Then we can do the following there

try {
   result = await renderToHTML(page)
} catch (e) {
   result = await renderToHTML(errorPage)
}
result.pipe(renderResult)

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 8, 2021
@huozhi huozhi marked this pull request as ready for review November 9, 2021 00:15
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as draft November 9, 2021 00:28
@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review November 9, 2021 10:26
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tests: now unexpected dynamic chunk load script will be treated as fatal error

This is a blocker I think, because currently import is usable (although there is an error output).

@ijjk

This comment has been minimized.

packages/next/server/render.tsx Outdated Show resolved Hide resolved
@shuding
Copy link
Member

shuding commented Nov 11, 2021

Let's move the webpack change to a separate PR.

@huozhi
Copy link
Member Author

huozhi commented Nov 11, 2021

Separate webpack upgration stuff in #31313

@huozhi huozhi force-pushed the align-readable-stream-impl branch 2 times, most recently from 2f64403 to 0d1a350 Compare November 11, 2021 19:08
@huozhi huozhi requested a review from shuding November 11, 2021 19:22
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 11, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
buildDuration 17.9s 17.8s -53ms
buildDurationCached 3.6s 3.6s -21ms
nodeModulesSize 335 MB 335 MB ⚠️ +596 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
/ failed reqs 0 0
/ total time (seconds) 2.926 2.938 ⚠️ +0.01
/ avg req/sec 854.47 850.84 ⚠️ -3.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.369 1.414 ⚠️ +0.04
/error-in-render avg req/sec 1825.49 1767.7 ⚠️ -57.79
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
buildDuration 19.6s 19.3s -280ms
buildDurationCached 3.6s 3.5s -37ms
nodeModulesSize 335 MB 335 MB ⚠️ +596 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
/ failed reqs 0 0
/ total time (seconds) 2.966 2.968 0
/ avg req/sec 842.75 842.22 ⚠️ -0.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.402 1.406 0
/error-in-render avg req/sec 1783.14 1778.02 ⚠️ -5.12
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js align-readable-stream-impl Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: a6b6eaf

@kodiakhq kodiakhq bot merged commit cf206a8 into vercel:canary Nov 12, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@huozhi huozhi deleted the align-readable-stream-impl branch February 3, 2022 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants