Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for Suspense and streaming #31197

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Nov 9, 2021

Adds a test to ensure that <Suspense> and streaming are working properly with concurrentFeatures enabled.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Nov 9, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 9, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/6cdb Change
buildDuration 20.4s 20.5s ⚠️ +168ms
buildDurationCached 4.1s 4.1s -31ms
nodeModulesSize 333 MB 333 MB -5 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/6cdb Change
/ failed reqs 0 0
/ total time (seconds) 3.458 3.269 -0.19
/ avg req/sec 723.04 764.77 +41.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.567 1.613 ⚠️ +0.05
/error-in-render avg req/sec 1595.11 1549.7 ⚠️ -45.41
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/6cdb Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/6cdb Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/6cdb Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/6cdb Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/6cdb Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/6cdb Change
buildDuration 21.8s 22.6s ⚠️ +879ms
buildDurationCached 4.1s 4.3s ⚠️ +158ms
nodeModulesSize 333 MB 333 MB -5 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/6cdb Change
/ failed reqs 0 0
/ total time (seconds) 3.317 3.488 ⚠️ +0.17
/ avg req/sec 753.65 716.78 ⚠️ -36.87
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.667 1.667
/error-in-render avg req/sec 1499.65 1499.92 +0.27
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/6cdb Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/6cdb Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/6cdb Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/6cdb Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/6cdb Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 53a0762

@kodiakhq kodiakhq bot merged commit 57b4134 into vercel:canary Nov 9, 2021
@shuding shuding deleted the shu/6cdb branch November 9, 2021 13:13
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants