Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite send-trace-to-jaeger in Rust #31392

Merged
merged 4 commits into from
Nov 14, 2021

Conversation

timneutkens
Copy link
Member

Just using this as an opportunity to learn Rust given that it's an internal script 👍

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Just  using this as an opportunity to learn Rust given that it's an internal script 👍
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Nov 14, 2021
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new rustacean :)

scripts/send-trace-to-jaeger/Cargo.toml Show resolved Hide resolved
scripts/send-trace-to-jaeger/src/main.rs Outdated Show resolved Hide resolved
scripts/send-trace-to-jaeger/src/main.rs Outdated Show resolved Hide resolved
@ijjk

This comment has been minimized.

kdy1
kdy1 previously approved these changes Nov 14, 2021
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's simply a coding style issue, so I think it's now fine.

scripts/send-trace-to-jaeger/src/main.rs Outdated Show resolved Hide resolved
scripts/send-trace-to-jaeger/src/main.rs Show resolved Hide resolved
@ijjk
Copy link
Member

ijjk commented Nov 14, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
buildDuration 24.9s 24.8s -66ms
buildDurationCached 4.9s 4.8s -112ms
nodeModulesSize 335 MB 335 MB ⚠️ +1 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
/ failed reqs 0 0
/ total time (seconds) 4.217 4.194 -0.02
/ avg req/sec 592.85 596.06 +3.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.301 2.183 -0.12
/error-in-render avg req/sec 1086.27 1144.95 +58.68
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
buildDuration 27s 26.8s -132ms
buildDurationCached 4.8s 5s ⚠️ +164ms
nodeModulesSize 335 MB 335 MB ⚠️ +1 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
/ failed reqs 0 0
/ total time (seconds) 4.195 4.204 ⚠️ +0.01
/ avg req/sec 595.95 594.72 ⚠️ -1.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.28 2.226 -0.05
/error-in-render avg req/sec 1096.42 1122.96 +26.54
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/rust-based-trace-import Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 7f0e2d9

@timneutkens timneutkens merged commit 28a5d7a into vercel:canary Nov 14, 2021
@timneutkens timneutkens deleted the add/rust-based-trace-import branch November 14, 2021 16:17
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants