Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moment locale replace from craCompat as it's a default in Next.js 12 #31431

Merged

Conversation

timneutkens
Copy link
Member

As the title says, this is no longer needed with Next.js 12 as it's a default in Next.js.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Nov 15, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
buildDuration 26.3s 26.4s ⚠️ +77ms
buildDurationCached 5s 5s -4ms
nodeModulesSize 335 MB 335 MB -433 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
/ failed reqs 0 0
/ total time (seconds) 4.383 4.366 -0.02
/ avg req/sec 570.38 572.61 +2.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.366 2.309 -0.06
/error-in-render avg req/sec 1056.83 1082.78 +25.95
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
buildDuration 28.2s 28.5s ⚠️ +317ms
buildDurationCached 5.1s 5.1s -2ms
nodeModulesSize 335 MB 335 MB -433 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
/ failed reqs 0 0
/ total time (seconds) 4.381 4.354 -0.03
/ avg req/sec 570.61 574.23 +3.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.338 2.299 -0.04
/error-in-render avg req/sec 1069.42 1087.56 +18.14
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/remove-locale-replace-from-cracompat Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: e022205

@ijjk ijjk merged commit 2d9ac39 into vercel:canary Nov 15, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants