Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error link when hydration error occurs #31519

Merged
merged 7 commits into from
Nov 23, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 16, 2021

This adds an error document/link for hydration errors to help users debug these easier. While looking at adding this also noticed a typo in the dev-overlay which is fixed.

screenshot Screen Shot 2021-11-16 at 15 56 29

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review November 16, 2021 23:11
@ijjk

This comment has been minimized.

@molebox molebox self-requested a review November 17, 2021 10:01
errors/react-hydration-error.md Show resolved Hide resolved
errors/react-hydration-error.md Show resolved Hide resolved
errors/react-hydration-error.md Show resolved Hide resolved
@ijjk ijjk requested a review from molebox November 17, 2021 15:36
molebox
molebox previously approved these changes Nov 18, 2021
errors/react-hydration-error.md Show resolved Hide resolved
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@molebox molebox self-requested a review November 22, 2021 10:35
@ijjk
Copy link
Member Author

ijjk commented Nov 23, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
buildDuration 18.4s 18.3s -132ms
buildDurationCached 3.5s 3.6s ⚠️ +70ms
nodeModulesSize 339 MB 339 MB ⚠️ +1.12 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
/ failed reqs 0 0
/ total time (seconds) 2.949 2.961 ⚠️ +0.01
/ avg req/sec 847.61 844.22 ⚠️ -3.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.337 1.401 ⚠️ +0.06
/error-in-render avg req/sec 1870.4 1784.62 ⚠️ -85.78
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
buildDuration 19.5s 19.6s ⚠️ +110ms
buildDurationCached 3.6s 3.7s ⚠️ +92ms
nodeModulesSize 339 MB 339 MB ⚠️ +1.12 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
/ failed reqs 0 0
/ total time (seconds) 2.943 2.932 -0.01
/ avg req/sec 849.47 852.6 +3.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.39 1.389 0
/error-in-render avg req/sec 1799.06 1799.57 +0.51
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js errsh/hydration-error Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: b922a75

@kodiakhq kodiakhq bot merged commit 4b538e9 into vercel:canary Nov 23, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@ijjk ijjk deleted the errsh/hydration-error branch June 30, 2022 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants