Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): consider localhost variations #31603

Merged
merged 7 commits into from
Nov 19, 2021
Merged

fix(middleware): consider localhost variations #31603

merged 7 commits into from
Nov 19, 2021

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Nov 19, 2021

Since localhost is actually an alias for 127.0.0.1 that points to loopback, we should take that into consideration at NextURL when we handle local URLs.

The implementation is based on is-localhost-url; I added some tests over local URLs variations present at the library to ensure other variations are working fine.

Additionally, I refactor some things over the code to avoid doing the same twice and added some legibility that is always welcome when you are working with URLs stuff.

closes #31533

javivelasco
javivelasco previously approved these changes Nov 19, 2021
javivelasco
javivelasco previously approved these changes Nov 19, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 19, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js localhost Change
buildDuration 23.5s 23.4s -59ms
buildDurationCached 4.6s 4.5s -152ms
nodeModulesSize 339 MB 339 MB ⚠️ +474 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js localhost Change
/ failed reqs 0 0
/ total time (seconds) 4.118 3.981 -0.14
/ avg req/sec 607.09 627.93 +20.84
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.208 2.037 -0.17
/error-in-render avg req/sec 1132.46 1227.24 +94.78
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js localhost Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js localhost Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js localhost Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js localhost Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js localhost Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js localhost Change
buildDuration 25.4s 24s -1.3s
buildDurationCached 4.5s 4.4s -96ms
nodeModulesSize 339 MB 339 MB ⚠️ +474 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js localhost Change
/ failed reqs 0 0
/ total time (seconds) 4.039 3.921 -0.12
/ avg req/sec 619.04 637.67 +18.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.027 1.973 -0.05
/error-in-render avg req/sec 1233.42 1266.86 +33.44
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js localhost Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js localhost Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js localhost Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js localhost Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js localhost Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 5eb092b

@kodiakhq kodiakhq bot merged commit f52211b into canary Nov 19, 2021
@kodiakhq kodiakhq bot deleted the localhost branch November 19, 2021 21:24
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour of request.nextUrl.href
3 participants