Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for geo lat and long #31624

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Add types for geo lat and long #31624

merged 1 commit into from
Nov 19, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 19, 2021

Fixes #31620

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk
Copy link
Member

ijjk commented Nov 19, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js types/rq Change
buildDuration 18.2s 18s -117ms
buildDurationCached 3.5s 3.5s ⚠️ +64ms
nodeModulesSize 339 MB 339 MB ⚠️ +127 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js types/rq Change
/ failed reqs 0 0
/ total time (seconds) 2.96 2.96
/ avg req/sec 844.46 844.47 +0.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.328 1.47 ⚠️ +0.14
/error-in-render avg req/sec 1882.75 1701.06 ⚠️ -181.69
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js types/rq Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js types/rq Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js types/rq Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js types/rq Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js types/rq Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js types/rq Change
buildDuration 19.4s 19.6s ⚠️ +221ms
buildDurationCached 3.6s 3.6s -33ms
nodeModulesSize 339 MB 339 MB ⚠️ +127 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js types/rq Change
/ failed reqs 0 0
/ total time (seconds) 2.918 2.976 ⚠️ +0.06
/ avg req/sec 856.7 840.19 ⚠️ -16.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.374 1.388 ⚠️ +0.01
/error-in-render avg req/sec 1819.98 1800.9 ⚠️ -19.08
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js types/rq Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js types/rq Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js types/rq Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js types/rq Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js types/rq Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: fb60b86

@kodiakhq kodiakhq bot merged commit dab7b40 into vercel:canary Nov 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@huozhi huozhi deleted the types/rq branch February 3, 2022 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

longitude and latitude are documented for NextRequest but not typed
3 participants