-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jest examples and docs #31633
Conversation
Co-authored-by: Lee Robinson <[email protected]>
@@ -247,51 +247,86 @@ Jest and React Testing Library are frequently used together for **Unit Testing** | |||
|
|||
### Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if I'm being pedantic here, what are your thoughts on converting this into steps, using the same heading titles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you expand on what you mean here? 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I just mean, would It be clearer for us to explain the QuickStart as a set of steps:
## Step 1: install
## Step2: do something else
This may not be the case here. I don't have a hard and fast rule on this, I just think it makes skimming content easier, you can drop in a a step if need etc.. I don't think this fits in all cases, was wondering what your thoughts are with this section.
I quite like how you have done it tbh, just raising the question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thank you! I agree with you, it's good to give people context at the start. As you said, I'm not sure how the steps would fit this case, but I've added a quick summary here. wdyt?
Co-authored-by: Lee Robinson <[email protected]>
Co-authored-by: Lee Robinson <[email protected]>
Co-authored-by: stefanprobst <[email protected]>
Co-authored-by: stefanprobst <[email protected]>
Co-authored-by: stefanprobst <[email protected]>
Co-authored-by: stefanprobst <[email protected]>
Co-authored-by: Rich Haines <[email protected]>
Co-authored-by: Rich Haines <[email protected]>
…a/next.js into update-jest-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! @molebox has one outstanding comment, but I think you've addressed it 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the
with-jest
example to use the new built-in configuration with SWC. It also creates a newwith-jest-babel
with the recommended configuration for those who opt-out of SWC.Docs have also been updated to include both examples.
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint