Ensure that external modules are not bundled into the client for RSC #31968

shuding · 2021-11-30T18:22:04Z

If importing an external module inside a Server Component (.server.js), it shouldn't be bundled into the client. Only client components should be kept.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

packages/next/build/webpack/loaders/next-flight-server-loader.ts

ijjk

Can we add a test case for this?

ijjk · 2021-11-30T19:00:28Z

Failing test suites

Commit: e42cf0a

test/integration/react-streaming-and-server-components/test/index.test.js

concurrentFeatures - dev > should suspense next/link on server side
concurrentFeatures - dev > should suspense next/image on server side
concurrentFeatures - prod > should suspense next/link on server side
concurrentFeatures - prod > should suspense next/image on server side

Expand output

● concurrentFeatures - prod › should suspense next/link on server side

expect(received).toContain(expected) // indexOf

Expected substring: "go home"
Received string:    ""

  230 |       context.appPort,
  231 |       '/routes/dynamic1'
> 232 |     )
      |      ^
  233 |     const dynamicRouteHTML2 = await renderViaHTTP(
  234 |       context.appPort,
  235 |       '/routes/dynamic2'

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:232:26)

● concurrentFeatures - prod › should suspense next/image on server side

expect(received).toContain(expected) // indexOf

Matcher error: received value must not be null nor undefined

Received has value: undefined

  236 |     )
  237 |
> 238 |     const path404HTML = await renderViaHTTP(context.appPort, '/404')
      |                                      ^
  239 |     const path500HTML = await renderViaHTTP(context.appPort, '/err')
  240 |     const pathNotFoundHTML = await renderViaHTTP(
  241 |       context.appPort,

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:238:38)

● concurrentFeatures - dev › should suspense next/link on server side

expect(received).toContain(expected) // indexOf

Expected substring: "go home"
Received string:    ""

  230 |       context.appPort,
  231 |       '/routes/dynamic1'
> 232 |     )
      |      ^
  233 |     const dynamicRouteHTML2 = await renderViaHTTP(
  234 |       context.appPort,
  235 |       '/routes/dynamic2'

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:232:26)

● concurrentFeatures - dev › should suspense next/image on server side

expect(received).toContain(expected) // indexOf

Matcher error: received value must not be null nor undefined

Received has value: undefined

  236 |     )
  237 |
> 238 |     const path404HTML = await renderViaHTTP(context.appPort, '/404')
      |                                      ^
  239 |     const path500HTML = await renderViaHTTP(context.appPort, '/err')
  240 |     const pathNotFoundHTML = await renderViaHTTP(
  241 |       context.appPort,

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:238:38)

ijjk · 2021-11-30T22:17:01Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
buildDuration	19.3s	19.4s	⚠️ +35ms
buildDurationCached	3.6s	3.6s	⚠️ +31ms
nodeModulesSize	347 MB	347 MB	⚠️ +990 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.055	3.06	0
/ avg req/sec	818.26	816.94	⚠️ -1.32
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.5	1.485	-0.01
/error-in-render avg req/sec	1666.49	1683.71	+17.22

Client Bundles (main, webpack, commons)

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.4 kB	28.4 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.3 kB	72.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.49 kB	4.49 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC

General Overall increase ⚠️

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
buildDuration	20.4s	20.4s	-3ms
buildDurationCached	3.5s	3.6s	⚠️ +82ms
nodeModulesSize	347 MB	347 MB	⚠️ +990 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.07	3.081	⚠️ +0.01
/ avg req/sec	814.27	811.53	⚠️ -2.74
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.449	1.446	0
/error-in-render avg req/sec	1725.9	1729.33	+3.43

Client Bundles (main, webpack, commons)

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.53 kB	4.53 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/cf3e	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 03040c1

benschwarz · 2021-11-30T22:44:28Z

Just making note of my test case in case it's helpful.

ensure to not import external modules

13daa54

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 30, 2021

improve condition

e42cf0a

shuding marked this pull request as ready for review November 30, 2021 18:27

shuding requested review from huozhi, ijjk, padmaia and timneutkens as code owners November 30, 2021 18:27

huozhi reviewed Nov 30, 2021

View reviewed changes

packages/next/build/webpack/loaders/next-flight-server-loader.ts Show resolved Hide resolved

huozhi previously approved these changes Nov 30, 2021

View reviewed changes

ijjk reviewed Nov 30, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

fix tests

d66f062

shuding dismissed huozhi’s stale review via d66f062 November 30, 2021 19:57

Merge branch 'canary' into shu/cf3e

5eecb5f

This comment has been minimized.

Sign in to view

ijjk approved these changes Nov 30, 2021

View reviewed changes

kodiakhq bot added 2 commits November 30, 2021 20:54

Merge branch 'canary' into shu/cf3e

500e923

Merge branch 'canary' into shu/cf3e

5ea43e2

This comment has been minimized.

Sign in to view

Merge branch 'canary' into shu/cf3e

9a7bc3e

This comment has been minimized.

Sign in to view

kodiakhq bot added 2 commits November 30, 2021 21:51

Merge branch 'canary' into shu/cf3e

2fa00db

Merge branch 'canary' into shu/cf3e

03040c1

kodiakhq bot merged commit b7fb315 into vercel:canary Nov 30, 2021

shuding deleted the shu/cf3e branch November 30, 2021 22:57

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure that external modules are not bundled into the client for RSC #31968

Ensure that external modules are not bundled into the client for RSC #31968

shuding commented Nov 30, 2021 •

edited

Loading

ijjk left a comment

This comment has been minimized.

ijjk commented Nov 30, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Nov 30, 2021

benschwarz commented Nov 30, 2021

Ensure that external modules are not bundled into the client for RSC #31968

Ensure that external modules are not bundled into the client for RSC #31968

Conversation

shuding commented Nov 30, 2021 • edited Loading

Bug

Feature

Documentation / Examples

ijjk left a comment

Choose a reason for hiding this comment

This comment has been minimized.

ijjk commented Nov 30, 2021

Failing test suites

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Nov 30, 2021

Stats from current PR

benschwarz commented Nov 30, 2021

shuding commented Nov 30, 2021 •

edited

Loading