Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying swc binary for isolated tests locally #32026

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 2, 2021

This updates to ensure we properly copy the swc binary to the native folder in the next-swc package for running isolated tests locally and the binary hasn't been built manually.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 2, 2021
@ijjk
Copy link
Member Author

ijjk commented Dec 2, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
buildDuration 22.1s 23.1s ⚠️ +1s
buildDurationCached 4.1s 3.9s -245ms
nodeModulesSize 347 MB 347 MB ⚠️ +8 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
/ failed reqs 0 0
/ total time (seconds) 3.963 3.748 -0.21
/ avg req/sec 630.86 667.02 +36.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.032 1.91 -0.12
/error-in-render avg req/sec 1230.15 1309.15 +79
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
buildDuration 23.4s 22.7s -645ms
buildDurationCached 3.8s 4.1s ⚠️ +307ms
nodeModulesSize 347 MB 347 MB ⚠️ +8 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
/ failed reqs 0 0
/ total time (seconds) 3.841 3.656 -0.19
/ avg req/sec 650.88 683.77 +32.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.016 1.918 -0.1
/error-in-render avg req/sec 1240.08 1303.29 +63.21
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/create-local-isolated Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 86e2ee9

@timneutkens timneutkens merged commit 03317c7 into vercel:canary Dec 2, 2021
@timneutkens timneutkens deleted the fix/create-local-isolated branch December 2, 2021 12:40
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants