Remove "yarn jest" from Next.js repo scripts #32042

timneutkens · 2021-12-02T12:38:04Z

Removes yarn test from the scripts as it has the wrong options. yarn testonly or yarn testheadless are the way to run tests. Fixes #32031

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk · 2021-12-02T13:03:50Z

Failing test suites

Commit: 1d5e95a

test/integration/image-component/base-path/test/static.test.js

Static Image Component Tests for basePath > dev mode > Should allow an image with a static src to omit height and width
Static Image Component Tests for basePath > dev mode > Should use immutable cache-control header for static import
Static Image Component Tests for basePath > dev mode > Should automatically provide an image height and width
Static Image Component Tests for basePath > dev mode > Should allow provided width and height to override intrinsic
Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported jpg
Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported png
Static Image Component Tests for basePath > production mode > Should allow an image with a static src to omit height and width
Static Image Component Tests for basePath > production mode > Should use immutable cache-control header for static import
Static Image Component Tests for basePath > production mode > Should use immutable cache-control header even when unoptimized
Static Image Component Tests for basePath > production mode > Should automatically provide an image height and width
Static Image Component Tests for basePath > production mode > Should allow provided width and height to override intrinsic
Static Image Component Tests for basePath > production mode > Should add a blur placeholder to statically imported jpg
Static Image Component Tests for basePath > production mode > Should add a blur placeholder to statically imported png

Expand output

● Static Image Component Tests for basePath › production mode › Should allow an image with a static src to omit height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:42829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should use immutable cache-control header for static import

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:42829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should use immutable cache-control header even when unoptimized

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:42829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should automatically provide an image height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:42829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should allow provided width and height to override intrinsic

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:42829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should add a blur placeholder to statically imported jpg

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:42829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should add a blur placeholder to statically imported png

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:42829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › dev mode › Should allow an image with a static src to omit height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:41261/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should use immutable cache-control header for static import

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:41261/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should automatically provide an image height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:41261/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should allow provided width and height to override intrinsic

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:41261/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported jpg

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:41261/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported png

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:41261/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

ijjk · 2021-12-03T01:28:25Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
buildDuration	23.9s	23.8s	-36ms
buildDurationCached	4.3s	4.2s	-72ms
nodeModulesSize	347 MB	347 MB	⚠️ +10 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.843	4.037	⚠️ +0.19
/ avg req/sec	650.56	619.32	⚠️ -31.24
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.066	2.083	⚠️ +0.02
/error-in-render avg req/sec	1210.35	1200.07	⚠️ -10.28

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.4 kB	28.4 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.3 kB	72.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.49 kB	4.49 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
index.html gzip	533 B	533 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
buildDuration	26.2s	25.9s	-275ms
buildDurationCached	4.2s	4.4s	⚠️ +205ms
nodeModulesSize	347 MB	347 MB	⚠️ +10 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.974	3.969	-0.01
/ avg req/sec	629.13	629.85	+0.72
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.072	2.059	-0.01
/error-in-render avg req/sec	1206.69	1214.36	+7.67

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.53 kB	4.53 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.9 kB	1.9 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-test-command-repo	Change
index.html gzip	533 B	533 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 6a00b86

Removes `yarn test` from the scripts as it has the wrong options. `yarn testonly` or `yarn testheadless` are the way to run tests. Fixes #32031 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`

chentsulin · 2021-12-03T10:05:08Z

How about the testall command?

https://github.com/timneutkens/next.js/blob/21bae2b71bd596bce14e0cb3daa21503aa8001dc/package.json#L18

Should it be moved too? It refers to the dead yarn test command.

`yarn test` has been removed by #32042, so it should be replaced by the other test scripts.

Remove "yarn jest" from Next.js repo scripts

1d5e95a

timneutkens requested review from huozhi, ijjk and shuding as code owners December 2, 2021 12:38

ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 2, 2021

This comment has been minimized.

Sign in to view

ijjk approved these changes Dec 2, 2021

View reviewed changes

balazsorban44 and others added 2 commits December 3, 2021 02:07

Merge branch 'canary' into add/remove-test-command-repo

c9a5b46

Merge branch 'canary' into add/remove-test-command-repo

6a00b86

ijjk approved these changes Dec 3, 2021

View reviewed changes

kodiakhq bot merged commit b691419 into vercel:canary Dec 3, 2021

chentsulin mentioned this pull request Dec 3, 2021

Fix the testall npm script #32081

Merged

kodiakhq bot pushed a commit that referenced this pull request Dec 3, 2021

Fix the testall npm script (#32081)

3a5e424

`yarn test` has been removed by #32042, so it should be replaced by the other test scripts.

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove "yarn jest" from Next.js repo scripts #32042

Remove "yarn jest" from Next.js repo scripts #32042

timneutkens commented Dec 2, 2021

This comment has been minimized.

ijjk commented Dec 2, 2021

ijjk commented Dec 3, 2021

chentsulin commented Dec 3, 2021

Remove "yarn jest" from Next.js repo scripts #32042

Remove "yarn jest" from Next.js repo scripts #32042

Conversation

timneutkens commented Dec 2, 2021

Bug

Feature

Documentation / Examples

This comment has been minimized.

ijjk commented Dec 2, 2021

Failing test suites

ijjk commented Dec 3, 2021

Stats from current PR

chentsulin commented Dec 3, 2021