Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Base Server #32105

Closed
wants to merge 1 commit into from
Closed

Create Base Server #32105

wants to merge 1 commit into from

Conversation

shuding
Copy link
Member

@shuding shuding commented Dec 4, 2021

Explained in #32066, rename next-server as base-server and extend NextNodeServer on top of it.

Note that this is just an initial PR so no method is ported.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 4, 2021
@shuding shuding mentioned this pull request Dec 4, 2021
10 tasks
@ijjk
Copy link
Member

ijjk commented Dec 4, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/53c8 Change
buildDuration 19.2s 19.3s ⚠️ +106ms
buildDurationCached 3.4s 3.5s ⚠️ +108ms
nodeModulesSize 347 MB 347 MB ⚠️ +1.84 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/53c8 Change
/ failed reqs 0 0
/ total time (seconds) 3.29 3.403 ⚠️ +0.11
/ avg req/sec 759.78 734.61 ⚠️ -25.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.743 1.804 ⚠️ +0.06
/error-in-render avg req/sec 1434.01 1385.5 ⚠️ -48.51
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/53c8 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/53c8 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/53c8 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/53c8 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/53c8 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/53c8 Change
buildDuration 21.2s 21.1s -116ms
buildDurationCached 3.6s 3.4s -162ms
nodeModulesSize 347 MB 347 MB ⚠️ +1.84 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/53c8 Change
/ failed reqs 0 0
/ total time (seconds) 3.339 3.4 ⚠️ +0.06
/ avg req/sec 748.62 735.37 ⚠️ -13.25
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.732 1.773 ⚠️ +0.04
/error-in-render avg req/sec 1443.01 1410.14 ⚠️ -32.87
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/53c8 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/53c8 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/53c8 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/53c8 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/53c8 Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 4f18510

@shuding shuding closed this Dec 5, 2021
@shuding shuding deleted the shu/53c8 branch December 5, 2021 20:50
@shuding shuding mentioned this pull request Dec 5, 2021
10 tasks
kodiakhq bot pushed a commit that referenced this pull request Dec 5, 2021
Same as #32105 (closed due to conflicts):

> Explained in #32066, rename next-server as base-server and extend NextNodeServer on top of it.
>
> Note that this is just an initial PR so no method is ported.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants