-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[with-typescript-graphql] fixes breaking changes in graphql-let v0.18.0 #32681
Merged
ijjk
merged 23 commits into
vercel:canary
from
u-yas:migrate_graphql-let_to_with-typescript-graphql
Feb 6, 2022
Merged
[with-typescript-graphql] fixes breaking changes in graphql-let v0.18.0 #32681
ijjk
merged 23 commits into
vercel:canary
from
u-yas:migrate_graphql-let_to_with-typescript-graphql
Feb 6, 2022
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u-yas
requested review from
ijjk,
leerob,
shuding,
steven-tey and
timneutkens
as code owners
December 20, 2021 18:05
leerob
reviewed
Dec 20, 2021
ijjk
approved these changes
Feb 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
….0 (vercel#32681) * Migrate graphql-let v0.18.0 according to the documentation * lint-fix Co-authored-by: JJ Kasper <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Documentation / Examples
yarn lint
Following this migration guide, I modified the code with-typescript-graphql