Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract out native filesystem usage from the base server #33226

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Abstract out native filesystem usage from the base server #33226

merged 3 commits into from
Jan 12, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Jan 12, 2022

This PR moves require and fs usage from the base server to the node server. Closes #32322.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 12, 2022
@shuding shuding marked this pull request as ready for review January 12, 2022 16:59
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jan 12, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/86b5 Change
buildDuration 19.4s 18.5s -855ms
buildDurationCached 4.1s 4s -9ms
nodeModulesSize 355 MB 355 MB ⚠️ +2.22 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/86b5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.798 3.912 ⚠️ +0.11
/ avg req/sec 658.28 639 ⚠️ -19.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.959 1.964 0
/error-in-render avg req/sec 1276.27 1272.71 ⚠️ -3.56
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary shuding/next.js shu/86b5 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB -1 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB -1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/86b5 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/86b5 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/86b5 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/86b5 Change
index.html gzip 530 B 531 B ⚠️ +1 B
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ⚠️ +1 B

Diffs

Diff for main-HASH.js 
@@ -7783,8 +7783,8 @@
       exports.loadGetInitialProps = loadGetInitialProps;
       exports.formatWithValidation = formatWithValidation;
       exports.HtmlContext = exports.ST = exports.SP = exports.urlObjectKeys = void 0;
-      var _formatUrl = __webpack_require__(4611);
       var _react = __webpack_require__(7294);
+      var _formatUrl = __webpack_require__(4611);
       function execOnce(fn) {
         var used = false;
         var result;
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-e224eb07e1e2986e.js"
+      src="/_next/static/chunks/main-64133e0a9367c5c5.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-e224eb07e1e2986e.js"
+      src="/_next/static/chunks/main-64133e0a9367c5c5.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-e224eb07e1e2986e.js"
+      src="/_next/static/chunks/main-64133e0a9367c5c5.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/86b5 Change
buildDuration 19.7s 19.8s ⚠️ +122ms
buildDurationCached 4.1s 3.9s -208ms
nodeModulesSize 355 MB 355 MB ⚠️ +2.22 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/86b5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.971 3.793 -0.18
/ avg req/sec 629.62 659.09 +29.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.011 1.862 -0.15
/error-in-render avg req/sec 1243.22 1342.95 +99.73
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary shuding/next.js shu/86b5 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB -1 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.2 kB 71.2 kB -1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/86b5 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/86b5 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/86b5 Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary shuding/next.js shu/86b5 Change
index.html gzip 531 B 530 B -1 B
link.html gzip 544 B 544 B ✓
withRouter.html gzip 527 B 526 B -1 B
Overall change 1.6 kB 1.6 kB -2 B

Diffs

Diff for main-HASH.js 
@@ -7783,8 +7783,8 @@
       exports.loadGetInitialProps = loadGetInitialProps;
       exports.formatWithValidation = formatWithValidation;
       exports.HtmlContext = exports.ST = exports.SP = exports.urlObjectKeys = void 0;
-      var _formatUrl = __webpack_require__(4611);
       var _react = __webpack_require__(7294);
+      var _formatUrl = __webpack_require__(4611);
       function execOnce(fn) {
         var used = false;
         var result;
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-e224eb07e1e2986e.js"
+      src="/_next/static/chunks/main-64133e0a9367c5c5.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-e224eb07e1e2986e.js"
+      src="/_next/static/chunks/main-64133e0a9367c5c5.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-e224eb07e1e2986e.js"
+      src="/_next/static/chunks/main-64133e0a9367c5c5.js"
       defer=""
     ></script>
     <script
Commit: 4ca5d56

@kodiakhq kodiakhq bot merged commit 5572eb3 into vercel:canary Jan 12, 2022
@shuding shuding deleted the shu/86b5 branch January 12, 2022 18:45
@shuding shuding mentioned this pull request Jan 12, 2022
Closed
15 tasks
@vercel vercel locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuding @ijjk @huozhi