-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add new Tailwind CSS Prettier plugin to example #33614
Merged
kodiakhq
merged 2 commits into
vercel:canary
from
ecklf:feat/example-tailwindcss-prettier
Jan 24, 2022
Merged
[examples] Add new Tailwind CSS Prettier plugin to example #33614
kodiakhq
merged 2 commits into
vercel:canary
from
ecklf:feat/example-tailwindcss-prettier
Jan 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecklf
requested review from
ijjk,
leerob,
shuding,
steven-tey and
timneutkens
as code owners
January 24, 2022 20:49
leerob
approved these changes
Jan 24, 2022
leerob
changed the title
add new tailwindcss prettier plugin to example
[examples] Add new Tailwind CSS Prettier plugin to example
Jan 24, 2022
This was referenced Jan 27, 2022
1 task
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 5, 2022
## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` --- I'm getting this warning when running `yarn lint` on the local: ![Screen Shot 2022-02-05 at 23 45 57](https://user-images.githubusercontent.com/38455472/152651090-be515630-591a-4602-8bd7-eda71174dfda.png) After a quick check, it is caused by the `tailwindConfig` option in the `prettier.config.js` file, added in PR #33614 I guess the reason is because the workspace does not install that plugin. We can safely remove that option in the example, because it's already [the default location](https://github.com/tailwindlabs/prettier-plugin-tailwindcss): > By default the plugin will look for this file in the same directory as your Prettier configuration file. However, if your Tailwind configuration is somewhere else, you can specify this using the tailwindConfig option in your Prettier configuration. ![Screen Shot 2022-02-06 at 00 12 24](https://user-images.githubusercontent.com/38455472/152651623-86655e80-e8d0-45b1-968c-81b7beed48ea.png) The warning is gone after removing that option.
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
) ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` This PR adds the new official plugin for class sorting from Tailwind Labs to the Tailwind example. Rel: https://tailwindcss.com/blog/automatic-class-sorting-with-prettier
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
…#34019) ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` --- I'm getting this warning when running `yarn lint` on the local: ![Screen Shot 2022-02-05 at 23 45 57](https://user-images.githubusercontent.com/38455472/152651090-be515630-591a-4602-8bd7-eda71174dfda.png) After a quick check, it is caused by the `tailwindConfig` option in the `prettier.config.js` file, added in PR vercel#33614 I guess the reason is because the workspace does not install that plugin. We can safely remove that option in the example, because it's already [the default location](https://github.com/tailwindlabs/prettier-plugin-tailwindcss): > By default the plugin will look for this file in the same directory as your Prettier configuration file. However, if your Tailwind configuration is somewhere else, you can specify this using the tailwindConfig option in your Prettier configuration. ![Screen Shot 2022-02-06 at 00 12 24](https://user-images.githubusercontent.com/38455472/152651623-86655e80-e8d0-45b1-968c-81b7beed48ea.png) The warning is gone after removing that option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation / Examples
yarn lint
This PR adds the new official plugin for class sorting from Tailwind Labs to the Tailwind example.
Rel: https://tailwindcss.com/blog/automatic-class-sorting-with-prettier